Re: [PATCH] counter: stm32-lptimer-cnt: remove iio counter abi

[Fabrice Gasnier <fabrice.gasnier@foss.st.com>]

On 1/29/21 9:35 AM, William Breathitt Gray wrote:
> On Fri, Jan 22, 2021 at 04:03:23PM +0100, Fabrice Gasnier wrote:
>> Currently, the STM32 LP Timer counter driver registers into both IIO and
>> counter subsystems, which is redundant.
>>
>> Remove the IIO counter ABI and IIO registration from the STM32 LP Timer
>> counter driver since it's been superseded by the Counter subsystem
>> as discussed in [1].
>>
>> Keep only the counter subsystem related part.
>> Move a part of the ABI documentation into a driver comment.
>>
>> This also removes a duplicate ABI warning
>> $ scripts/get_abi.pl validate
>> ...
>> /sys/bus/iio/devices/iio:deviceX/in_count0_preset is defined 2 times:
>>   ./Documentation/ABI/testing/sysfs-bus-iio-timer-stm32:100
>>   ./Documentation/ABI/testing/sysfs-bus-iio-lptimer-stm32:0
>>
>> [1] https://lkml.org/lkml/2021/1/19/347
>>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>> ---
>>  .../ABI/testing/sysfs-bus-iio-lptimer-stm32        |  62 -----
>>  drivers/counter/stm32-lptimer-cnt.c                | 297 +++------------------
>>  2 files changed, 36 insertions(+), 323 deletions(-)
>>  delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lptimer-stm32
> 
> Hi Fabrice,
> 
> I noticed this is missing a Kconfig change to remove the IIO dependency
> from the STM32_LPTIMER_CNT config option. I assume that dependency is no
> longer necessary with the IIO code is removed.

Hi William,

Thanks for spotting this.
I'll send a v2 with that fixed.
I assume I can add your ack'ed by for v2 (as commented earlier) ?

Best Regards,
Fabrice

> 
> William Breathitt Gray
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel