From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B491CE77188 for ; Tue, 14 Jan 2025 12:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L7S3Bqm4SNa/5fzzRYJGEgkQpxjwQsp8IpalJXQqIYs=; b=Oi884MTdLEn+DjaUTtVOhHBQTL USErZ1BFGVlTFaxmNXIYPxfMGwhgB89tiJSU7dqJPAft3cDsBxV1WBqV0LY7PMUeQMAzL5v8MdXFl p3U4fR4W6XhvRruH0eF8GZFTpVpYw8KPU6mnZ4IfLib9sL+h+dmC3yi+/pyAR5a3zTj8OQzPsmNnC oAdarNKydgTBEyRwr+Q1snr/sR5ZtvshbWMNFn1y2/rAIUhziR2zYHwtls9KQfQGIO1mcbyvGRFQa hbnw+EBea/+V7SlXmzgrXtqXAKC/hhX51ySr6e6reHk1C2LiDAxokI4wcTFrl8YxuXGDcw4irL3V5 Bz7rm6Ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tXflw-00000008Lyc-07Sc; Tue, 14 Jan 2025 12:11:52 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tXfkh-00000008Lty-2LCW for linux-arm-kernel@lists.infradead.org; Tue, 14 Jan 2025 12:10:36 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-385e44a1a2dso328498f8f.3 for ; Tue, 14 Jan 2025 04:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736856633; x=1737461433; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=L7S3Bqm4SNa/5fzzRYJGEgkQpxjwQsp8IpalJXQqIYs=; b=Pnr3eW3BetvEg/ktOqUCC2lKPxTrznKGf71Zs4UlBpR5wqUA2FbQmvNWgcsJuOGqCa xNTpcHgeSzk2cfAJIm0TdCxDReBX+yzkHnW3T8W+uyZHPHigbTRTEkRcHr1LXsQGtUno fdDqHGaamHqciOUCF5+6HftNtJ3R8kIKR1Y06HyvNbY7iXbPwd3VsTeq3NRhel60J7Fk goi3rtISkuXXnPYa6Swha0KyzLLXkTw+wUBmBvxN0xxDQiexQNTaI4GoUcZRA5I662V4 j82EOYQjis9MMb1wm4XiSXM7iMIE/JqiFeKQWY7DcKUfssHAtjzX5w2/hRZ/0GzhG+bK +wzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736856633; x=1737461433; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L7S3Bqm4SNa/5fzzRYJGEgkQpxjwQsp8IpalJXQqIYs=; b=byptcof9IDfocJhuEBlB8bepSbyTfSLkFrCrrlh23zVnAAh4nKhU/v9QcOHCvqzAFd Y0IkLX3FMYXDjY14ShU0YPapW+GvBcjRNQMHq2g6kgencg8B7JJU5y7dkY0CvtfMP84y RbGc+UmN9jnyuIqK9PUlZmN4OiByoCOHqvQv+/4m7HCcCG4EchPFy+1sDImWoJ47wdbL PSnW9I2TVt/2FpwL396c28i6VNnvuVlDo8jqKOK5WU9nRY6AW678pThd5/Tm40/uBHft q6thJSHwabZ/Mmn4uhKHvfJSmLKtgIEiwX+MuTNmohGKirNp3sMrye+iMM+KBjo+Oz0b kPtw== X-Forwarded-Encrypted: i=1; AJvYcCUxQ9u8SFauJqczjow/fbBubZcXBM1uS8/bp6voLEifofnpif9RyXTHMU9BZiw6Rd+IgZgCD2perxLsObssDHTY@lists.infradead.org X-Gm-Message-State: AOJu0Yzhxt//8+WFr3jAd57NgEoDcMkxfJUOroC+h+JAA49qEKNRmdyQ cTpI+lcjQeAOmgh+Zr+s9SoObnUPjKc8w12cXu7UVAVNXl1nNuc1CJp/9u1dWPI= X-Gm-Gg: ASbGncv9nn9nHJNBUaBdDKUU+0kg5pJkWThl84Z1Pm2rUQ8nJ6t4652vNgndzxSQb5c Qt66cds4ewoAbvBPMCS6YJlftG0aXbFzerIOL8h5SPy0liZvfkkJ/A7YabIcuQxVFmE1kYrTzki gsI0oTOcIOGW6BoVi/y3mkKxbVZ/HSdNbE7PAGZbob5r5qbq3p0yWOTeysKSrnkjbaPef6m9rir gMP9qbERE5sN/+XskSlGUTb2sEDT3LPLwmeLDvwqzetoDIeeylWMUwCeFFH+j++Ez95Z3VqCki5 X-Google-Smtp-Source: AGHT+IEyJ/lzH1HupLPZyyqFfgaVEsvS8mYjH3oZgQAV4JnCkZ/mE9gYnmXZGtd/cwlAg1EayO2C/Q== X-Received: by 2002:a5d:648f:0:b0:385:f479:ef46 with SMTP id ffacd0b85a97d-38a87310d7bmr7823496f8f.13.1736856633432; Tue, 14 Jan 2025 04:10:33 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38c6dbsm14958381f8f.55.2025.01.14.04.10.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 04:10:32 -0800 (PST) Message-ID: Date: Tue, 14 Jan 2025 13:10:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: clock: convert stm32 rcc bindings to json-schema To: Dario Binacchi Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Alexandre Torgue , Conor Dooley , Krzysztof Kozlowski , Maxime Coquelin , Michael Turquette , Philipp Zabel , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20250114091128.528757-1-dario.binacchi@amarulasolutions.com> <20250114091128.528757-2-dario.binacchi@amarulasolutions.com> <79a90c01-9e21-4e3f-a334-6ba9e1df4150@kernel.org> <54b63cfc-7a51-4b69-8b32-eb7591b2169b@kernel.org> <581275bf-11f3-4a8a-8e58-75b00c515c79@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250114_041035_619838_1AB42B56 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/01/2025 12:25, Dario Binacchi wrote: > On Tue, Jan 14, 2025 at 11:13 AM Krzysztof Kozlowski > wrote: >> >> On 14/01/2025 11:00, Dario Binacchi wrote: >>> On Tue, Jan 14, 2025 at 10:48 AM Krzysztof Kozlowski wrote: >>>> >>>> On 14/01/2025 10:36, Dario Binacchi wrote: >>>>>> Nothing improved here. >>>>> >>>>> In my humble opinion, there is nothing to improve. Any modification >>>>> made causes the tests to fail. >>>>> >>>>> $ git grep st,stm32f746-rcc arch/ >>>>> arch/arm/boot/dts/st/stm32f746.dtsi: compatible = >>>>> "st,stm32f746-rcc", "st,stm32-rcc"; >>>>> arch/arm/boot/dts/st/stm32f769-disco.dts: compatible = >>>>> "st,stm32f769-rcc", "st,stm32f746-rcc", "st,stm32-rcc"; >>>>> >>>>> Or am I missing something? >>>> >>>> How can I know what you are missing if you do not show the code? >>> >>> Sorry, but I still can't understand. I run multiple tests, trying to >> >> You don't understand that I cannot improve your code if I do not see the >> code? So let me rephrase: In order to tell what is wrong with some sort >> of code, I need to see it. I cannot tell what is wrong with code without >> seeing it. > > You told me that this code was not exactly correct for the parts > marked with *********: All places with same fallbacks should be unified. You have at least two of such groups. > > properties: > compatible: > oneOf: > - items: > - const: st,stm32f42xx-rcc > - const: st,stm32-rcc > - items: > - enum: > - st,stm32f469-rcc > - const: st,stm32f42xx-rcc > - const: st,stm32-rcc > - items: > - const: st,stm32f746-rcc ******** > - const: st,stm32-rcc > - items: > - enum: > - st,stm32f769-rcc > - const: st,stm32f746-rcc > - const: st,stm32-rcc > - items: > - const: st,stm32h743-rcc ********* > - const: st,stm32-rcc > > I haven't found a way to make changes to those elements without causing the > tests to fail. Could you kindly provide more explicit guidance on the kind of > modification you're expecting? > items: - enum: - foo - bar - const: baz Like I said: all Qcom bindings. Probably all NXP as well. Best regards, Krzysztof