From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DCB9C54791 for ; Wed, 13 Mar 2024 11:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ISrQYgFfuVZW1ridsHk9YIqxEQf8dD36F6EIVkCBlRU=; b=AQLGrbDbLvqmZR 8L/n7Uix8kLRV4YkY5U6Ti1+z0/xUjQX8TPS3xaAwU+kG/onS15nyFRDPfyqbADAAGZ0+h7HYSeN0 7ON6L9B2GuzD/0RTE73Jed0I+YO2+n0LwwyN6tkIAxAi9bV8w+HIVLr2vqC8S1YhqvuA32qNzg5XA KPsb0EYFCW3DblHHTCZuwThR6IGzZEtGD8BB9V8ts4D3QYuEz5kWwlZLAueSjNwuHDnDQl7c4hXRv DgeYgzfkstHeaVBZLQNEnW8pUqIF3OmV6auNL/31NlZ4Vh5CJa/O5TZJCoKfIzv5C4z9LzUcznjfm 1iD146dOgbh1VCE9x+TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkMkV-00000009ul1-2Sj0; Wed, 13 Mar 2024 11:26:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkMkR-00000009uj5-1WZ4 for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 11:26:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A67731007; Wed, 13 Mar 2024 04:26:49 -0700 (PDT) Received: from [192.168.1.100] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B59A3F73F; Wed, 13 Mar 2024 04:26:09 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 11:26:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 00/10] perf: Clean up common uncore boilerplate Content-Language: en-US To: Robin Murphy Cc: Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-perf-users@vger.kernel.org, jialong.yang@shingroup.cn, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Will Deacon References: From: James Clark In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_042615_582862_3DFE9B6F X-CRM114-Status: GOOD ( 22.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/03/2024 17:34, Robin Murphy wrote: > Hi all, > > Since this came up yet again recently, and it's an idea which has been > nagging me for years, I decided it was time to see how hard it really > would be to start shaving this yak. And it turns out to be refreshingly > simple - the core code has quietly become capable of doing most of what > we want, the one new functional addition is trivial (patch #2), and the > resulting largely-mechanical cleanup seems a pretty nice win. > > This series is focused on drivers/perf/ as that's where most mess is > concentrated, but figured I'd include the arch/ patches as well since > they might be reasonable to land with the core changes, at least for x86 > (FWIW I did also look at the powerpc drivers but they scared me and I > ran away; sorry). The remaining stragglers elsewhere around the tree I'd > come back to as a follow-up. > > (And yes, I appreciate it's mid-merge-window already, but since I do > have a tree-wide rename proposed here, may as well give the discussion > a chance for a head start before -rc1...) > > Thanks, > Robin. > > Reviewed-by: James Clark > Robin Murphy (10): > perf/alibaba_uncore_drw: Use correct CPU affinity > perf: Add capability for common event support > drivers/perf: Use PERF_PMU_CAP_NO_COMMON_EVENTS > perf: Rename PERF_PMU_CAP_NO_INTERRUPT > drivers/perf: Use PERF_PMU_CAP_NO_SAMPLING consistently > drivers/perf: Clean up redundant per-task checks > perf: Define common uncore capabilities > drivers/perf: Use common uncore capabilities > x86: Use common uncore PMU capabilities > ARM: Use common uncore PMU capabilities > > arch/arc/kernel/perf_event.c | 2 +- > arch/arm/mach-imx/mmdc.c | 16 +------------- > arch/arm/mm/cache-l2x0-pmu.c | 12 +--------- > arch/csky/kernel/perf_event.c | 2 +- > arch/powerpc/perf/8xx-pmu.c | 2 +- > arch/powerpc/perf/hv-24x7.c | 2 +- > arch/powerpc/perf/hv-gpci.c | 2 +- > arch/powerpc/platforms/pseries/papr_scm.c | 2 +- > arch/s390/kernel/perf_cpum_cf.c | 2 +- > arch/sh/kernel/perf_event.c | 2 +- > arch/x86/events/amd/iommu.c | 17 +------------- > arch/x86/events/amd/power.c | 10 +-------- > arch/x86/events/amd/uncore.c | 12 +++------- > arch/x86/events/core.c | 2 +- > arch/x86/events/intel/cstate.c | 16 +++----------- > arch/x86/events/intel/uncore.c | 11 +-------- > arch/x86/events/intel/uncore_snb.c | 20 +++-------------- > arch/x86/events/msr.c | 9 +------- > arch/x86/events/rapl.c | 9 +------- > drivers/fpga/dfl-fme-perf.c | 2 +- > drivers/perf/alibaba_uncore_drw_pmu.c | 27 +++-------------------- > drivers/perf/amlogic/meson_ddr_pmu_core.c | 11 +-------- > drivers/perf/arm-cci.c | 15 +------------ > drivers/perf/arm-ccn.c | 20 +---------------- > drivers/perf/arm-cmn.c | 10 +-------- > drivers/perf/arm_cspmu/arm_cspmu.c | 27 ++--------------------- > drivers/perf/arm_dmc620_pmu.c | 18 +-------------- > drivers/perf/arm_dsu_pmu.c | 22 +----------------- > drivers/perf/arm_pmu_platform.c | 2 +- > drivers/perf/arm_smmuv3_pmu.c | 15 +------------ > drivers/perf/arm_spe_pmu.c | 7 ++---- > drivers/perf/cxl_pmu.c | 8 +------ > drivers/perf/dwc_pcie_pmu.c | 13 +---------- > drivers/perf/fsl_imx8_ddr_perf.c | 13 +---------- > drivers/perf/fsl_imx9_ddr_perf.c | 13 +---------- > drivers/perf/hisilicon/hisi_pcie_pmu.c | 10 +-------- > drivers/perf/hisilicon/hisi_uncore_pmu.c | 20 +---------------- > drivers/perf/hisilicon/hns3_pmu.c | 9 +------- > drivers/perf/marvell_cn10k_ddr_pmu.c | 15 +------------ > drivers/perf/marvell_cn10k_tad_pmu.c | 6 +---- > drivers/perf/qcom_l2_pmu.c | 21 ++---------------- > drivers/perf/qcom_l3_pmu.c | 21 +----------------- > drivers/perf/riscv_pmu_sbi.c | 2 +- > drivers/perf/thunderx2_pmu.c | 17 +------------- > drivers/perf/xgene_pmu.c | 16 +------------- > include/linux/perf_event.h | 6 ++++- > kernel/events/core.c | 7 +++++- > 47 files changed, 67 insertions(+), 456 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel