From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D64C0044D for ; Mon, 16 Mar 2020 06:35:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 109AD2071C for ; Mon, 16 Mar 2020 06:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZMpOy2gg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="BAvMnM37" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 109AD2071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sPgJcutV/ojvmUMSF/Nmwhsf44eLZLBxb2OhLvzMo6M=; b=ZMpOy2ggNB5gen3bkrRozNuE7 3tHXBYKr+JQLlbRidaKwFgAfIwnUdQy/qReb8LsgMkF7A7TZRrNEO/Rg0YMgW3d0tCVBndQ593Wrg Oc137JbOowm9OLfb3Gz3YmgRNYbyzXJBy8gchnr21Ecw8CA7PsbDHTot5BjS2ESnJOgfabr7s17X7 nBXjtThjl+U9c5DYc5xwQWHPzEB3S5tYRV1RrVbOBYKkYYqQ1sKlZ4ipmrRa6NJ5YZ2qs4B8nP3NR FW6pJrgWaGk3V0BBZiTf/Cdteu8uUas5e+xaj9EycmyVvTgLnU/NAMTZKX0/cK8Jg3xMBxDjji36j zbxmOKG3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDjLF-0002r2-Rb; Mon, 16 Mar 2020 06:35:13 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDjLA-0002gk-TK for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 06:35:12 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584340511; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=OwErceFW23ZNn6eud/cydjRhiFjDFARC1CNzkO9VKPQ=; b=BAvMnM376imdrxh1sDfSRHVbq/s6P0lbelkk5iovW+jcbtp/W7bMHMXI4OieUTWfpk2T636n 096SfjZdHsgzP5E74BiNm0USiJbWc/E/hgrYfW7d2p0MxrZMRajUtxHPZ7tpwmRs0qPiqRWu +ZyZtl24FAba0TQ4UpnjqnXB2+o= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e6f1e09.7f25e78b03b0-smtp-out-n01; Mon, 16 Mar 2020 06:34:49 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3D356C4478C; Mon, 16 Mar 2020 06:34:48 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id F0662C433D2; Mon, 16 Mar 2020 06:34:41 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 16 Mar 2020 14:34:41 +0800 From: Can Guo To: Stanley Chu Subject: Re: [PATCH v5 7/8] scsi: ufs: make HCE polling more compact to improve initialization latency In-Reply-To: <20200316034218.11914-8-stanley.chu@mediatek.com> References: <20200316034218.11914-1-stanley.chu@mediatek.com> <20200316034218.11914-8-stanley.chu@mediatek.com> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200315_233511_312836_D764CBCB X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bvanassche@acm.org, linux-scsi@vger.kernel.org, andy.teng@mediatek.com, jejb@linux.ibm.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, avri.altman@wdc.com, martin.peter~sen@oracle.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, matthias.bgg@gmail.com, asutoshd@codeaurora.org, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-03-16 11:42, Stanley Chu wrote: > Reduce the waiting period between each HCE (Host Controller Enable) > polling from 5 ms to 1 ms. In the same time, increase the maximum > polling > times to make "total polling time" unchanged approximately. > > This change could make HCE initializatoin faster to improve latency of > ufshcd initialization, error recovery, and resume behaviors. > > Signed-off-by: Stanley Chu > Reviewed-by: Avri Altman Reviewed-by: Can Guo > --- > drivers/scsi/ufs/ufshcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index dcbf45d547d8..cd33d07c56cf 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4301,7 +4301,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba) > ufshcd_wait_us(hba->hba_enable_delay_us, 100, true); > > /* wait for the host controller to complete initialization */ > - retry = 10; > + retry = 50; > while (ufshcd_is_hba_active(hba)) { > if (retry) { > retry--; > @@ -4310,7 +4310,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba) > "Controller enable failed\n"); > return -EIO; > } > - ufshcd_wait_us(5000, 100, true); > + ufshcd_wait_us(1000, 100, true); > } > > /* enable UIC related interrupts */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel