From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF40C0044D for ; Mon, 16 Mar 2020 10:29:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90A8F20658 for ; Mon, 16 Mar 2020 10:29:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IswRDSOt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90A8F20658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lfDLnnFM/Gp7LZaP1EaC5nYl5uGjE35TKwinMBktNW8=; b=IswRDSOtOMqyVh WErWoYjTaCWA49p28Tx01NMNh713pNeLDtAMcshfVPkEPqdfpyjZbi9+nB3VtOnlLNQxfDLLVc+kj VVh7f6aMNa8YjHfAVeMFcjLbymHwdd6T9yhXAreZA/BpIm8KEUaasBioob1XFWCfNwXi/y8yYcMsg hgZzY3irp7RAm6q2mX0B3MHoQvduRMprc/PvN/rviX846AbuZfIBrOTaFJhy9t0Qb3Kxw3+SmPYtj KRrc1VicSKCwnWUOsTlAA7u3tyx5GHwdmr+Yw/0dT+Qv5un5ABIA74KaEH0yP7q+y5eXRsLB3RJon 1k7WYKIpm5oPrm9pzutA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDn0E-0006e2-Mc; Mon, 16 Mar 2020 10:29:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDn09-0006d1-36 for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 10:29:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 95D391FB; Mon, 16 Mar 2020 03:29:40 -0700 (PDT) Received: from [10.37.9.38] (unknown [10.37.9.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 379E03F534; Mon, 16 Mar 2020 03:29:36 -0700 (PDT) Subject: Re: [PATCH v3 18/26] arm64: Introduce asm/vdso/processor.h To: Catalin Marinas , Mark Rutland References: <20200313154345.56760-1-vincenzo.frascino@arm.com> <20200313154345.56760-19-vincenzo.frascino@arm.com> <20200315182950.GB32205@mbp> <20200316102214.GA5746@lakrids.cambridge.arm.com> <20200316102621.GC3005@mbp> From: Vincenzo Frascino Message-ID: Date: Mon, 16 Mar 2020 10:30:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200316102621.GC3005@mbp> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200316_032942_669366_1574A197 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Will Deacon , linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/16/20 10:26 AM, Catalin Marinas wrote: > On Mon, Mar 16, 2020 at 10:22:15AM +0000, Mark Rutland wrote: >> On Mon, Mar 16, 2020 at 09:42:32AM +0000, Vincenzo Frascino wrote: >>> On 3/15/20 6:30 PM, Catalin Marinas wrote: >>>> On Fri, Mar 13, 2020 at 03:43:37PM +0000, Vincenzo Frascino wrote: >>>>> --- /dev/null >>>>> +++ b/arch/arm64/include/asm/vdso/processor.h >>>>> @@ -0,0 +1,31 @@ >>>>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>>>> +/* >>>>> + * Copyright (C) 2020 ARM Ltd. >>>>> + */ >>>>> +#ifndef __ASM_VDSO_PROCESSOR_H >>>>> +#define __ASM_VDSO_PROCESSOR_H >>>>> + >>>>> +#ifndef __ASSEMBLY__ >>>>> + >>>>> +#include >>>>> + >>>>> +#ifdef CONFIG_COMPAT >>>>> +#if defined(CONFIG_ARM64_64K_PAGES) && defined(CONFIG_KUSER_HELPERS) >>>>> +/* >>>>> + * With CONFIG_ARM64_64K_PAGES enabled, the last page is occupied >>>>> + * by the compat vectors page. >>>>> + */ >>>>> +#define TASK_SIZE_32 UL(0x100000000) >>>>> +#else >>>>> +#define TASK_SIZE_32 (UL(0x100000000) - PAGE_SIZE) >>>>> +#endif /* CONFIG_ARM64_64K_PAGES */ >>>>> +#endif /* CONFIG_COMPAT */ >>>> >>>> Just curious, what's TASK_SIZE_32 used for in the vDSO code? You don't >>>> seem to move TASK_SIZE. >>>> >>> >>> I tried to fine grain the headers as much as I could in order to avoid >>> unneeded/unwanted inclusions: >>> * TASK_SIZE_32 is used to verify ABI consistency on vdso32 (please refer to >>> arch/arm64/kernel/vdso32/vgettimeofday.c). >>> * TASK_SIZE is not required by the vdso library hence it is not present in >>> these headers. >> >> It would be worth noting the former point in the commit message, since >> it can be surprising. >> >> I also think it's worth keeping the definitions together if that's easy, >> as it makes it easier to navigate the codebase, even if TASK_SIZE isn't >> necessary for the VDSO itself. > > It won't work as TASK_SIZE requires (on arm64) test_thread_flag() which > can't be made available to the vDSO. > Ups, I did not see this :) luckily I agree ;) -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel