From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34D91C48297 for ; Mon, 12 Feb 2024 04:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/blSIdQIk6sLA5FiHCvvPy0YcE7VEF1DZu9/RIWKAr8=; b=PSK3S8Sbim8Z/y jy7Hau8gqyCC8zOEAyrnq8E8Xr0yoTMCiPHe/MuwHJiqm3SopVtrfM/geS91oM1WCNheosODYymba RzOwSWUZNRpsoDZdLg7PToz3vCE4rKa7ThgZXMWvjydBMQSfbsU3dDrkeA3HmKH9Kvn42kGnxSMHH oDMKzjf3kfzCkhwCHcNS0g1Ojs8sHgl6xYz/dTVBWaVBCI9erR6sv9AFJTkqooZLv46zv7JcGrByF lS32lpwgTZ1p0yQxjBBnGvpaMjFKumUKjLUbLPLS3bWkc0859DGcKl4AYmDsV87eqFPh1PGJ5VD/X jgiv4CHUGTCkiiNojJaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZO3j-00000004Jmy-3Fu4; Mon, 12 Feb 2024 04:36:47 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZO3g-00000004JmI-2hXC for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 04:36:46 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 41C4aZph042290; Sun, 11 Feb 2024 22:36:35 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1707712595; bh=dDe2x2/sNsxxovWiqiXQgtSK6CZ2bkfH7mRKphacIVw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=RkROSJQnh61KCNT0f5C5CL8FiFvbIU5XYMyiXUtxqmgenmaHyb4p8OoBkikUwmSNP KKePU1FCmTSgSozuOBINuIV/x7BOCXnlIiJRbdBbLq8FeQ8lQvjJ7YYJbox+coP6LO 9QEe551QcM5EO9nwSYfiro5NQm4m6RNDuS1LUia0= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 41C4aZ44083637 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 11 Feb 2024 22:36:35 -0600 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sun, 11 Feb 2024 22:36:35 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sun, 11 Feb 2024 22:36:35 -0600 Received: from [172.24.20.156] (lt5cd2489kgj.dhcp.ti.com [172.24.20.156]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 41C4aVAh000720; Sun, 11 Feb 2024 22:36:31 -0600 Message-ID: Date: Mon, 12 Feb 2024 10:06:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] clk: keystone: sci-clk: Adding support for non contiguous clocks Content-Language: en-US To: Francesco Dolcini CC: , , , , , , , , , , , References: <20240207091100.4001428-1-u-kumar1@ti.com> <20240211155459.GA4443@francesco-nb> From: "Kumar, Udit" In-Reply-To: <20240211155459.GA4443@francesco-nb> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240211_203644_801601_395576A2 X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/11/2024 9:24 PM, Francesco Dolcini wrote: > On Wed, Feb 07, 2024 at 02:41:00PM +0530, Udit Kumar wrote: >> Most of clocks and their parents are defined in contiguous range, >> But in few cases, there is gap in clock numbers[0]. >> Driver assumes clocks to be in contiguous range, and add their clock >> ids incrementally. >> >> New firmware started returning error while calling get_freq and is_on >> API for non-available clock ids. >> >> In this fix, driver checks and adds only valid clock ids. >> >> Fixes: 3c13933c6033 ("clk: keystone: sci-clk: add support for dynamically probing clocks") >> >> [0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j7200/clocks.html >> Section Clocks for NAVSS0_CPTS_0 Device, >> clock id 12-15 not present. >> >> Signed-off-by: Udit Kumar > no empty lines in between tags and only tags at the end of the commit > message, this [0] reference needs to be before or moved to a `Link:` tag, > whatever works best for you. Thanks will below works ? [0]https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j7200/clocks.html Section Clocks for NAVSS0_CPTS_0 Device, clock id 12-15 not present Fixes: 3c13933c6033 ("clk: keystone: sci-clk: add support for dynamically probing clocks") Udit _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel