[GIT PULL 1/2] SoCFPGA DTS updates for v4.13

[GIT PULL 1/2] SoCFPGA DTS updates for v4.13

[Dinh Nguyen]

Hi Arnd, Kevin, and Olof:

Please pull in these DTS updates for v4.13.

Thanks,
Dinh

The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6:

  Linux 4.12-rc1 (2017-05-13 13:19:49 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git tags/socfpga_dts_for_v4.13

for you to fetch changes up to 000e6f73dcc52d970706010d3bbc74710db4933c:

  ARM: dts: socfpga: set the i2c frequency (2017-05-26 11:19:28 -0500)

----------------------------------------------------------------
SoCFPGA DTS updates for v4.13
- Fix clocks node the EMACs
- VINING board updtes
	- Remove I2C EEPROMs and LED node
	- Add QSPI device
	- Add 2nd ethernet alias
- Add 'clock-frequency' binding for i2c node

----------------------------------------------------------------
Dinh Nguyen (1):
      ARM: dts: socfpga: set the i2c frequency

Marek Vasut (6):
      ARM: socfpga: Increase max number of GPIOs
      ARM: dts: socfpga: Fix the ethernet clock phandle
      ARM: dts: socfpga: Enable QSPI support on VINING FPGA
      ARM: dts: socfpga: Remove I2C EEPROMs from VINING FPGA
      ARM: dts: socfpga: Drop LED node from VINING FPGA
      ARM: dts: socfpga: Add second ethernet alias to VINING FPGA

 arch/arm/Kconfig                                   |   1 +
 arch/arm/boot/dts/socfpga.dtsi                     |   4 +-
 arch/arm/boot/dts/socfpga_arria10_socdk.dtsi       |   2 +-
 arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts  |   2 +-
 arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts      |   2 +-
 arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 101 +++++++++------------
 6 files changed, 47 insertions(+), 65 deletions(-)

[GIT PULL 2/2] SoCFPGA update for v4.13

[Dinh Nguyen]

Hi Arnd, Kevin, and Olof:

Please pull in this SoCFPGA Kconfig update for v4.13.

Thanks,
Dinh


The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6:

  Linux 4.12-rc1 (2017-05-13 13:19:49 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git tags/socfpga_updates_for_v4.13

for you to fetch changes up to 139358be24e526bc8d050e319cdd4e2d1941503e:

  ARM: socfpga: Increase max number of GPIOs (2017-06-21 10:16:02 -0500)

----------------------------------------------------------------
SoCFPGA updates for v4.13
- Increase number of available GPIOs in Kconfig

----------------------------------------------------------------
Marek Vasut (1):
      ARM: socfpga: Increase max number of GPIOs

 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

[GIT PULL 2/2] SoCFPGA update for v4.13

[Arnd Bergmann]

On Wed, Jun 21, 2017 at 5:35 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
> Hi Arnd, Kevin, and Olof:
>
> Please pull in this SoCFPGA Kconfig update for v4.13.

I'd like to defer this one until I hear back from the GPIO maintainers:

With this patch, CONFIG_ARCH_NR_GPIO increases from 1024 to 2048
in the ARM defconfig build. Is this ok in terms of runtime overhead?
If not, are there any alternatives?

        Arnd

> The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6:
>
>   Linux 4.12-rc1 (2017-05-13 13:19:49 -0700)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git tags/socfpga_updates_for_v4.13
>
> for you to fetch changes up to 139358be24e526bc8d050e319cdd4e2d1941503e:
>
>   ARM: socfpga: Increase max number of GPIOs (2017-06-21 10:16:02 -0500)
>
> ----------------------------------------------------------------
> SoCFPGA updates for v4.13
> - Increase number of available GPIOs in Kconfig
>
> ----------------------------------------------------------------
> Marek Vasut (1):
>       ARM: socfpga: Increase max number of GPIOs
>
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

[GIT PULL 2/2] SoCFPGA update for v4.13

[Linus Walleij]

On Fri, Jun 23, 2017 at 2:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wed, Jun 21, 2017 at 5:35 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
>> Hi Arnd, Kevin, and Olof:
>>
>> Please pull in this SoCFPGA Kconfig update for v4.13.
>
> I'd like to defer this one until I hear back from the GPIO maintainers:
>
> With this patch, CONFIG_ARCH_NR_GPIO increases from 1024 to 2048
> in the ARM defconfig build. Is this ok in terms of runtime overhead?

There is no problem with runtime overhead, only with footprint.

The array of sizeof(gpio_desc) increases to double.

struct looks like so:

struct gpio_desc {
        struct gpio_device      *gdev;
        unsigned long           flags;
        const char              *label;
        const char              *name;
};

Looks like 4x32 bits in most cases, so this means a 4*4*1024 =
16 KiB footprint increase.

We have had to allocate this statically because so many playforms still
use the legacy GPIO API.

> If not, are there any alternatives?

Not really, if they have this many GPIOs.

Helping out ridding the kernel of users of the old GPIO global
numberspace ABI is appreciated though.

Yours,
Linus Walleij

[GIT PULL 2/2] SoCFPGA update for v4.13

[Arnd Bergmann]

On Fri, Jun 23, 2017 at 2:28 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Jun 23, 2017 at 2:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Wed, Jun 21, 2017 at 5:35 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
>>> Hi Arnd, Kevin, and Olof:
>>>
>>> Please pull in this SoCFPGA Kconfig update for v4.13.
>>
>> I'd like to defer this one until I hear back from the GPIO maintainers:
>>
>> With this patch, CONFIG_ARCH_NR_GPIO increases from 1024 to 2048
>> in the ARM defconfig build. Is this ok in terms of runtime overhead?
>
> There is no problem with runtime overhead, only with footprint.
>
> The array of sizeof(gpio_desc) increases to double.
>
> struct looks like so:
>
> struct gpio_desc {
>         struct gpio_device      *gdev;
>         unsigned long           flags;
>         const char              *label;
>         const char              *name;
> };
>
> Looks like 4x32 bits in most cases, so this means a 4*4*1024 =
> 16 KiB footprint increase.

Ok.

> We have had to allocate this statically because so many playforms still
> use the legacy GPIO API.
>
>> If not, are there any alternatives?
>
> Not really, if they have this many GPIOs.

Right. I pulled the branch into next/soc now, thanks for the quick reply!

> Helping out ridding the kernel of users of the old GPIO global
> numberspace ABI is appreciated though.

I guess there is no easy way to figure out which drivers are needed on
socfpga and do those first, right?

        Arnd

[GIT PULL 2/2] SoCFPGA update for v4.13

[Linus Walleij]

On Fri, Jun 23, 2017 at 2:38 PM, Arnd Bergmann <arnd@arndb.de> wrote:

>> Helping out ridding the kernel of users of the old GPIO global
>> numberspace ABI is appreciated though.
>
> I guess there is no easy way to figure out which drivers are needed on
> socfpga and do those first, right?

Nah, we have a few hard cases.

The most annoying one is with regulators, those need to grab the
same GPIO line several times and use in parallel. It is a valid case,
so we need a way to get GPIO descriptors non-execlusively for these
so we can deal with it properly.

Then there is a bunch of cases where it's simpler, those are low-hanging
fruit. Like the conversion of backlight on GPIO I sent recently. They just
need being churned out one by one.

Yours,
Linus Walleij

[GIT PULL 1/2] SoCFPGA DTS updates for v4.13

[Arnd Bergmann]

On Wed, Jun 21, 2017 at 5:35 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
> Hi Arnd, Kevin, and Olof:
>
> Please pull in these DTS updates for v4.13.
>
> Thanks,
> Dinh
>
> The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6:
>
>   Linux 4.12-rc1 (2017-05-13 13:19:49 -0700)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git tags/socfpga_dts_for_v4.13
>
> for you to fetch changes up to 000e6f73dcc52d970706010d3bbc74710db4933c:
>
>   ARM: dts: socfpga: set the i2c frequency (2017-05-26 11:19:28 -0500)
>
> ----------------------------------------------------------------
> SoCFPGA DTS updates for v4.13
> - Fix clocks node the EMACs
> - VINING board updtes
>         - Remove I2C EEPROMs and LED node
>         - Add QSPI device
>         - Add 2nd ethernet alias
> - Add 'clock-frequency' binding for i2c node
>
> ----------------------------------------------------------------
> Dinh Nguyen (1):
>       ARM: dts: socfpga: set the i2c frequency
>
> Marek Vasut (6):
>       ARM: socfpga: Increase max number of GPIOs
>       ARM: dts: socfpga: Fix the ethernet clock phandle
>       ARM: dts: socfpga: Enable QSPI support on VINING FPGA
>       ARM: dts: socfpga: Remove I2C EEPROMs from VINING FPGA
>       ARM: dts: socfpga: Drop LED node from VINING FPGA
>       ARM: dts: socfpga: Add second ethernet alias to VINING FPGA

Your description does not explain why the Kconfig patch is included
in this branch and also in the separate pull request. Is there a strong
dependency here, or could you rebase the dts patches on top of
a vanilla 4.12-rc1 and resend?

        Arnd

[GIT PULL 1/2] SoCFPGA DTS updates for v4.13

[Dinh Nguyen]

On 06/23/2017 07:04 AM, Arnd Bergmann wrote:
> On Wed, Jun 21, 2017 at 5:35 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
>> Hi Arnd, Kevin, and Olof:
>>
>> Please pull in these DTS updates for v4.13.
>>
>> Thanks,
>> Dinh
>>
>> The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6:
>>
>>   Linux 4.12-rc1 (2017-05-13 13:19:49 -0700)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git tags/socfpga_dts_for_v4.13
>>
>> for you to fetch changes up to 000e6f73dcc52d970706010d3bbc74710db4933c:
>>
>>   ARM: dts: socfpga: set the i2c frequency (2017-05-26 11:19:28 -0500)
>>
>> ----------------------------------------------------------------
>> SoCFPGA DTS updates for v4.13
>> - Fix clocks node the EMACs
>> - VINING board updtes
>>         - Remove I2C EEPROMs and LED node
>>         - Add QSPI device
>>         - Add 2nd ethernet alias
>> - Add 'clock-frequency' binding for i2c node
>>
>> ----------------------------------------------------------------
>> Dinh Nguyen (1):
>>       ARM: dts: socfpga: set the i2c frequency
>>
>> Marek Vasut (6):
>>       ARM: socfpga: Increase max number of GPIOs
>>       ARM: dts: socfpga: Fix the ethernet clock phandle
>>       ARM: dts: socfpga: Enable QSPI support on VINING FPGA
>>       ARM: dts: socfpga: Remove I2C EEPROMs from VINING FPGA
>>       ARM: dts: socfpga: Drop LED node from VINING FPGA
>>       ARM: dts: socfpga: Add second ethernet alias to VINING FPGA
> 
> Your description does not explain why the Kconfig patch is included
> in this branch and also in the separate pull request. Is there a strong
> dependency here, or could you rebase the dts patches on top of
> a vanilla 4.12-rc1 and resend?
> 

Sorry about that. The Kconfig patch should not have been part of this
series. Let me try again.

Thanks,
Dinh