From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E28AC5478C for ; Fri, 23 Feb 2024 05:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iRZDuyvoXjCRJKqX5Hv91YdCYItlwNtAKCjjKPbdklY=; b=IX+zrdg+0ZYhyY sPOZrUd8XpGglwARYyu08EYz3kV7KSRi+/QPSYksdrOKf/I/qmDYemPjFQwS68pfKAT+rc2RwFhT0 YpxhPqg2UcELmj13Kw8PmRzgeU+C7sYmdl98tZe455gmLA9hG+DeZ6Yxv57srYVzWZfMgt7hNEpon NJp/9cWsf4gXo/xru7CuK54aW2K2XANb43f9lnVkh/0sDgeU+4eY1HH+OTypmJD2NrwTTgRhe/WBz jFlsBOK1OfZcTuOL4XHF9NF73ASN9+4ZjSKHCsBTc5jvBJKp9P+wT3eQVphDqLnNVnmyPsdXwuuQP BCVcX9PABdWK3ulBDUag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdO6o-00000007ynN-0rvR; Fri, 23 Feb 2024 05:28:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdO6k-00000007ymB-1zCt for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 05:28:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A7CE15DB; Thu, 22 Feb 2024 21:28:57 -0800 (PST) Received: from [10.163.46.223] (unknown [10.163.46.223]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 290E43F766; Thu, 22 Feb 2024 21:28:13 -0800 (PST) Message-ID: Date: Fri, 23 Feb 2024 10:58:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V16 1/8] arm64/sysreg: Add BRBE registers and fields Content-Language: en-US To: Mark Brown , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org References: <20240125094119.2542332-1-anshuman.khandual@arm.com> <20240125094119.2542332-2-anshuman.khandual@arm.com> <7fe52cb9-12b9-4b03-8e55-08e59b4bef27@sirena.org.uk> From: Anshuman Khandual In-Reply-To: <7fe52cb9-12b9-4b03-8e55-08e59b4bef27@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_212826_607212_14D8DF19 X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/21/24 19:37, Mark Brown wrote: > On Wed, Feb 21, 2024 at 02:05:24PM +0000, Mark Rutland wrote: >> On Wed, Feb 21, 2024 at 01:59:03PM +0000, Mark Brown wrote: >>> On Wed, Feb 21, 2024 at 01:52:38PM +0000, Mark Rutland wrote: > >>> It's a good point about the sorting, though the file is currently mostly >>> sorted by encoding rather than alphanumerically (similarly to how >>> sysreg.h was done). > >> Sure, we're inconsistent. I'd just prefer that there's *some* local ordering >> here, as the patch is neither ordered as above nor by encoding: > > I agree, I'm just saying that if we're going to fix the ordering it'd > probably be better to go along with what the rest of the file is doing. Sure, will change the registers order as has been suggested earlier i.e alphanumerically instead. Because ordering registers with encoding will push BRBCR_EL2/12 after all other BRBE registers, including BRBIDR0_EL1. After the change BRBCR_EL1 BRBCR_EL12 BRBCR_EL2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel