From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03413C54E67 for ; Fri, 15 Mar 2024 20:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QX4gxVmhiCPCVpkY+AFghzYzpNrdsBYO6JrpKou7UpQ=; b=RCdJvTb4dFudFG 4J59WTeJb7oyYVnwtVAscqnLCZiffG7f6Z1DQA9xhzoTfcfRynqXZd9JffAHEvWg/wC3Ysrh/Nd3h U+iNSyUG9BVKyFocd6lk1WMX9OVGmm8Ro8uCuwHRAn/Eg956s1B6uYooE4yAVn9tkBO5/sjipt4rC 6oRwvXCcrER0+Edm2bL9rHHRgMonHNWX/PU+A5dH255VfmobkH8aHVg3RQhw65c4wm1vAlyNJx7jO S6Uqg5qn7SLfiCVNGyAozrcnXPBOqnetI/816O2eLy95qaacLZ9+O5GgeGf4MKwJke7Z9mCr8Mjlm 6mSzIBRcGuqwK8+ArVAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlE2W-00000001Pl2-0sl0; Fri, 15 Mar 2024 20:20:28 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlE2Q-00000001Pjd-0SIn for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2024 20:20:26 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-513173e8191so3349835e87.1 for ; Fri, 15 Mar 2024 13:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710534019; x=1711138819; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nFLXmRhGh05ZQ+tNAE5GDIqilWlaMO+4VWUU/gtzhg8=; b=wAB5JvokiWw59I2F/hxe7FbC43+6zkqRCOqfHnGGKN/Q6W4Ky0T0fiv129AkcJXxpF hw+jYZ0pvQntQarHQTS4+W7Ae7fkuftq0Ci5Ph5Q4UnRCBWdeNK9PaEJ8tLpjAZk2F+S uXaSaJ7VDdwyi5VPJyrYAW7jBBff9lSMGMcgumfiEMY5BIC+o7WxGQSfZuMUWDN1dAtg mgzD3n9cvIOz/4osqKGajQOkCa9Tkng9r5/my6epPBbLZ7kPgnCLpYxILZuFVkFiyIyZ fAeffDRtPJhj29tVMYp/QtQmgX8WhoPNI3pP3hr1smX621hUnCxJYzqD1tkqYnpLchE8 u3PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710534019; x=1711138819; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nFLXmRhGh05ZQ+tNAE5GDIqilWlaMO+4VWUU/gtzhg8=; b=vqSjDnSnGlaw85+Loj8aEOq1uhETA1M5SLGJ6TTO5vcSp+ydVysBEpb8oTsSUejVRK i3VA0Xr9hFY431ksmfgtFJFBEcr69lc/Z2fvJZ5NAKMF9S2hABIUTTn7kqGqL9nd5QO/ tvMGO8AAdL6gh5U2F46Cm7gFlQes/ZWofTykB4F/HwIxdjOGL1oaGjTE48Sw6MfJHa7S HJy6QwVoWc+ifMhOFJEZk3MBJYEzgQB3vcrAwFfRgErToKMj/sXkncPaR6MoCZpEavrE 1IRSrfsCBmKl9RquVxBkNuGaf1+LY0RvOElVx1N4AzxwbQfGdcxBmWxcSSwIF88c6alq YpUA== X-Forwarded-Encrypted: i=1; AJvYcCXGtMfX/+b+96ZXvNdTN4MXILZzNbzLrgFJOKVO/ofXSHLSAkGqZZQ3jMqJBEVZilaJtPrNsWhzpsKG0zpTVCJj6EVRDel783P8nv35QZ/MYODr/jk= X-Gm-Message-State: AOJu0YzZJHCOVcqEJUjGAZ3FYkZyrnD6PHT8viDDkAGfWoQkZILpMd3a zejiXM9DPWYKqj57IYqWJuPCqWc2JZFY2vTbT1BygEpOzzoJSY66ReiqoE93fwo= X-Google-Smtp-Source: AGHT+IF4vTBppgdKLxPs0gyXIFUHd6EcJY0uvVQJV5qIJs0T7dA0+OeqNjD+A2cte5EpHKfHfRAhuQ== X-Received: by 2002:a05:6512:2815:b0:513:a39e:ae45 with SMTP id cf21-20020a056512281500b00513a39eae45mr5383892lfb.62.1710534019273; Fri, 15 Mar 2024 13:20:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id u8-20020a5d4688000000b0033e3c4e600asm3953082wrq.7.2024.03.15.13.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 13:20:18 -0700 (PDT) Message-ID: Date: Fri, 15 Mar 2024 21:20:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/8] dts: ti: k3-am625-beagleplay: Add mikroBUS Content-Language: en-US To: Ayush Singh , linux-kernel@vger.kernel.org Cc: jkridner@beagleboard.org, robertcnelson@beagleboard.org, Vaishnav M A , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Jiri Slaby , Johan Hovold , Alex Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, greybus-dev@lists.linaro.org References: <20240315184908.500352-1-ayushdevel1325@gmail.com> <20240315184908.500352-9-ayushdevel1325@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240315184908.500352-9-ayushdevel1325@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_132022_212794_8DB4B74A X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/03/2024 19:49, Ayush Singh wrote: > Add mikroBUS connector support for Beagleplay. > > Signed-off-by: Ayush Singh > --- > .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 76 +++++++++++++++++-- > 1 file changed, 68 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > index a34e0df2ab86..886308f99d1a 100644 > --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > @@ -29,6 +29,7 @@ aliases { > i2c3 = &main_i2c3; > i2c4 = &wkup_i2c0; > i2c5 = &mcu_i2c0; > + mikrobus0 = &mikrobus0; > mmc0 = &sdhci0; > mmc1 = &sdhci1; > mmc2 = &sdhci2; > @@ -230,6 +231,33 @@ simple-audio-card,codec { > }; > }; > > + mikrobus0: linux-mikrobus { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation mikrobus { > + compatible = "mikrobus-connector"; > + pinctrl-names = "default", "pwm_default", "pwm_gpio", > + "uart_default", "uart_gpio", "i2c_default", > + "i2c_gpio", "spi_default", "spi_gpio"; > + pinctrl-0 = <&mikrobus_gpio_pins_default>; > + pinctrl-1 = <&mikrobus_pwm_pins_default>; > + pinctrl-2 = <&mikrobus_pwm_pins_gpio>; > + pinctrl-3 = <&mikrobus_uart_pins_default>; > + pinctrl-4 = <&mikrobus_uart_pins_gpio>; > + pinctrl-5 = <&mikrobus_i2c_pins_default>; > + pinctrl-6 = <&mikrobus_i2c_pins_gpio>; > + pinctrl-7 = <&mikrobus_spi_pins_default>; > + pinctrl-8 = <&mikrobus_spi_pins_gpio>; > + i2c-adapter = <&main_i2c3>; > + spi-controller = <&main_spi2>; > + spi-cs = <0 1>; > + uart = <&main_uart5>; > + pwms = <&ecap2 0 500000 0>; > + mikrobus-gpios = > + <&main_gpio1 11 GPIO_ACTIVE_HIGH>, <&main_gpio1 9 GPIO_ACTIVE_HIGH>, Join with previous line. > + <&main_gpio1 24 GPIO_ACTIVE_HIGH>, <&main_gpio1 25 GPIO_ACTIVE_HIGH>, Fix indentation. See DTS coding style. > + <&main_gpio1 22 GPIO_ACTIVE_HIGH>, <&main_gpio1 23 GPIO_ACTIVE_HIGH>, > + <&main_gpio1 7 GPIO_ACTIVE_HIGH>, <&main_gpio1 8 GPIO_ACTIVE_HIGH>, > + <&main_gpio1 14 GPIO_ACTIVE_HIGH>, <&main_gpio1 13 GPIO_ACTIVE_HIGH>, > + <&main_gpio1 12 GPIO_ACTIVE_HIGH>, <&main_gpio1 10 GPIO_ACTIVE_HIGH>; > + }; > }; > > > &main_spi2 { > - pinctrl-names = "default"; > - pinctrl-0 = <&mikrobus_spi_pins_default>; > status = "okay"; > }; > > @@ -875,9 +932,8 @@ &main_uart1 { > }; > > &main_uart5 { > - pinctrl-names = "default"; > - pinctrl-0 = <&mikrobus_uart_pins_default>; > status = "okay"; > + force-empty-serdev-controller; NAK. Don't add undocumented properties. That's a clear no go. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel