linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vviswana@codeaurora.org (Vijay Viswanath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS
Date: Tue, 19 Sep 2017 09:33:21 +0530	[thread overview]
Message-ID: <b2ea12b5-f502-097f-c9cf-aa9e7e6e18be@codeaurora.org> (raw)
In-Reply-To: <f10addc2-5d67-3d0e-fb61-50d42f96125e@intel.com>



On 9/14/2017 12:04 PM, Adrian Hunter wrote:
> On 30/08/17 15:51, Vijay Viswanath wrote:
>> Enable CONFIG_MMC_SDHCI_IO_ACCESSORS so that SDHC controller specific
>> register read and write APIs, if registered, can be used.
> 
> Missing signed-off
> 
> Why don't you put this patch earlier in the patch set and then you don't
> need all the ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS ?
> 

This will involve merging the current patches 3 & 4 into one (Some 
functions defined under ifdef in patch 3 are used only in patch 4). Will 
that be fine ?

>> ---
>>   drivers/mmc/host/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index 2db84dd..64a9298 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -420,6 +420,7 @@ config MMC_SDHCI_MSM
>>   	tristate "Qualcomm SDHCI Controller Support"
>>   	depends on ARCH_QCOM || (ARM && COMPILE_TEST)
>>   	depends on MMC_SDHCI_PLTFM
>> +	select CONFIG_MMC_SDHCI_IO_ACCESSORS
> 
> CONFIG_MMC_SDHCI_IO_ACCESSORS -> MMC_SDHCI_IO_ACCESSORS
> 
>>   	help
>>   	  This selects the Secure Digital Host Controller Interface (SDHCI)
>>   	  support present in Qualcomm SOCs. The controller supports
>>
> 

  reply	other threads:[~2017-09-19  4:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 12:51 [PATCH v1 0/5] mmc: sdhci-msm: Corrections to implementation of power irq Vijay Viswanath
2017-08-30 12:51 ` [PATCH v1 1/5] mmc: sdhci-msm: fix issue with " Vijay Viswanath
2017-09-14  6:20   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 2/5] mmc: sdhci-msm: Fix HW issue with power IRQ handling during reset Vijay Viswanath
2017-09-14  6:20   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 3/5] mmc: sdhci-msm: Add support to wait for power irq Vijay Viswanath
2017-09-14  6:34   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 4/5] mmc: sdhci-msm: Add ops to do sdhc register write Vijay Viswanath
2017-09-14  6:34   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Vijay Viswanath
2017-09-14  6:34   ` Adrian Hunter
2017-09-19  4:03     ` Vijay Viswanath [this message]
2017-09-19  5:44       ` Adrian Hunter
2017-09-12  9:27 ` [PATCH v1 0/5] mmc: sdhci-msm: Corrections to implementation of power irq Vijay Viswanath
2017-09-12 10:41   ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2ea12b5-f502-097f-c9cf-aa9e7e6e18be@codeaurora.org \
    --to=vviswana@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).