From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61809C2BD09 for ; Thu, 27 Jun 2024 10:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yms0dvcM+cOFXF/b3rgL4MfeUvo48xGxAXWzQPcm+CE=; b=HCjGjKL8oLZ75qTyS1bOiQQgoI CJobKwTQdTa3kQ/4RBs9mynb1QwRc9I/nI3rjGtwQv7pCHhAxDeAy02nYUPc12AFG/764Tlj3sVVU 7ob4AkQCXunahajQW3OtkfFhCD/tUl+Owe2anBGGYw795p7ajlKxzPsqjXGdmPw6JuDEm54JjzmNh xhscvdMbggQydYDE8ZCwjVX+tPihs0yTOqsaTjpVvidt/KH9oxoyNbQM85/46LcSABF3Zeph/4vyt kdzA49kZ+e6X+em/TUVpQktVqhL0FK2YfQmfxAOdfyYP7jH1o3xW4Z62LAJB5DpFk4qgefPqLgR18 wp/GkbIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmED-00000009uso-0v31; Thu, 27 Jun 2024 10:19:45 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmE6-00000009usD-33js for linux-arm-kernel@bombadil.infradead.org; Thu, 27 Jun 2024 10:19:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Transfer-Encoding :Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=yms0dvcM+cOFXF/b3rgL4MfeUvo48xGxAXWzQPcm+CE=; b=G7ysLJTVxEb33e4K2KITX3j8pk enT6M3ReL9Z8Fe18cETJd44EJG7eNh++nREqOd67xuTt8gCTjngYfYC6c9MBWJZrDqO14O216phpl 0BVvLuhv/WcVJ2RC3py/41GnneEVqX09OFsJ1S5jz9zchXDIDw5iMQMkp3juGJ2ty9ZNmnTkVifUX 0/9kLiTSnv7m2AzbCjKyuVPchJPIMGJvxHEO0gTEABEvLYGXbZeZdFNhmOdMkvXCBVyVYV5PZWufn VBX7wnTvaN/An6hO0MqVwAhqdG7aaIoNBpHbXw3ooOH6YLtJ4UFuHuwlZo7gXpqfiFw9lpdb5Ubc3 gTvS5GjA==; Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMlO7-00000008nll-3omf for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 09:25:58 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-42562fde108so7949375e9.0 for ; Thu, 27 Jun 2024 02:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719480354; x=1720085154; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=yms0dvcM+cOFXF/b3rgL4MfeUvo48xGxAXWzQPcm+CE=; b=eafV8f63AF5/O/Ru7pSUmarIheHyaY/NDimgBmDC4IV7/ORpiF0CczKw0LFWkrJZG/ untsBuDjbuTKQelTbT+UpFLUEKJ0+gn98IM++cl6n6zaPmpowmq85Eu5zxCJKMLFzz4i iswUpbozduT6wUlnSe9Ykh7wNOm5kFkVEXV+8C8q1SEzi7ODlef+XtYvDKQVoE0JbA8H v2HghR400HAnfgj9xZAT+Pw5k3atrtCl6iyGkzcEIJINGIT6Mp/1ZbT8dCChQiLV0RFG 6YiTd61lSc40yJNn/LGTVdyHbbhOdOz7WhiD/pRLRjEgHMT4/uxos7W0n5qq/3vujWEM Nyug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719480354; x=1720085154; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yms0dvcM+cOFXF/b3rgL4MfeUvo48xGxAXWzQPcm+CE=; b=XM4lb4i90HJEtqExA2hf4YQGjEZtH5iiI7DS4rjCnqyRQ1TqD6mjCunWGMGvlFEKOP slYcpxVIQQZ5fs05iCRbtn00ezwBmFPB/4tECxAapFUmqo/kgEBcQvYZQdCeTHHTsNnt W8PXcDeExuFEuwLXHiReZtKX+lOs0GqRd9/fDXkvJXpsPvGg6zFL42EmYSNLKG0x1iuL qDXrGox2BA8ptyeNtM8ul1Oafpgd06JQgOFuEIVm/e0QyAo+Mklm33sd0S4gkEp5Pv2s LPPf0PqJ+B7Fl+yNgL6RFwAqiO4mOcJjAB9CBJcybVwazxG+k9v1dy0L9yupmxw/go46 2Q+g== X-Forwarded-Encrypted: i=1; AJvYcCVCX+4/KCEKCSlxoKWDd5AwZrBoTNdElCRBaqAMQ61ijzPvfY5VWNNyG684zWRrzcPZO6TVmdimFlP/I7BcZnoLSVllT92BF19umA0ySg4qt/JpNqU= X-Gm-Message-State: AOJu0Yyx8kJAJcMRgo/yAqZ/JJ5EYR4BAza9SJotaGt7MmOSALej21nW 7fpXoBz5rUw+CsX6gyyAMYB3hEoeWiNPiHlS3+SXy1yS15TDAq1g X-Google-Smtp-Source: AGHT+IG3qQJOlsPSb9mrwiN19TVVQzBmbUDyKeJiSJmR4CM0XqDUNRuOzxKANhLRTTCQvEJ+h+D2cg== X-Received: by 2002:a05:6000:184f:b0:366:eb61:b47 with SMTP id ffacd0b85a97d-366eb610bafmr11187920f8f.8.1719480353838; Thu, 27 Jun 2024 02:25:53 -0700 (PDT) Received: from ?IPv6:2001:8a0:e622:f700:9537:8d85:b9f7:78bb? ([2001:8a0:e622:f700:9537:8d85:b9f7:78bb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367436999f6sm1225086f8f.72.2024.06.27.02.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 02:25:53 -0700 (PDT) Message-ID: Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: add TPM device From: Vitor Soares To: Francesco Dolcini , Shawn Guo Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 27 Jun 2024 10:25:52 +0100 In-Reply-To: References: <20240613134150.318755-1-ivitro@gmail.com> <20240617071842.GA4832@francesco-nb> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_102556_387695_37A78661 X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-06-27 at 09:10 +0200, Francesco Dolcini wrote: > On Thu, Jun 27, 2024 at 02:57:48PM +0800, Shawn Guo wrote: > > On Mon, Jun 17, 2024 at 09:18:42AM +0200, Francesco Dolcini wrote: > > > Hello Shawn, > > >=20 > > > On Mon, Jun 17, 2024 at 10:33:50AM +0800, Shawn Guo wrote: > > > > On Thu, Jun 13, 2024 at 02:41:50PM +0100, Vitor Soares wrote: > > > > > From: Vitor Soares > > > > >=20 > > > > > Add TPM device found on Verdin iMX8M Mini PID4 0090 variant. > > > > >=20 > > > > > Signed-off-by: Vitor Soares > > > > > --- > > > > > =C2=A0arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 16 +++++= ++++++---- > > > > > - > > > > > =C2=A01 file changed, 11 insertions(+), 5 deletions(-) > > > > >=20 > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > index 4768b05fd765..c9ae5f0bb526 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > @@ -227,15 +227,16 @@ &ecspi2 { > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-0 =3D <&p= inctrl_ecspi2>; > > > > > =C2=A0}; > > > > > =C2=A0 > > > > > -/* Verdin CAN_1 (On-module) */ > > > > > +/* On-module SPI */ > > > > > =C2=A0&ecspi3 { > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#address-cells = =3D <1>; > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#size-cells =3D <= 0>; > > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cs-gpios =3D <&gpio5 2= 5 GPIO_ACTIVE_LOW>; > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cs-gpios =3D <&gpio5 2= 5 GPIO_ACTIVE_LOW>, <&gpio4 19 > > > > > GPIO_ACTIVE_LOW>; > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-names =3D= "default"; > > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-0 =3D <&pinctr= l_ecspi3>; > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-0 =3D <&pinctr= l_ecspi3>, <&pinctrl_pmic_tpm_ena>; > > > >=20 > > > > Would it make more sense to have tpm pinctrl in node tpm@1 below? > > > It's the pinctrl of the SPI Chip Select pin, not something about the > > > TPM, I think it's correct to have it into the ecspi node. > >=20 > > The name pinctrl_pmic_tpm_ena seems confusing then. >=20 > I agree (this is coming from the schematics net name, let's blame the HW > folks). >=20 > With that said, let's rename this to `pinctrl_tpm_spi_cs`. Vitor? I will prepare a v2 with this small change. Vitor Soares >=20 > Francesco >=20