From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 390E0C531DC for ; Fri, 23 Aug 2024 05:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7E/u42pJNxk5be6E2/2XU4a6u/o0sOR6tbh89n5oThc=; b=FQDsQWJgTSR/J8gQ2DDMbkeN70 TqCwKsaOnWBWXyWbJ9dj3CGlP+Ft1VNH/HPMlHBBn/sn7vEInsX+80UAU5WbfuWN6AIR5XrAWwQAr Hk733Uya+eSysTDr/0F1IQsxR3DKvlPO6bfhFJUC2aqBriH9zC43uMm2yY3U8Bs6cRxOl1g+8q5qd TEB6die3Wu+v9wyjFq+OtvJ7XXlf3DjnUTjVlF+94r+IJV1oxENhJWUkUq6TFukDcGUt5eACHvhgi APNKfy6tAZahZnKd2+ZDmKUvEXbt5nnuGGWoWoFi2TYjQo2f29xlkh2QRAY+qbi+E9kto1bzAo5Cl aSs2RVHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shMjO-0000000FI2M-05yF; Fri, 23 Aug 2024 05:21:02 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shMid-0000000FHv8-05ZP; Fri, 23 Aug 2024 05:20:16 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1724390413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7E/u42pJNxk5be6E2/2XU4a6u/o0sOR6tbh89n5oThc=; b=wMIYuRmPDknAgxp71sNt2tRfbbIfw5LBNaq29wmvGT78kd1A1LnSSq5jmrk27/Ms+/sq0R yP9t/3zvRkz9nM8ShzOpH5snCf7SxNMdZaWuSXUgBl7EhRezXkK+PnwQy0SP2K1Njc1DmR Rmcr36ZQ5puZMngpP6VruF+cxC/jOAgHlClCoxw44v1wmkieJf37svzltY3Mg3XxjhsVQ6 /Yr1Un20ze7AAgKR9v+4gnt1qrxfUhcm1/aMpWtsIyAzV3joVmzqwD32vCI7U9urtR3rz6 XwCIPAXMFoUkmmJ/UX13BH8HO5BT04rYD6OqsGQ9rN25wfEjWoDJTIKWteoexg== Date: Fri, 23 Aug 2024 07:20:13 +0200 From: Dragan Simic To: Detlev Casanova Cc: linux-kernel@vger.kernel.org, Rob Herring , Conor Dooley , Heiko Stuebner , Linus Walleij , Sebastian Reichel , Shresth Prasad , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski , kernel@collabora.com, Sascha Hauer , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/4] grf: rk3576: Add default GRF values In-Reply-To: <20240822195706.920567-3-detlev.casanova@collabora.com> References: <20240822195706.920567-1-detlev.casanova@collabora.com> <20240822195706.920567-3-detlev.casanova@collabora.com> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_222015_529179_B0CDB613 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Detlev, On 2024-08-22 21:53, Detlev Casanova wrote: > Set SW controlled i3c weak pull up and disable JTAG function on SDMMC > IO. > > The i3c weak pull up is activated to let all gpio banks be controlled > by the pinctrl driver. > > Disabling the JTAG function lets the SDMMC core use its full IO width. > > Signed-off-by: Detlev Casanova Thanks for the patch. I had a rather detailed look at the patch, while focusing on having no regressions introduced, and I found none. So, please feel free to include: Acked-by: Dragan Simic > --- > drivers/soc/rockchip/grf.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/rockchip/grf.c b/drivers/soc/rockchip/grf.c > index 5fd62046b28a..4607fc0779e7 100644 > --- a/drivers/soc/rockchip/grf.c > +++ b/drivers/soc/rockchip/grf.c > @@ -121,6 +121,29 @@ static const struct rockchip_grf_info > rk3566_pipegrf __initconst = { > .num_values = ARRAY_SIZE(rk3566_defaults), > }; > > +#define RK3576_SYSGRF_SOC_CON1 0x0004 > + > +static const struct rockchip_grf_value rk3576_defaults_sys_grf[] > __initconst = { > + { "i3c0 weakpull", RK3576_SYSGRF_SOC_CON1, HIWORD_UPDATE(3, 3, 6) }, > + { "i3c1 weakpull", RK3576_SYSGRF_SOC_CON1, HIWORD_UPDATE(3, 3, 8) }, > +}; > + > +static const struct rockchip_grf_info rk3576_sysgrf __initconst = { > + .values = rk3576_defaults_sys_grf, > + .num_values = ARRAY_SIZE(rk3576_defaults_sys_grf), > +}; > + > +#define RK3576_IOCGRF_MISC_CON 0x04F0 > + > +static const struct rockchip_grf_value rk3576_defaults_ioc_grf[] > __initconst = { > + { "jtag switching", RK3576_IOCGRF_MISC_CON, HIWORD_UPDATE(0, 1, 1) }, > +}; > + > +static const struct rockchip_grf_info rk3576_iocgrf __initconst = { > + .values = rk3576_defaults_ioc_grf, > + .num_values = ARRAY_SIZE(rk3576_defaults_ioc_grf), > +}; > + > #define RK3588_GRF_SOC_CON6 0x0318 > > static const struct rockchip_grf_value rk3588_defaults[] __initconst = > { > @@ -132,7 +155,6 @@ static const struct rockchip_grf_info > rk3588_sysgrf __initconst = { > .num_values = ARRAY_SIZE(rk3588_defaults), > }; > > - > static const struct of_device_id rockchip_grf_dt_match[] __initconst = > { > { > .compatible = "rockchip,rk3036-grf", > @@ -158,6 +180,12 @@ static const struct of_device_id > rockchip_grf_dt_match[] __initconst = { > }, { > .compatible = "rockchip,rk3566-pipe-grf", > .data = (void *)&rk3566_pipegrf, > + }, { > + .compatible = "rockchip,rk3576-sys-grf", > + .data = (void *)&rk3576_sysgrf, > + }, { > + .compatible = "rockchip,rk3576-ioc-grf", > + .data = (void *)&rk3576_iocgrf, > }, { > .compatible = "rockchip,rk3588-sys-grf", > .data = (void *)&rk3588_sysgrf,