From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7278C636D3 for ; Fri, 3 Feb 2023 03:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=La2lCV0k3Ic9zwp+Yj8QuxrihZYvwhaJOJbBeWFHSME=; b=X9QzIOTNJZzCvF 6JXJZPnfrrhJAnaDVraqjeB6jUJQZpcZpY5tY8WmENCKJOLEGP2UUjO8AxvGnQqNL+aZkrVXbeFrN 01vyBnTcE1CQ/hyyGV5bV6hqvIpHwQsi+6CnhWBErtnQTnRuK9DYkOPtnuoHMCXCcIO2Ko1pt2Rig JHZ0z1R1/s2+3VKs4TxQtrnwtRAMsDgKfkyk1Q3LmXmRAj5GAoYcbXYPA0ao0G65o274L05hnUrUX Ip01FkYCQDEnUakm1Yk02BxEzuMO7uiPgPTaVllBCCnW/pxrvXDpZUxN+EhZ2P6+Qb2t39rS4L/Up ySPpYDwzn1ZWKGUlqvhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmIg-0007ag-NP; Fri, 03 Feb 2023 02:59:42 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmIc-0007ZH-UZ for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 02:59:40 +0000 Received: by mail-ej1-x62d.google.com with SMTP id dr8so11665042ejc.12 for ; Thu, 02 Feb 2023 18:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fBZRXwv5EC0srRDal6IgJ95Rn667hJg55SC5Acu1s8s=; b=Yq/hwfpiFs1LQ9ywcVHMT3+I5DFDrksNUyywxOYdfJQFNBKRm85XB+wSfI6IOJxqpl tQyuwZvAJFIgQsMZGu12Db659GsI3PZAowSdPSLA1apZyexMInR0cl8p3AElDouluLDv WWZWXTyQ/TSCDUgd5GVpNvRjqnMzyzJS20wOVWXLESH1OKgpoTVLTuoBZY4gjfMPF8Rq EmzTFrRKxB+3Wvm/VKTDFeCEJzG2VSxlT/knzXQY4VDSuWEHcgWwefsxYjGxEuKoko+A 6pcdjNnrsXaxocaUDn1AO+nUVJ818geexhhpJGXkJVRkb6wNSzIqN46k9D9NNNGR7Etx V/gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fBZRXwv5EC0srRDal6IgJ95Rn667hJg55SC5Acu1s8s=; b=jN1C8NU7GoR6xRtEjdcY55ZJgM1t86D31p1zdiCMkAbjdjjoR252rFUQ8RGN5wFzGW MRDm7tOw3v+eP1yqDa8f5Y9XNgWpLscwxOeKuxRXA/2hHA9V6GZz8E0s/XB/wEAY6cAE kTMtueYSH7M3IS5QeB77g8WbZkKQku0uX37VBIJWePelZv7FSbE1bohW/g/3+6WjjXng UFp8G0xkCoYcEyW/VaAIWDBtzj8bmi/aLyRZTGKuJQfvD6XiWXLJUhVwlU0im6Jjyr2s qq9fNt2DpU+Bo15k6GysykGOOFhZUPj5KFqm7V19kdX5HqKgvxzxyiblN/YNz7VQlSxt V2LQ== X-Gm-Message-State: AO0yUKUZ66LDS0Ad0RpbAJIJZc1drhdKl090ADs96qBOotErQveXdHIh 9GCADOJP8BrvFTStrxGtHGj/Rw== X-Google-Smtp-Source: AK7set+bT60wmwsIelvVGF4y/w5GhrY88VkA7jjz6d++JvsPPx3FkeutGTgt+6+xKe0aMwWaoXKraQ== X-Received: by 2002:a17:906:6d14:b0:88d:5081:e9f8 with SMTP id m20-20020a1709066d1400b0088d5081e9f8mr8648879ejr.15.1675393177375; Thu, 02 Feb 2023 18:59:37 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id s19-20020a1709067b9300b008878909859bsm664237ejo.152.2023.02.02.18.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 18:59:37 -0800 (PST) Message-ID: Date: Fri, 3 Feb 2023 03:59:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 22/23] interconnect: drop unused icc_get() interface Content-Language: en-US To: Johan Hovold , Georgi Djakov Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Sylwester Nawrocki , =?UTF-8?B?QXJ0dXIgxZp3aWdvxYQ=?= , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230201101559.15529-1-johan+linaro@kernel.org> <20230201101559.15529-23-johan+linaro@kernel.org> From: Konrad Dybcio In-Reply-To: <20230201101559.15529-23-johan+linaro@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_185939_047874_0C5E29FC X-CRM114-Status: GOOD ( 23.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1.02.2023 11:15, Johan Hovold wrote: > The icc_get() interface can be used to lookup an interconnect path based > on global node ids. There has never been any users of this interface and > all lookups are currently done from the devicetree. > > Remove the unused icc_get() interface. > > Signed-off-by: Johan Hovold > --- Reviewed-by: Konrad Dybcio Konrad > drivers/interconnect/core.c | 52 ++---------------------------------- > include/linux/interconnect.h | 8 ------ > 2 files changed, 2 insertions(+), 58 deletions(-) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index b8917823fd95..8cca5e9a9d5f 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -588,7 +588,7 @@ EXPORT_SYMBOL_GPL(icc_set_tag); > > /** > * icc_get_name() - Get name of the icc path > - * @path: reference to the path returned by icc_get() > + * @path: interconnect path > * > * This function is used by an interconnect consumer to get the name of the icc > * path. > @@ -606,7 +606,7 @@ EXPORT_SYMBOL_GPL(icc_get_name); > > /** > * icc_set_bw() - set bandwidth constraints on an interconnect path > - * @path: reference to the path returned by icc_get() > + * @path: interconnect path > * @avg_bw: average bandwidth in kilobytes per second > * @peak_bw: peak bandwidth in kilobytes per second > * > @@ -705,54 +705,6 @@ int icc_disable(struct icc_path *path) > } > EXPORT_SYMBOL_GPL(icc_disable); > > -/** > - * icc_get() - return a handle for path between two endpoints > - * @dev: the device requesting the path > - * @src_id: source device port id > - * @dst_id: destination device port id > - * > - * This function will search for a path between two endpoints and return an > - * icc_path handle on success. Use icc_put() to release > - * constraints when they are not needed anymore. > - * If the interconnect API is disabled, NULL is returned and the consumer > - * drivers will still build. Drivers are free to handle this specifically, > - * but they don't have to. > - * > - * Return: icc_path pointer on success, ERR_PTR() on error or NULL if the > - * interconnect API is disabled. > - */ > -struct icc_path *icc_get(struct device *dev, const int src_id, const int dst_id) > -{ > - struct icc_node *src, *dst; > - struct icc_path *path = ERR_PTR(-EPROBE_DEFER); > - > - mutex_lock(&icc_lock); > - > - src = node_find(src_id); > - if (!src) > - goto out; > - > - dst = node_find(dst_id); > - if (!dst) > - goto out; > - > - path = path_find(dev, src, dst); > - if (IS_ERR(path)) { > - dev_err(dev, "%s: invalid path=%ld\n", __func__, PTR_ERR(path)); > - goto out; > - } > - > - path->name = kasprintf(GFP_KERNEL, "%s-%s", src->name, dst->name); > - if (!path->name) { > - kfree(path); > - path = ERR_PTR(-ENOMEM); > - } > -out: > - mutex_unlock(&icc_lock); > - return path; > -} > -EXPORT_SYMBOL_GPL(icc_get); > - > /** > * icc_put() - release the reference to the icc_path > * @path: interconnect path > diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h > index 2b0e784ba771..97ac253df62c 100644 > --- a/include/linux/interconnect.h > +++ b/include/linux/interconnect.h > @@ -40,8 +40,6 @@ struct icc_bulk_data { > > #if IS_ENABLED(CONFIG_INTERCONNECT) > > -struct icc_path *icc_get(struct device *dev, const int src_id, > - const int dst_id); > struct icc_path *of_icc_get(struct device *dev, const char *name); > struct icc_path *devm_of_icc_get(struct device *dev, const char *name); > int devm_of_icc_bulk_get(struct device *dev, int num_paths, struct icc_bulk_data *paths); > @@ -61,12 +59,6 @@ void icc_bulk_disable(int num_paths, const struct icc_bulk_data *paths); > > #else > > -static inline struct icc_path *icc_get(struct device *dev, const int src_id, > - const int dst_id) > -{ > - return NULL; > -} > - > static inline struct icc_path *of_icc_get(struct device *dev, > const char *name) > { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel