From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33DEFC54F54 for ; Fri, 31 Jul 2026 08:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M9R5VUTamSu5US7RrHsusWV6mqBYlLVaGv5zkONCkbg=; b=p4sI0QFpE8SxoIB5O8AwotrNU+ 8KxAdxOtOyx9s7aJWIFv9cXop6SkRkoWlQ7ZJxo8kkvu6grT8SDzFPYey3L96UIBx0PDdDv+xY/tp XCW3N1eDhabuairC2qkSAhHSQHGMhbXfMG/KFxlABIP0tumqyeJX1sNQNebOHCRhVQjSCmVIDVdWe GZQvzZ9pLtRzKrba5I+NTffxx4l+n6fGHVZxcrvo/GRE8vc93bo3rVMwLhjeiGqXhnZDyu/Di0Cur i5RsBM8y+7rV+10bT65JBJhSS/XgKi1brFkljllBjZTIuSAYvGEtJEHK7U0J2EKujDjFHGCMIcfgG 14On6KPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpiQ7-0000000C2hS-03EP; Fri, 31 Jul 2026 08:16:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpiPw-0000000C2cR-144F for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2026 08:16:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87C0C204C; Fri, 31 Jul 2026 01:16:25 -0700 (PDT) Received: from [192.168.178.24] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C4503F86F; Fri, 31 Jul 2026 01:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1785485789; bh=ODD+RQ3c0scVEL717WO54IAEdEQGya0ubicBxFrbSIc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DdPztJIQ7rODWoZdz9EXRz6whXe2bm/U/1uJqikbIUFxF/8lvx87RA4hyN+dP19y1 BvP2OVdH2MYw6Le7L43/rvpHVXqwegrztZA5dIL8CBUjtoyT1nhZK8VPJ/8ajA8Hg/ OIx7uEQXQzNZFbeuXamGSqibAERYQFNi6barE1LE= Message-ID: Date: Fri, 31 Jul 2026 10:16:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 10/10] arm_mpam: detect and enable MPAM-Fb PCC support To: Ben Horgan , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260730152539.2712312-1-andre.przywara@arm.com> <20260730152539.2712312-11-andre.przywara@arm.com> Content-Language: en-GB From: Andre Przywara In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260731_011637_996069_C74EC973 X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ben, On 7/30/26 18:13, Ben Horgan wrote: > Hi Andre, > > On 7/30/26 16:25, Andre Przywara wrote: >> The Arm MPAM-Fb specification [1] describes a protocol to access MSC >> registers through a firmware interface. This requires a shared memory >> region to hold the message, and a mailbox to trigger the access. >> For ACPI this is wrapped as a PCC channel, described using existing >> ACPI abstractions. >> >> Add code to parse those PCC table descriptions associated with an MSC, >> and store the parsed information in the MSC struct. >> There can be multiple PCC channels, and each channel can serve multiple >> MSCs, so we need to keep track of the channel usage, using a list and >> a refcount. >> >> This will be used by the MPAM-Fb access wrapper code. >> >> [1] https://developer.arm.com/documentation/den0144/latest >> >> Signed-off-by: Andre Przywara >> Tested-by: Ritwick Sharma > Ritwick gave his Tested-by for the series on v5. Any reason to just add the tag on this patch? submitting-patches.rst says: "Both Tested-by and Reviewed-by tags, once received on mailing list from tester or reviewer, should be added by author to the *applicable* patches when sending next versions." I think this system relies on MPAM-Fb, so he couldn't test each patch in isolation, but "just" that MPAM-Fb works, which is what only patch 10/10 enables. So I find tags given for the whole series always tricky to handle, but in this case I figured patch 10/10 would be the right target. > I guess patch 9 has significant enough changes to drop tags but I don't see it for the others. Well, even smaller changes could ruin a whole thing, but IIUC in this case Ritwick's setup doesn't even enable error IRQs, so this part wasn't tested anyway. Cheers, Andre.