From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D01BC001B0 for ; Tue, 8 Aug 2023 08:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p1NNpHwmhLwOXLxR39EF8C6qvvJdi4vh8+0NPYZfxK8=; b=42rFdMTsi4iQjw 8VFut4tMiYGng1ad4oLx9pBG8sk7Oi+1opWVpWWrH3y6ittkoAfnAlr9bcQZmOMTRoRGx/8X6Wlen 4W5ElI9hdTctXCvYBk8JyPVKd1HSGkTPQjmN2nAmzdBq/M9e73afnJOWT4FbRB1VcNSYA9wYAF4Ud 7pJnF5P/cUWV/+YTU1ZKS6Zpgp2ADseWQ9ofjD9TWqk4aSgLtKNeAZblYXa6Rp0B+ox81j00IwLZt gR2STme8+kJA0rrz9qhwpGdQyz0adQEuQ3iNTPCA8thO1K31VUfaAwe1SrpLxFQ8sH1LTpuYfFnNv 9rK1uQoDgaKzxIhbnfPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTICe-0023Eb-1Z; Tue, 08 Aug 2023 08:36:32 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTICb-0023Dg-0K for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 08:36:30 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-522ab557632so7158030a12.0 for ; Tue, 08 Aug 2023 01:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691483787; x=1692088587; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k2MJPyoks2T/ViX3nyRQF8CYDSyq3wamUO8HlMVdzMs=; b=e1YSQUOA2uRsuwi93ZAykCI1UcWLRS36mnto/ewFXkzdFzOAP4dvf7nTd5PvuyrgEU z9FLQijlwlag9zYEAwU7VZJly2M6G5wiQ0e5BsxLLhs/g4yilvK/jOBUTEUoLPBHAZwN 8P5Y+4DlfWom1PnmOSMyjy4l724Zu8CQ2IRp4xB7LdlnKw40Oju2Rl8bsjnmqr72NcCy oO0ViJa8lz7uDu/F0wLoM5ezAxdolUMSaCtZbQ1LYG0+hjMAt7o/p6cnebQ0nWHJINVw fSJj3WKp/YuFa6KHO9hYrFnpPXN+qbpYzdU+B7n4+n0gC8pMqPD3ASbUCD7zP/BRK11K BGXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691483787; x=1692088587; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k2MJPyoks2T/ViX3nyRQF8CYDSyq3wamUO8HlMVdzMs=; b=jVDEvVyl6ZYSNMA5+Iy2ODQRD9nw+XlWVQJPjR8WhVA/4CexljFX0n6+Z1Z2bVLcfh q+Fy9XFdJDoUnJnGDgxfIfZPMGrBcsaK0Hs5zr6X+XBv1SofhrUdwoicZOQBJSc7cgbT uYaY8LvO7q4MeSKDMCHWWbSk4F983K9jEvGxse09Fdwy94JQqC+7cwq91QCg0bvMwfy+ VjnoFbhN+nKJDaCb+GcxfinjRjauv8GV356SBAJ8AQeG0ZNU7JmMn9/WGKWEX982bnSP 7h4Lnz3OY195TTsF6r1gFpsvg8KJ0gPANdF8ywtqA5rlAaGcF/ZLJDtyHhEgExmXfCsy S0EA== X-Gm-Message-State: AOJu0YyHQdIKdF9B6NYvpQOd3l6Dag6zyN3j/S8es6b3YjSzIboZiA+V H7zXEHCPRZhlu2QHp/lOCDbewA== X-Google-Smtp-Source: AGHT+IHVYl6k7X1HkWuOZJGrwfDyphp8mGeKHbuzBByCu7FEdYTXY1+5KAwkmhFPQxZ+9wIOIIVSOg== X-Received: by 2002:aa7:d7c7:0:b0:523:2df6:395e with SMTP id e7-20020aa7d7c7000000b005232df6395emr5416705eds.31.1691483787005; Tue, 08 Aug 2023 01:36:27 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id n24-20020a05640204d800b0052307566ed2sm6257416edw.14.2023.08.08.01.36.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 01:36:26 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 10:36:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 3/9] i2c: xlp9xx: Use dev_err_probe in probe function Content-Language: en-US To: Liao Chang , andi.shyti@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-4-liaochang1@huawei.com> From: Krzysztof Kozlowski In-Reply-To: <20230808012954.1643834-4-liaochang1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_013629_138723_0A72C761 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 03:29, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Reviewed-by: Andi Shyti > Signed-off-by: Liao Chang > --- > drivers/i2c/busses/i2c-xlp9xx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c > index f59e8c544f36..08a59a920929 100644 > --- a/drivers/i2c/busses/i2c-xlp9xx.c > +++ b/drivers/i2c/busses/i2c-xlp9xx.c > @@ -529,10 +529,8 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev) > > err = devm_request_irq(&pdev->dev, priv->irq, xlp9xx_i2c_isr, 0, > pdev->name, priv); > - if (err) { > - dev_err(&pdev->dev, "IRQ request failed!\n"); I don't think this is needed: https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel