From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E900C54EEB for ; Sun, 22 Mar 2020 11:51:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48ED020753 for ; Sun, 22 Mar 2020 11:51:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JAJ/iR6g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="R0BqIzrd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48ED020753 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+72/MQxJJLYeOTagIs5bsHf6WyAj+J+a99cHiLHAnTQ=; b=JAJ/iR6gmCbNwP7BsJebLtv/Q Esufp+4vFmfzAbuvX1RO0u5vvzm+D1Ri7ym39uNNRmJNFsh2YOdTyD9//DGZiAr2/Z9+t6f0opt3D xBy+c4eoUOpO7wajTrifxftlnAS7DGuLRIG2yBvBxIor2nAIfWI5ElRn+9xEN/8AJ+Tpyj4GpHZ7K Q8qenUUNMq3wcoVVykhHreWdrTDgdOVHQJ3UcMRoQaH+QZTrdeYBnvUaopuY7VCESX5SQRcRlxuL3 2Rzd7XTEhGAcfIK+GgsVVuk7i3eehe89J/WYClASInKGGBYNvSasQT6ifTsag3M91iVQkoQcbTjme IUxuWiKfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFz8N-0000MX-7J; Sun, 22 Mar 2020 11:51:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFz8K-0000LZ-8P for linux-arm-kernel@lists.infradead.org; Sun, 22 Mar 2020 11:51:13 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4178F20732; Sun, 22 Mar 2020 11:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584877871; bh=4L+US9oyt6r1I7CpRdSaSOrHJKplo8D3RFAXhA3hdMo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R0BqIzrd/qCI/exH8dYpR45RGV/pyISkZIgqN7y2yAXCqvYqhd8Vf/qEKtoxxD0VO HcJciWvxoDtlyvS9WwhU6zu6Q1GxV5/58aTbT8GWbIn+CXbBQ5hP7iqrjWWgQhR7Zt bLXMWyxFZcJRkFdeVFgNmDJxl8quAtU6aW2ZalJY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jFz8H-00Efyv-IX; Sun, 22 Mar 2020 11:51:09 +0000 MIME-Version: 1.0 Date: Sun, 22 Mar 2020 11:51:09 +0000 From: Marc Zyngier To: Linus Walleij Subject: Re: [PATCH] irqchip/versatile-fpga: Apply clear-mask earlier In-Reply-To: References: <20200321133842.2408823-1-mans0n@gorani.run> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, mans0n@gorani.run, linux-oxnas@groups.io, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, narmstrong@baylibre.com, daniel@makrotopia.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200322_045112_325486_608A5A60 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , Neil Armstrong , linux-kernel@vger.kernel.org, Daniel Golle , Sungbo Eo , Thomas Gleixner , linux-oxnas@groups.io, Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-03-22 11:45, Linus Walleij wrote: > On Sat, Mar 21, 2020 at 2:40 PM Sungbo Eo wrote: > >> Clear its own IRQs before the parent IRQ get enabled, so that the >> remaining IRQs do not accidentally interrupt the parent IRQ >> controller. >> >> This patch also fixes a reboot bug on OX820 SoC, where the remaining >> rps-timer IRQ raises a GIC interrupt that is left pending. After that, >> the rps-timer IRQ is cleared during driver initialization, and there's >> no IRQ left in rps-irq when local_irq_enable() is called, which evokes >> an error message "unexpected IRQ trap". >> >> Fixes: bdd272cbb97a ("irqchip: versatile FPGA: support cascaded >> interrupts from DT") >> Signed-off-by: Sungbo Eo >> Cc: Neil Armstrong >> Cc: Daniel Golle > > Good catch! > Reviewed-by: Linus Walleij > > Marc: Cc stable? Sure, I'll add that. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel