From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C210DEB64DD for ; Thu, 13 Jul 2023 08:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=88MRpZvSisp0Q+/6EBUOsVGy1CYpyv+9SH/GBlLa1Ek=; b=ZUmn6nWi3JVwDI 0AMKNTb+AILJagsrn+iw3V5W347hY2G2HckRutfHzskYv3vSaI5qmUNM7ML71foEbN3aBaBK/PIeH IsFScoGyG4xISQhnZWaQySmAB787f9uM+CJasjGc3PixJ0tOyam4GoNFdPuMoQ0KyacTMmaC1omVf wTgxZ/j1s9s9vun9xSt6dqMAgAnivUoxbimLGRz2lJFtD6aVqEJhSXXA1jJnAzUjxy7fPhpRvYdUV 6MQCeDNJoiomIeH97CGNwNk/Q8RJzyzGxavn1cJZPWJkgGXAAB+u1ZcZCnEZgdjmTphX/avftkplX f86oZD8beM+cnEa0/sag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJrjL-002RcN-2F; Thu, 13 Jul 2023 08:31:19 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJrjI-002Rbp-26 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 08:31:18 +0000 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36D690Wc022749; Thu, 13 Jul 2023 08:31:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=8Nis+TfQQ60xMMpmpAn7X685qG++5OrxMeY/JoeqHhE=; b=UmChsKaK6K2+dYjS5XhQeldoBZqOkBW128+Yfo8MO/Xcq8ucIk7nlqRnA5cw7c/Uqomz qwi6Nx9WwTCYKMD8su9tW12OAd0uiLzwbenfygeTth81c+Wh8FqF7QSJBeIcm/VeWAEf 0y9jAI2tNqMbGqab96ZHSYdsI0fL39bGTNtcGOCYVeMSZNRVtxp7NP/ghYQM4z4vWGOn EMBkxVzamKautAQhjJJEFWFjfiTQnTX3B6BD6WeRaSh1Syb63b0/yPd+NZhku3dPFBvA nn9fSCD3KLHFMn2umEUOo/zKHZfjpHdwz5mrQ1HJuSh7vOiSW9ex9mZ1ltQE9M0Jut4U 6g== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rsgarbe9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jul 2023 08:31:10 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36D8V95d007018 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jul 2023 08:31:09 GMT Received: from [10.50.29.227] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Thu, 13 Jul 2023 01:30:40 -0700 Message-ID: Date: Thu, 13 Jul 2023 14:00:37 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V1 2/3] usb: misc: Add notifier call chain to Embedded USB Debug(EUD) driver Content-Language: en-US To: Bhupesh Sharma CC: , , Andy Gross , Konrad Dybcio , "Bjorn Andersson" , , , , "Sibi Sankar" , Rajendra Nayak References: <18212c7abbb8c833cc07f8500d4905b79c49ec59.1689148711.git.quic_schowdhu@quicinc.com> From: Souradeep Chowdhury In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: I0ZCF5f4y-kgScOhUZzZWf7dGTRd6mv_ X-Proofpoint-ORIG-GUID: I0ZCF5f4y-kgScOhUZzZWf7dGTRd6mv_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-13_04,2023-07-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1011 adultscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307130073 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_013116_698515_5D80E855 X-CRM114-Status: GOOD ( 32.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/12/2023 11:52 PM, Bhupesh Sharma wrote: > Hi Souradeep, > > On Wed, 12 Jul 2023 at 13:58, Souradeep Chowdhury > wrote: >> >> Add the notifier call chain to EUD driver. The notifier call chain >> is added to check the role-switch status of EUD. When multiple >> modules are switching roles on the same port, they need to call this >> notifier to check the role-switch status of EUD. If EUD is disabled, >> then the modules can go for the role-switch, otherwise it needs to >> be blocked. The notifier chain can be used to link multiple modules >> switching roles on the same port and create a ordering, priority and >> conflict resolution among them. The wrapper functions are defined here >> which can be used to register a notifier block to the chain, deregister >> it and also call the chain. >> >> Signed-off-by: Souradeep Chowdhury >> --- >> drivers/usb/misc/qcom_eud.c | 52 +++++++++++++++++++++++++++++++++++-- >> 1 file changed, 50 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c >> index 7f371ea1248c..e6c97a2cf2df 100644 >> --- a/drivers/usb/misc/qcom_eud.c >> +++ b/drivers/usb/misc/qcom_eud.c >> @@ -11,10 +11,13 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> #include >> #include >> #include >> +#include "qcom_eud_notifier.h" >> >> #define EUD_REG_INT1_EN_MASK 0x0024 >> #define EUD_REG_INT_STATUS_1 0x0044 >> @@ -22,14 +25,16 @@ >> #define EUD_REG_VBUS_INT_CLR 0x0080 >> #define EUD_REG_CSR_EUD_EN 0x1014 >> #define EUD_REG_SW_ATTACH_DET 0x1018 >> -#define EUD_REG_EUD_EN2 0x0000 >> +#define EUD_REG_EUD_EN2 0x0000 >> >> #define EUD_ENABLE BIT(0) >> -#define EUD_INT_PET_EUD BIT(0) > > These indentation issues are already addressed in my EUD patches. > Please rebase your patches on the same to reuse those Ack > >> +#define EUD_INT_PET_EUD BIT(0) >> #define EUD_INT_VBUS BIT(2) >> #define EUD_INT_SAFE_MODE BIT(4) >> #define EUD_INT_ALL (EUD_INT_VBUS | EUD_INT_SAFE_MODE) >> >> +static RAW_NOTIFIER_HEAD(eud_nh); >> + >> struct eud_chip { >> struct device *dev; >> struct usb_role_switch *role_sw; >> @@ -41,6 +46,42 @@ struct eud_chip { >> bool usb_attached; >> }; >> >> +int eud_register_notify(struct notifier_block *nb) >> +{ >> + return raw_notifier_chain_register(&eud_nh, nb); >> +} >> +EXPORT_SYMBOL_GPL(eud_register_notify); >> + >> +void eud_unregister_notify(struct notifier_block *nb) >> +{ >> + raw_notifier_chain_unregister(&eud_nh, nb); >> +} >> +EXPORT_SYMBOL_GPL(eud_unregister_notify); >> + >> +void eud_notifier_call_chain(unsigned long role_switch_state) >> +{ >> + raw_notifier_call_chain(&eud_nh, role_switch_state, NULL); >> +} >> +EXPORT_SYMBOL_GPL(eud_notifier_call_chain); > > Probably I missed it, but you have not provided any example users of > these APIs in the patchset or reference to another one which shows how > these APIs are used. Ack, the usage for this will be posted in the next version. > >> +static int eud_vbus_spoof_attach_detach(struct notifier_block *nb, unsigned long event, >> + void *data) >> +{ >> + struct device_node *eud = of_find_compatible_node(NULL, NULL, "qcom,eud"); >> + struct device *eud_device = bus_find_device_by_of_node(&platform_bus_type, eud); >> + struct eud_chip *eud_data = dev_get_drvdata(eud_device); >> + >> + if (eud_data->enabled && event != USB_ROLE_DEVICE) >> + return NOTIFY_BAD; >> + else >> + return NOTIFY_OK; >> +} >> + >> +static struct notifier_block eud_notifier = { >> + .notifier_call = eud_vbus_spoof_attach_detach, >> + .priority = 1, > > Why do you need a 'priority = 1' here, it can be 0 or even lower? Priority is 0 by default for a notifier block, since eud notifier needs to be the first to be called in the chain to check the role-switch status, I have kept the priority as 1 here. > > Thanks, > Bhupesh > >> +}; >> + >> static int enable_eud(struct eud_chip *priv) >> { >> writel(EUD_ENABLE, priv->base + EUD_REG_CSR_EUD_EN); >> @@ -196,6 +237,10 @@ static int eud_probe(struct platform_device *pdev) >> return dev_err_probe(chip->dev, ret, >> "failed to add role switch release action\n"); >> >> + ret = eud_register_notify(&eud_notifier); >> + if (ret) >> + return dev_err_probe(chip->dev, ret, "failed to register notifier\n"); >> + >> chip->base = devm_platform_ioremap_resource(pdev, 0); >> if (IS_ERR(chip->base)) >> return PTR_ERR(chip->base); >> @@ -226,6 +271,9 @@ static void eud_remove(struct platform_device *pdev) >> >> device_init_wakeup(&pdev->dev, false); >> disable_irq_wake(chip->irq); >> + eud_unregister_notify(&eud_notifier); >> + >> + return 0; >> } >> >> static const struct of_device_id eud_dt_match[] = { >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel