From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38611C6FA82 for ; Wed, 21 Sep 2022 16:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xl6rLX4tI1aSnTY+jTzkfeeo9y3qCiVSHx9DMYaCdIA=; b=XtpVt+GTEW41z1 l0ymtt3URSIgtuggwFSP811wxWV7hSm9kBGeZ2p7k5VqTCr+GxgAk7rLnzsiRcpKHIfNmC3Yr8ZGn HFO/JLaaFLnDPIOX3G2X9kFdCWb0k/HIyozmt2xfsdz1FuXs0ZNiaXofXyKCGo4LKH5QkXOLRPGrK YCYUY7REx5UCtKedlZphHi6QnOp2+WWxXtzfSogrt7xoEdmAU3/rszm9jwac99sCiwMnC+m/IAPH4 C18+RBxbGUYVuqg4HW4bydQqO/dty2L17B2DXP8zemC/ERCwYF/LKIklezydkJKDC0AcfI9vqWC8D kNRYvTt3e5neEI7u9WLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ob2PU-00Bxhv-4X; Wed, 21 Sep 2022 16:17:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ob2PQ-00BxhF-Uk for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2022 16:17:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8480C1FC4; Wed, 21 Sep 2022 09:17:16 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 373FB3F5A1; Wed, 21 Sep 2022 09:17:09 -0700 (PDT) Message-ID: Date: Wed, 21 Sep 2022 17:17:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/1] perf/arm-cmn: Add more bits to child node address offset field Content-Language: en-GB To: Ilkka Koskinen , Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@amperecomputing.com References: <20220808195455.79277-1-ilkka@os.amperecomputing.com> From: Robin Murphy In-Reply-To: <20220808195455.79277-1-ilkka@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_091713_065933_A037A945 X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2022 8:54 pm, Ilkka Koskinen wrote: > CMN-600 uses bits [27:0] for child node address offset while bits [30:28] > are required to be zero. > > For CMN-650, the child node address offset field has been increased > to include bits [29:0] while leaving only bit 30 set to zero. > > Let's include the missing two bits and assume older implementations > comply with the spec and set bits [29:28] to 0. Just to add that other users have run into this as well, so getting it applied as a fix would be just lovely. Technically I think it's: Fixes: 60d1504070c2 ("perf/arm-cmn: Support new IP features") Cheers, Robin. > Signed-off-by: Ilkka Koskinen > --- > > I have tested this patch on CMN-600 and CMN-650. > > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 80d8309652a4..b80a9b74662b 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -36,7 +36,7 @@ > #define CMN_CI_CHILD_COUNT GENMASK_ULL(15, 0) > #define CMN_CI_CHILD_PTR_OFFSET GENMASK_ULL(31, 16) > > -#define CMN_CHILD_NODE_ADDR GENMASK(27, 0) > +#define CMN_CHILD_NODE_ADDR GENMASK(29, 0) > #define CMN_CHILD_NODE_EXTERNAL BIT(31) > > #define CMN_MAX_DIMENSION 12 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel