From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFB3BC79F99 for ; Mon, 7 Sep 2026 21:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=km54XNA3pesnlH9MUSOEbKUzj91GMmwN/4bvXZLN1Qw=; b=N5EMP65gpRler/Nq+PcTtftfKq mxtlUBjgGYVN/uEqqWwr5Mg5yrdeUV3Sg+MHcrrttSZzz+HIWm6t0lD1J6/lT78NWbKrUL9gx30ot FhpfAq28btJXfHDtD3aVv3r0yfW+5IbpKsGECGyF1tgM10LASENwU9lsjAGiPsVxcMujp8vCtS8iZ okxChG7DRs9kPo/uWKybKntcm1ZnYf+zH+9pguEa8RLQBhU+lv+BkvD8foLucomWGvUNnn7KTdv5B nK0/r9EfDoBt7pO+HwxK82opwHUrIw9KyM6n7N+ylKoohppsGTLpk//CoG4DG+vnzzSJDAW5rakxY DrqQ2bDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3gSj-00000007jsZ-2Ujw; Mon, 07 Sep 2026 21:01:09 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3gSh-00000007jsC-0oNh for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2026 21:01:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788814864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=km54XNA3pesnlH9MUSOEbKUzj91GMmwN/4bvXZLN1Qw=; b=E4srLzoRT2lSFcaQysiCLk/7gYWQXXHBWble0pc3yRK0BKbcUWXlkkenZdQBdblXltv429 aq23hN2ImYmLgJhVNpUkK9ErT/FV8Sa0bc3WYo3Bf/cgSD4jChuPK5MW4huzJs8Xh8G3m2 v2U/A6AYyGRGC393cggcW25+9qGapb4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-o4Bw3diEPLeIJ5100s8A0A-1; Mon, 07 Sep 2026 17:01:02 -0400 X-MC-Unique: o4Bw3diEPLeIJ5100s8A0A-1 X-Mimecast-MFC-AGG-ID: o4Bw3diEPLeIJ5100s8A0A_1788814862 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-495529a93f9so38127815e9.3 for ; Mon, 07 Sep 2026 14:01:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788814861; x=1789419661; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=km54XNA3pesnlH9MUSOEbKUzj91GMmwN/4bvXZLN1Qw=; b=XEMtcbprOqOIhFjskJBXZfnkOiKJP9fYvL37eWVOAnoCiV7+zX7Fh05TBxcsMp48ZF zWkjEey2DRRkHmtzObGITC5q4eGjmWZVeVQh+KDEHu7SFKPmhYilGrMG85W6cxd9gHVF J3Ik6IjtxfXPgGuZ3Lifszc+t4w3ri25+L8zYIBaiI2ouJnGS5AtbqbNBforyg+4W8oN k4l/rIcfJGZQlNvjjWTD5plh3NTsixfXBglFxKLM4SCUvNsoSTCMTpC7ytPMCPa3xlYA NEhIUU2fl/Ik11GBcTnzzvoleVEKj6xfSNXGbsZnv4xaIqWBqjXJgbYgnBo5/vIHKLCX 31CA== X-Forwarded-Encrypted: i=1; AKwUvByqMFiyHhcjP440GL8BjJkraTyPluDGxorP/k/sKriuwz0cjL/vM/NHASaxn0odn4B41CIbPcBJv1/7QJv6M1i3@lists.infradead.org X-Gm-Message-State: AFuF++kXaYslHn9tdBQFY6E+kO8bbFF0QV03+mZtQRHIUqN2KshzLvuo ISo3ssTsgCJkCrC9awQYyMsR1GPucT3wk2ROkiz18Dk28ZBrfb0hEQsWWBS3rJgcfVizXXCLcQq oRBG1gMljnIanHPW7kM9T5s1hdgINsuqLFVi/mj89kf5aufibNXzj9lNka3CELlyXpsktc/UeTx hD X-Gm-Gg: AYBFou1Nb46JJI5+0gTEgcfe0mVY82BF3q/piN27ZYYQUyQfd03+MipmKiJ0eadUdOY cirfVK2wu/eCaJ8KYZ+MWjI3QUUFTl631x/ikoGB14WK3eMcm/6Sme2INAJ3/v16BbHxayrjGmU f1sw4yuL410A6lwliXQIqQSnTF0rSuaoIDZlKXa8fJuqIzngDHiiR9p0V+vr3tOZ6dfB7Eyc8yB snGGli8ahDNkHY7LG/EGyIdKHXdzoW86Bdkq2OkWEWJu3YGKUV7M3TNTE0JP7mgz9lmMDVpLYya w0y3W767nuYEfz8+3vBt3pXCO1ZBGI4TeI8XWSlWrerPHznHsQDCixFHDGfGPM3NR+4C+oOIjrg YzD9kR8rd0KvqMU3Xm5PGsfNiVqRHIBE5dae2gxAXZWCi6EqX X-Received: by 2002:a05:600d:8649:10b0:49c:fa20:cc0a with SMTP id 5b1f17b1804b1-49cfa20cd58mr167275165e9.33.1788814861728; Mon, 07 Sep 2026 14:01:01 -0700 (PDT) X-Received: by 2002:a05:600d:8649:10b0:49c:fa20:cc0a with SMTP id 5b1f17b1804b1-49cfa20cd58mr167274945e9.33.1788814861409; Mon, 07 Sep 2026 14:01:01 -0700 (PDT) Received: from ?IPV6:2a01:e0a:11aa:87f0:ea69:b2b0:2dae:5ef9? ([2a01:e0a:11aa:87f0:ea69:b2b0:2dae:5ef9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7703cefsm458086515e9.5.2026.09.07.14.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Sep 2026 14:01:00 -0700 (PDT) Message-ID: Date: Mon, 7 Sep 2026 23:00:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/14] drm/panic: Do not use un-escaped URL as format string To: Thomas Zimmermann , javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, geert@linux-m68k.org, rdunlap@infradead.org Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, nouveau@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, virtualization@lists.linux.dev, sashiko-reviews@lists.linux.dev, stable@vger.kernel.org References: <20260902121930.597222-1-tzimmermann@suse.de> <20260902121930.597222-2-tzimmermann@suse.de> From: Jocelyn Falempe In-Reply-To: <20260902121930.597222-2-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WrkRyQQns1yc-gTMCv1EwtLOyiQhpSo9MxJeFHW7aDU_1788814862 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260907_140107_317236_58BFCFA7 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/2/26 14:13, Thomas Zimmermann wrote: > Replace the direct use of DRM_PANIC_SCREEN_QR_CODE_URL in snprintf() > with a %s conversion specifier. Avoids a possible vulnerabilty from > a crafted URL string. > > As the attacker needs to control the kernel at the Kconfig level, the > potential for an exploit is likely low. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe > > Signed-off-by: Thomas Zimmermann > Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") > Cc: Javier Martinez Canillas > Cc: Jocelyn Falempe > Cc: dri-devel@lists.freedesktop.org > Cc: # v6.12+ > --- > drivers/gpu/drm/drm_panic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c > index e576c4791861..ba21df4be338 100644 > --- a/drivers/gpu/drm/drm_panic.c > +++ b/drivers/gpu/drm/drm_panic.c > @@ -658,7 +658,8 @@ static int drm_panic_get_qr_code_url(u8 **qr_image) > char *kmsg; > int max_qr_data_size, url_len; > > - url_len = snprintf(url, sizeof(url), CONFIG_DRM_PANIC_SCREEN_QR_CODE_URL "?a=%s&v=%s&z=", > + url_len = snprintf(url, sizeof(url), "%s?a=%s&v=%s&z=", > + CONFIG_DRM_PANIC_SCREEN_QR_CODE_URL, > utsname()->machine, utsname()->release); > > max_qr_data_size = drm_panic_qr_max_data_size(panic_qr_version, url_len);