From: Quan Nguyen <quan@os.amperecomputing.com>
To: Wolfram Sang <wsa@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Corey Minyard <minyard@acm.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
openipmi-developer@lists.sourceforge.net,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
thang@os.amperecomputing.com
Subject: Re: [PATCH v9 3/3] i2c: aspeed: Assert NAK when slave is busy
Date: Mon, 3 Oct 2022 09:06:46 +0700 [thread overview]
Message-ID: <b35f756d-08e7-6eed-5992-ad63ee419e1f@os.amperecomputing.com> (raw)
In-Reply-To: <YzjFRrCRZBAaSRBL@shikoro>
On 02/10/2022 05:55, Wolfram Sang wrote:
>
>> + if (ret == -EBUSY)
>
> Since we documented this:
>
> "+ 'ret': 0 if the backend is ready, otherwise some errno"
>
> the code above should be '(ret < 0)'
>
Will update.
Thanks a lot for the review.
- Quan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-10-03 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 8:03 [PATCH v9 0/3] Add SSIF BMC driver Quan Nguyen
2022-09-29 8:03 ` [PATCH v9 1/3] ipmi: ssif_bmc: " Quan Nguyen
2022-09-29 8:03 ` [PATCH v9 2/3] bindings: ipmi: Add binding for " Quan Nguyen
2022-09-29 8:03 ` [PATCH v9 3/3] i2c: aspeed: Assert NAK when slave is busy Quan Nguyen
2022-10-01 22:55 ` Wolfram Sang
2022-10-03 2:06 ` Quan Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35f756d-08e7-6eed-5992-ad63ee419e1f@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox