From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C407C7619A for ; Sat, 15 Apr 2023 04:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HTeBr5Eo9zLj/0tY6bUhfdXrekbPJ4y1hw0qrgIedtg=; b=kpSTv9qw7fPmQq JWDZlqweOjwnun8/gVfNnY7AGYX5EPRB4CRytO+5RoiH6tAAZ0zE4I95Kxhi28O0hblzXaBCplmlE tWwrruF778v1d9MuOKjSqwsVL55GR9d2YKXW1nWe5RjCrUehci3gOrDKXQfrE11OeYRO59p84IACQ ZHYccPmzGLq2ao3sjNo2OvG0ZuEr/6wQIwGPKg39ANo/9gxqD9S6pE4Rt5BHdhPGUKp5Hw2hSV7I3 mjIdfbQuUqOl0ARet4+BIHZ+MRIaAQcyoBujY5MAnBdYbRC6EdRCPassemxIh6y8lZTu/vRh+ldS5 Nc/KR2adP+AGpI31QDrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnXBJ-00BEds-19; Sat, 15 Apr 2023 04:06:33 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnXBF-00BEcz-0T for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 04:06:31 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33F46LVc127207; Fri, 14 Apr 2023 23:06:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681531581; bh=pd0Qa8fePEV2iiQW8OcIjWy9cCAQwF2FbB1zdYHuJ9M=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=UvEvAzHMlNhr2fMn4uu8rWv0f9cUcp6BEAaZUcqpXELtV5w6kxtG4io7f5LBr5g5A eXWM2tgfAGrJrrEjtw27YJuvyBOSo9Q8UzWJu2CNfpERSSgGjxBpPh7S76Of4IVhht eylpU1x4k4KH2YEfvbcS9ynX60NC5mK+tbyigwqM= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33F46L94015602 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Apr 2023 23:06:21 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 14 Apr 2023 23:06:21 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 14 Apr 2023 23:06:20 -0500 Received: from [10.249.130.34] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33F46HhF092764; Fri, 14 Apr 2023 23:06:17 -0500 Message-ID: Date: Sat, 15 Apr 2023 09:36:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C To: Nishanth Menon CC: , , , , , , , , , , References: <20230414181434.2046049-1-u-kumar1@ti.com> <20230414181434.2046049-3-u-kumar1@ti.com> <20230414182401.2yfpwjug3naiwesi@quicksand> Content-Language: en-US From: "Kumar, Udit" In-Reply-To: <20230414182401.2yfpwjug3naiwesi@quicksand> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_210629_344942_39835450 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth On 4/14/2023 11:54 PM, Nishanth Menon wrote: > On 23:44-20230414, Udit Kumar wrote: >> All I2C nodes were disabled in SOC dts file and in board >> dts needed nodes were enabled. > redundant. ok > >> This patch enables wkup_i2c0 node in board dts file. >> >> Fixes: a9ed915cd55c ("arm64: dts: ti: k3-j7200: Enable I2C nodes at the board level") > > This should'nt be fixing the commit - the commit is correct in the sense > that if the board does'nt describe a node with pinmux, the i2c is'nt > functional in the first place. well, how i look at before this patch each i2c was functional. this fix is making needed i2c as disabled, however this fix is correct I am ok to remove Fixes >> Signed-off-by: Udit Kumar >> --- >> arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> index 63633e4f6c59..e66bbfe65ff2 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> @@ -254,6 +254,10 @@ exp3: gpio@20 { >> }; >> }; >> >> +&wkup_i2c0 { >> + status = "okay"; > How about the pinmux? speed? what peripheral is on the wakeup i2c? > > Do we have an eeprom or something here? This got eeprom and PMIC, eeprom read is ok with pin mux and speed. if you want to specify, let me know >> +}; >> + >> &main_sdhci0 { >> /* eMMC */ >> non-removable; >> -- >> 2.34.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel