From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF2BC43217 for ; Wed, 20 Oct 2021 08:07:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CE0E608FE for ; Wed, 20 Oct 2021 08:07:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4CE0E608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/KQECHXM3GWkrHmMsoZ7QbFzd2WpoiT9MbXKcoP/55Q=; b=bm/5TYFCRi80kBqmBTkAw7GUVh NXMXyh5GXRXTuZJPGghc50An0jWhzeZ/vdvEb7WjTdUks1z5p1RiL8qwZUauG1Zjl//Qp7FOhE0hl L/4N7x8gDCr/TEru/kAaS/9Yx44H4bPW9WEzoqYLS6s6kjJ6CDuAprVzcGFCqw/q8/ivQfTU+6Pty KsX0OAuYaXRFuHniTDpRo1dL2M8F/WTvAUmXfIdDayOZ139R2RcfnD8axveOx3sQa9p5UNhoFoizE fQMecqRJs95ie40go+EWg1XXPJrz8vIvuQsq6+ZPjRA7J4ImnQumkAvVotDjxqcTtTv0Un9d3qoOT korOppNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md6NP-003jQg-VU; Wed, 20 Oct 2021 07:51:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md6NJ-003jO4-4r for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 07:51:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E15A2F; Wed, 20 Oct 2021 00:50:54 -0700 (PDT) Received: from [192.168.1.131] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B0273F70D; Wed, 20 Oct 2021 00:50:51 -0700 (PDT) Subject: Re: [PATCH v2 1/4] arm64: vdso32: drop the test for dmb ishld To: Nick Desaulniers , Catalin Marinas , Will Deacon Cc: llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nathan Chancellor , Christian Biesinger , Simon Marchi References: <20211019223646.1146945-1-ndesaulniers@google.com> <20211019223646.1146945-2-ndesaulniers@google.com> From: Vincenzo Frascino Message-ID: Date: Wed, 20 Oct 2021 09:51:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211019223646.1146945-2-ndesaulniers@google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_005101_328139_7E2EC455 X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/20/21 12:36 AM, Nick Desaulniers wrote: > Binutils added support for this instruction in commit > e797f7e0b2bedc9328d4a9a0ebc63ca7a2dbbebc which shipped in 2.24 (just > missing the 2.33 release) but was cherry-picked into 2.23 in commit s/just missing the 2.33 release/just missing the 2.23 release/ > 27a50d6755bae906bc73b4ec1a8b448467f0bea1. Thanks to Christian and Simon > for helping me with the patch archaeology. > > According to Documentation/process/changes.rst, the minimum supported > version of binutils is 2.23. Since all supported versions of GAS support > this instruction, drop the assembler invocation, preprocessor > flags/guards, and the cross assembler macro that's now unused. > > This also avoids a recursive self reference in a follow up cleanup > patch. > > Cc: Christian Biesinger > Cc: Simon Marchi > Signed-off-by: Nick Desaulniers Otherwise: Reviewed-by: Vincenzo Frascino > --- > Changes v1 -> v2: > * Fix typos (2.33 -> 2.23, 2.34 -> 2.24) as per Christian. > > arch/arm64/include/asm/vdso/compat_barrier.h | 2 +- > arch/arm64/kernel/vdso32/Makefile | 8 -------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/arch/arm64/include/asm/vdso/compat_barrier.h b/arch/arm64/include/asm/vdso/compat_barrier.h > index 3fd8fd6d8fc2..fb60a88b5ed4 100644 > --- a/arch/arm64/include/asm/vdso/compat_barrier.h > +++ b/arch/arm64/include/asm/vdso/compat_barrier.h > @@ -20,7 +20,7 @@ > > #define dmb(option) __asm__ __volatile__ ("dmb " #option : : : "memory") > > -#if __LINUX_ARM_ARCH__ >= 8 && defined(CONFIG_AS_DMB_ISHLD) > +#if __LINUX_ARM_ARCH__ >= 8 > #define aarch32_smp_mb() dmb(ish) > #define aarch32_smp_rmb() dmb(ishld) > #define aarch32_smp_wmb() dmb(ishst) > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 3dba0c4f8f42..89299a26638b 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -29,8 +29,6 @@ cc32-option = $(call try-run,\ > $(CC_COMPAT) $(1) -c -x c /dev/null -o "$$TMP",$(1),$(2)) > cc32-disable-warning = $(call try-run,\ > $(CC_COMPAT) -W$(strip $(1)) -c -x c /dev/null -o "$$TMP",-Wno-$(strip $(1))) > -cc32-as-instr = $(call try-run,\ > - printf "%b\n" "$(1)" | $(CC_COMPAT) $(VDSO_AFLAGS) -c -x assembler -o "$$TMP" -,$(2),$(3)) > > # We cannot use the global flags to compile the vDSO files, the main reason > # being that the 32-bit compiler may be older than the main (64-bit) compiler > @@ -113,12 +111,6 @@ endif > VDSO_AFLAGS := $(VDSO_CAFLAGS) > VDSO_AFLAGS += -D__ASSEMBLY__ > > -# Check for binutils support for dmb ishld > -dmbinstr := $(call cc32-as-instr,dmb ishld,-DCONFIG_AS_DMB_ISHLD=1) > - > -VDSO_CFLAGS += $(dmbinstr) > -VDSO_AFLAGS += $(dmbinstr) > - > # From arm vDSO Makefile > VDSO_LDFLAGS += -Bsymbolic --no-undefined -soname=linux-vdso.so.1 > VDSO_LDFLAGS += -z max-page-size=4096 -z common-page-size=4096 > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel