From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B03E4C4332F for ; Mon, 14 Nov 2022 08:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RN8XFCmUt0kvcuyvof6WriS9uOBgOMQX64w26E5LAK0=; b=DamemSMO7Tnmkn jXidmeVA9U9yYQq2euz2CGYhRaXQmKowTd/XZBa5mlQv7REluQx/O49h4rBsZbgcQF1MrhFJflRxi 5ce9HQaMGq2JTGxyseKwrljjvY+LoZVcSJAiJ5EQPrHCZ7Rgz1BwbcmlctoFLk0u0eaAG6PRzLfcW fFsJZ4trGlVxtosKt6AkAGa/hDwdtwti8g94oVTQUPqu1pe2LWLceJN+EDQ8dr4NGmqcxQApnocnT 6Um8Fln5Rra+hvsT1mRZu1cRTZ199SXxCxS+okLeFLhSUHEowkhH8ngkX9R2WwnXK3oDtSAzoKrVY NA0udo42jNLOp2M05a2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouUwo-00GrN5-AO; Mon, 14 Nov 2022 08:36:06 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouUwk-00GrLO-5J for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 08:36:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668414962; x=1699950962; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=fdpZZ4r1hTVkoO3kGE4DlZQf60aaP2bmV66mBFHDQ/U=; b=BG+DCtkTFkiEtTFsoXvWXo8Qvacgw6YVztElzgv9sfP6vUmCefTd7k5u 3IxdPg3DxentcSs1rwCNpTb81Ehot1ATH5Eu2pXaAijp3qLEwCMHyIM9P UsdMvTfpOcgD+apLJMlHQcgKHHv5JWxS3fcTNpacrb9r22nelkWkoZq5h OQJaEt9fHQ6VHc0PfsJ++xAdlCbDxNqbR/tRcikSIvz1gpSta2zWjiaIH XYSefOmQbWAkXmYUmhVzxyWgZSGzhnXZySPAJ9WiykD/XHfKhNYaQWFOs fNDLB1SU3yTEZLVI+75W0vmooyM/nebh6OQ+0sFiUajxjcyrQbxckVzYI Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="292313329" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="292313329" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 00:36:00 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="967483826" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="967483826" Received: from xingzhen-mobl.ccr.corp.intel.com (HELO [10.254.211.184]) ([10.254.211.184]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 00:35:56 -0800 Message-ID: Date: Mon, 14 Nov 2022 16:35:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH v2 3/6] perf vendor events arm64: Add cache metrics for neoverse-n2 To: Jing Zhang , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1668411720-3581-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-4-git-send-email-renyu.zj@linux.alibaba.com> Content-Language: en-US From: Xing Zhengjun In-Reply-To: <1668411720-3581-4-git-send-email-renyu.zj@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_003602_278160_FB32541F X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/14/2022 3:41 PM, Jing Zhang wrote: > Add cache related metrics. > > Signed-off-by: Jing Zhang > --- > .../arch/arm64/arm/neoverse-n2/metrics.json | 77 ++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > index 324ca12..1690ef6 100644 > --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > @@ -54,5 +54,82 @@ > "BriefDescription": "The rate of DTLB Walks to the overall TLB lookups", > "MetricGroup": "TLB", > "MetricName": "dtlb_walk_rate" > + }, > + { > + "MetricExpr": "L1I_CACHE_REFILL / INST_RETIRED * 1000", > + "PublicDescription": "The rate of L1 I-Cache misses per kilo instructions", > + "BriefDescription": "The rate of L1 I-Cache misses per kilo instructions", > + "MetricGroup": "Cache", > + "MetricName": "l1i_cache_mpki" > + }, > + { > + "MetricExpr": "L1I_CACHE_REFILL / L1I_CACHE", > + "PublicDescription": "The rate of L1 I-Cache misses to the overall L1 I-Cache", > + "BriefDescription": "The rate of L1 I-Cache misses to the overall L1 I-Cache", > + "MetricGroup": "Cache", > + "MetricName": "l1i_cache_miss_rate" > + }, > + { > + "MetricExpr": "L1D_CACHE_REFILL / INST_RETIRED * 1000", > + "PublicDescription": "The rate of L1 D-Cache misses per kilo instructions", > + "BriefDescription": "The rate of L1 D-Cache misses per kilo instructions", > + "MetricGroup": "Cache", > + "MetricName": "l1d_cache_mpki" > + }, > + { > + "MetricExpr": "L1D_CACHE_REFILL / L1D_CACHE", > + "PublicDescription": "The rate of L1 D-Cache misses to the overall L1 D-Cache", > + "BriefDescription": "The rate of L1 D-Cache misses to the overall L1 D-Cache", > + "MetricGroup": "Cache", > + "MetricName": "l1d_cache_miss_rate" > + }, > + { > + "MetricExpr": "L2D_CACHE_REFILL / INST_RETIRED * 1000", > + "PublicDescription": "The rate of L2 D-Cache misses per kilo instructions", > + "BriefDescription": "The rate of L2 D-Cache misses per kilo instructions", > + "MetricGroup": "Cache", > + "MetricName": "l2d_cache_mpki" > + }, > + { > + "MetricExpr": "L2D_CACHE_REFILL / L2D_CACHE", > + "PublicDescription": "The rate of L2 D-Cache misses to the overall L2 D-Cache", > + "BriefDescription": "The rate of L2 D-Cache misses to the overall L2 D-Cache", > + "MetricGroup": "Cache", > + "MetricName": "l2d_cache_miss_rate" > + }, > + { > + "MetricExpr": "L3D_CACHE_REFILL / INST_RETIRED * 1000", > + "PublicDescription": "The rate of L3 D-Cache misses per kilo instructions", > + "BriefDescription": "The rate of L3 D-Cache misses per kilo instructions", > + "MetricGroup": "Cache", > + "MetricName": "l3d_cache_mpki" > + }, > + { > + "MetricExpr": "L3D_CACHE_REFILL / L3D_CACHE", > + "PublicDescription": "The rate of L3 D-Cache misses to the overall L3 D-Cache", > + "BriefDescription": "The rate of L3 D-Cache misses to the overall L3 D-Cache", > + "MetricGroup": "Cache", > + "MetricName": "l3d_cache_miss_rate" > + }, > + { > + "MetricExpr": "LL_CACHE_MISS_RD / INST_RETIRED * 1000", > + "PublicDescription": "The rate of LL Cache read misses per kilo instructions", > + "BriefDescription": "The rate of LL Cache read misses per kilo instructions", > + "MetricGroup": "Cache", > + "MetricName": "ll_cache_read_mpki" > + }, > + { > + "MetricExpr": "LL_CACHE_MISS_RD / LL_CACHE_RD", > + "PublicDescription": "The rate of LL Cache read misses to the overall LL Cache read", > + "BriefDescription": "The rate of LL Cache read misses to the overall LL Cache read", > + "MetricGroup": "Cache", > + "MetricName": "ll_cache_read_miss_rate" > + }, > + { > + "MetricExpr": "(LL_CACHE_RD - LL_CACHE_MISS_RD) / LL_CACHE_RD", > + "PublicDescription": "The rate of LL Cache read hit to the overall LL Cache read", > + "BriefDescription": "The rate of LL Cache read hit to the overall LL Cache read", > + "MetricGroup": "Cache", > + "MetricName": "ll_cache_read_hit_rate" > } > ] > \ No newline at end of file It is better to fix this by adding a newline at the end of the file. -- Zhengjun Xing _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel