From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E13E9C433E0 for ; Mon, 27 Jul 2020 10:46:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC3C0206E7 for ; Mon, 27 Jul 2020 10:46:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jgCY14Gk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Y6hE4OHz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="aWamxGIb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC3C0206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3vF4gY7FR2ApmPZ7ylg78EXLGgdGk8B+IhdMPjrn85E=; b=jgCY14Gk+VqudoYmcfTb7wDHe ZY4HFpgrRUYpZDcgtE6oaVSN7EfvWvsNpf7YEOvm+taxEo7vQ2yHwT2F/og+M9Qt0jtFOeiNvY2GU 8Nbd+NpZZsgO3j3JZ/V8hI0hjBD21jzrIPpWhEZW+B9aXOvJuRnkr6TooSEeVagk4/T/TNCLY2MiG jYITzFznIVnQp55IzJK+d/YuLsP9pUJmZUfPj1YN7S6qoU9NzQgPxiK+Zp3Z5eITswdGfgwuQewtJ a3JgBnJ+pn/3HG5Flpj3S4CxelB0MKqO/a8XQu7rem/FE8YQMI5sWma/GHZ+B/0bIpoqe1ALPcC8n prLjULNgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k00d0-00052N-3G; Mon, 27 Jul 2020 10:45:06 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k00cx-00051Y-QX for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 10:45:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595846703; x=1627382703; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=D9OManMhSnJ2ZpGth+OhcoCoUwpfPMcYjAJbIOD/AT0=; b=Y6hE4OHzJAD/aDslq9bcvHN2WcD7JEMMBzkde9gdsBTJVT6g4iru6dTX +0jELWMo0xxsh7Aum4Hjxp6Yyrfdd8wrIU4XFymQqJL/9uTEC5jUEBbjp CZUpRvgwR1n3koMaR9AodNC7RMRlcxe8CsVsCmsiDS0MJpcEh5GqHEmG1 qk8T/QANv6NOUW2tgH+cfT3YO3U/1zAIUZyXxgI7ZJtqChXNx6HxB8rof GC5RtSJCiwQ0Hb1pZdbJNRFPNTT+qdMYq79NtiyQO+hVl5vX/0RSIM/6O 3G6tRzM0ML2K6lBoQmrcJYW/hvZI+wQdxPQET14R3MsznxJic9nOcUjx6 Q==; IronPort-SDR: Gky0xfNwqTHsb27ON6wLqSmGeqe5VHlZLmGO09cOAi0Nojqo+AgL6s9RWx6QGeMY/rGpOBuV18 ADPAhP1+7rTtJ1A7RhFwDK8GEXuiYw8zs6Luy5lvAT2WQAwYHrZ8Al9JIF9FYPgfNXitfi5PF6 6+pAuMZ8uZa6U1kXUr5gHrTXLqZEYwUcAnXeo4VABA76t+60FCR5Wn644clzERduJRVs8YV6Gw t4gAtC6BusVqYVQ976CshmC25mvTKmb/HY1BE3xqdxGSLA92WB/qYshWoZ5baw7oZoQNR9ZdWV a2I= X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="20658831" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 Jul 2020 03:45:01 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 27 Jul 2020 03:44:15 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Mon, 27 Jul 2020 03:44:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMRjPytVHyJXGNOwo0dH0i0ez/Mx2Q2kStF+lmMKZE3+xdg8YtHu+lkqUIKdd4CbfISm0FsYtg+SqBU/fZDpBbNB4SiALBm2EpnADF+BioUf9ABw+mqKjNdK/vokfmg0sUSRu0XogA/1ZsPRjLUodagA9aXHQnM7VhuBcDWnGL42OWnNrq0pZ9HNTkhJlesMviUJPHahxFEL4KDrEb4GWec4DOArBtp0sFuxWrZPUgDEiXPQ3uVCM5fVupoEoHZuL526PzcJzh81rPxPE4EMSjafGb2ksZDdULvxOYo7GM+ITJ7a1KtjrdRYR1R0KtWA+KkhwYKGwvxn0Zw355pNSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9OManMhSnJ2ZpGth+OhcoCoUwpfPMcYjAJbIOD/AT0=; b=KzMNNUmu2lBbc8ueYmp5Be0pqiZoPs/NyrkVtMwJSYc5niBZXFLIoUM6HAhDbcx2cYji7bOfbQKRJm+y2I2FE2Hk6tAVdnQwc2FcqdjsRItM12HFMdBR4L4veG8voMMrXAx1Rt89n2gZiZu4SQtSWUU5O6XSH+dXRbrJxbwvWB2soaakTnQadKuwnS19OZjNk0LPVS6ZYYAyGoz42SK7dE+/f1PcZUwcIxAveI2S/f5Z44X2tv3GGr0XQVUw8n0JGq+wOrEao3LaQveWkKjE5o/QcoK2sAZEYt+e4uQ4txuF7dpYDxLqt/M0kdmpwEnC/+c4MEneeVYMz9eGxUGTig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9OManMhSnJ2ZpGth+OhcoCoUwpfPMcYjAJbIOD/AT0=; b=aWamxGIbFGWXns0rMOnTNP3LYA4XodROzSTz10lGdvWC+isHhw6uliuXsEbH9+DUKCFdDm7rIRDTtoZ6EYs7h2fjuxTpCWMslHxWFBgZvruBRsOLLv/fSTF/XXVGLCGUIXuIV+iSmFf9kccCICeGA6ST9X9I2pbLTXaSM5kKK7A= Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SN6PR11MB2608.namprd11.prod.outlook.com (2603:10b6:805:57::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Mon, 27 Jul 2020 10:44:58 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::851c:67fc:a034:9ea0]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::851c:67fc:a034:9ea0%4]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020 10:44:57 +0000 From: To: , Subject: Re: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery Thread-Topic: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery Thread-Index: AQHWRkS/OBUazr8JiUiilPsVNX+PNqj5l1gAgB3AVoCAABRggIAEDVcA Date: Mon, 27 Jul 2020 10:44:57 +0000 Message-ID: References: <20200619141904.910889-1-codrin.ciubotariu@microchip.com> <20200619141904.910889-2-codrin.ciubotariu@microchip.com> <20200705211918.GB1055@kunai> <20200724193913.GD1227@ninjato> <20200724205209.GC1551@shell.armlinux.org.uk> In-Reply-To: <20200724205209.GC1551@shell.armlinux.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: armlinux.org.uk; dkim=none (message not signed) header.d=none;armlinux.org.uk; dmarc=none action=none header.from=microchip.com; x-originating-ip: [84.232.220.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ccff93d-b5b3-4a24-de72-08d8321a1b31 x-ms-traffictypediagnostic: SN6PR11MB2608: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x/IyN5dl0U/M/3YWM5OCwH0zlwnHrDBe+y7oZHJY1+GeDUnBWTfSRdfb9QkjqHuaeT+Sdex2Ue7Bw41jBlDJx4SSLXm+Y0toBKAjv/lz4r2xC8FwyaHb4hmKaRiaf28OVaala4G1FzhYihhQfkUAofyc9cU2jXBTboEWdnGQHhzFdB5UlBbOa8oLRHei3iSOaOS/5hmRs1/A+9GI+qJhYmjLulwUjhK4Qu2hQBgl2eC8W68W9mJkusk5rGeTkwhw3AnxlwsXw6bqHJtszTqijS4QHKoxZ+ZKvWXAqwSb9pB0Oi2VcNcoFFqf+sO4nU0DHcMauRhLfqig00VssKn86TW60PihH/ce3TDzlmFk0C764nfGyBd4ZGOHFYTsTT/SzmOqg/nVe1v4kK7VJG/604ZDDRM6riTGNE8kZPuwgo4k5hDfOujYU9WCXeHybULS1ZKUZe4dI7pW1MNPbSQZ0gVRX12aAqrTjBgUWAoO1Js= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(39860400002)(136003)(376002)(346002)(396003)(83380400001)(478600001)(6486002)(5660300002)(91956017)(71200400001)(76116006)(64756008)(66556008)(66476007)(66446008)(66946007)(8936002)(966005)(2616005)(4326008)(186003)(53546011)(6512007)(31686004)(31696002)(36756003)(86362001)(2906002)(316002)(110136005)(54906003)(6506007)(26005)(8676002)(41533002)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: oqCQlYavvUDIbd7kipSn4bTnq7oGcHgvcUA7wx8Bm7o+E1u3eelRR6EqvZS2GpE5360QzII9Bef7DYrSl5nxS2ia7nMXiDk7SZwSD7xOBUJ5uKq3eGhItrB/erwjGh/DHvRbplXD9u3NeFmecNKQViouz7MdVmhxf9k3sEmx8byu5YVBBcb5uyOjq8XgY6JwPXhg6oOT9Qc7s3sQB01i5dZY8yd3SMcU+CsOq/D7BmxAqNstrXMBV9fXBjZDkqDIzdoP5Om8fU7UlQjVPNhPr7u9cA1erljO7ncwkuJw7qRJlrvbpTGq7YYFoIQgrO7nqXjN2B72TvLJ+ueU/EwgLcG7PPWYpg3wkFRQvLEJ71wYfWzu5Rk2J62hfB6tqsaMpxVuHAZjZoksJe2CmOZiUPAyU/d1PtQgjV4kXIe5+Ms8Wcl2tHLaXAcHm0tXLYoaDNW1+0mwp9TxrmwCE2m0PIC5elM/P8PCzXwvxLBWTB/pkofB/8nGByOrPcNSV2Vp Content-ID: <1EA0633CE3FF824EB793801932D1E19E@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ccff93d-b5b3-4a24-de72-08d8321a1b31 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 10:44:57.8327 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a5ti+wnmCrtad3YkUdKFyU1wsFAvx/vXpedoGk5NyeD2ZBRuGIG8VmhLosYiVmOuiydnHQdCeUl+HTvT5bUtjenjFiXI8egpW/Hed4E2UxE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2608 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_064504_361955_0196D672 X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, kamel.bouhara@bootlin.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24.07.2020 23:52, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Jul 24, 2020 at 09:39:13PM +0200, Wolfram Sang wrote: >> On Sun, Jul 05, 2020 at 11:19:18PM +0200, Wolfram Sang wrote: >>> >>>> +- pinctrl >>>> + add extra pinctrl to configure SCL/SDA pins to GPIO function for bus >>>> + recovery, call it "gpio" or "recovery" state >>> >>> I think we should stick with "gpio" only. That is what at91 and imx have >>> in their bindings. pxa uses "recovery" as a pinctrl state name but I >>> can't find any further use or documentation of that. PXA is not fully >>> converted to the best of my knowledge, so maybe it is no problem for PXA >>> to switch to "gpio", too? We should ask Russell King (cced). > > Fully converted to what? The generic handling where the i2c core layer > handles everything to do with recovery, including the switch between > modes? > > i2c-pxa _intentionally_ carefully handles the switch between i2c mode and > GPIO mode, and I don't see a generic driver doing that to avoid causing > any additional glitches on the bus. Given the use case that this recovery > is targetted at, avoiding glitches is very important to keep. Why is it not possbile to handle glitches in a generic way? I guess it depends on the pinctl, but we could treat a worst-case scenario to assure the switch between states is done properly. > >>> Russell, do you object naming the pinctrl state for bus recovery in >>> the pxa i2c driver from "recovery" to "gpio"? >> >> No response, so far. I suggest now to support the "recovery" naming but >> mark it as deprecated. Opinions? > > I don't have a preference on the exact naming. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel