From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41DBDC3DA42 for ; Wed, 10 Jul 2024 23:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject: References:In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2tc8RIIyfHOiaSxzCTfQKeyqP8HdT8b53uA/ghjOZWg=; b=XoaQCz/H14tliBvXV6dyII0O2s HDhp640DW766rusz7X2K4GUNC+kNhir6d4IS1Xb7NtCOsyDz+HfXtCmEkfVXvcC4zm7w5UoFuYlo/ X9AME/gd7jpuC5jBL6/JANy1svxdqSciIpLA1zb2C93Bp53DMCLqzyz3lerTj14oBtQQ7Xzr36L1d jYMARYp9PnnQLjOushkl13NpxCDDNPezLn9Mo+85eloLVLWw6tXgi4NrUSO0hfZO5Nl65KCu57e5c gHC9wPwLcq2fCmy+OHIu9hwBJKPGa6Hf0a3NCw8Ly4ekSteDK8HgxrhmnN5s1QakkilRBzHSbInQo tdKkLS7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRhBM-0000000CBpF-44ff; Wed, 10 Jul 2024 23:57:08 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRhB4-0000000CBl7-43TL; Wed, 10 Jul 2024 23:56:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3901DCE171C; Wed, 10 Jul 2024 23:56:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63FD9C32781; Wed, 10 Jul 2024 23:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720655808; bh=2tc8RIIyfHOiaSxzCTfQKeyqP8HdT8b53uA/ghjOZWg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=fAM7wnhekV4nm0zqMszEdt5ToIwVrIMloMD303uJBTeDCflfCUZkQmRHxSUd+8Vda tS8rIyA3sIc6/9uLhyZVsMlO295+nC9Mr0a1ZHOT2kRua0kmkZvVf2x9cE/JJnQuDO sR/+bjAIBXl4ALv+wBUETS8lnrtgij+RjLLlnNsoIZO68tc6rKl3EeNPS4JOsB0Lwt 6VPrXmMMZ0pO6Fw4nKzQbUXcotOuf3CUkT1HkR5rNI3M6fvYsQAyYD+o8bfykkY7Qu GKO5yEXfoTNlCGr16m/9thGN+UThWRgOX8yf2c4Tir6myf71DaCsxmbGIsZTG/hrGC pDAyn21p2eI/g== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1903511.1xdlsreqCQ@diego> References: <20240709123121.1452394-1-heiko@sntech.de> <20240709123121.1452394-2-heiko@sntech.de> <2e5852b9e94b9a8d0261ce7ad79f4329.sboyd@kernel.org> <1903511.1xdlsreqCQ@diego> Subject: Re: Re: [PATCH 1/6] dt-bindings: clocks: add binding for generic clock-generators From: Stephen Boyd Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, quentin.schulz@cherry.de, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org To: Heiko =?utf-8?q?St=C3=BCbner?= , mturquette@baylibre.com Date: Wed, 10 Jul 2024 16:56:46 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_165651_201178_CFFA8DFF X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Heiko St=C3=BCbner (2024-07-10 01:02:57) > Am Dienstag, 9. Juli 2024, 23:45:20 CEST schrieb Stephen Boyd: > > Quoting Heiko Stuebner (2024-07-09 05:31:16) > > > diff --git a/Documentation/devicetree/bindings/clock/clock-generator.= yaml b/Documentation/devicetree/bindings/clock/clock-generator.yaml > > > new file mode 100644 > > > index 0000000000000..f44e61e414e89 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/clock/clock-generator.yaml > > > @@ -0,0 +1,62 @@ [...] >=20 >=20 > > Maybe instead of creating a generic binding just make a binding for > > these diodes parts? It certainly looks like a generic binding could come > > later when another vendor supports the same binding. >=20 > I was actually primarily aiming at solving the Rock 5 ITX clock generator > issue described in patch 5, where the 100 MHz clock generator is just > described as "100MHz,3.3V,3225" in the schematics, but definitly needs > the supply regulator to be enabled [1]. That looks like a VCO (voltage controlled oscillator). Maybe the compatible string can be "voltage-oscillator" or "clock-vco" and it can require the vdd-supply. Those diodes parts look different. They look like PLLs that have a reference clock, hence the 'clocks' property I was expecting to see. That would use the VCO you have to make the PCIE reference clk frequencies. A generic compatible for those diodes parts is likely "phase-locked-loop", or "clock-pll", but I'd avoid that given that PLLs are almost always complicated and can have multiple output frequencies if they have post and pre-dividers, etc. It's easier to be specific here and make a binding for the part you have.