From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yu-Chun Lin <eleanor15x@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
james.tai@realtek.com, soc@lists.linux.dev
Cc: afaerber@suse.de, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-realtek-soc@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
cy.huang@realtek.com, stanley_chang@realtek.com,
eleanor.lin@realtek.com
Subject: Re: [PATCH RESEND v3 2/2] arm64: dts: realtek: Add Kent SoC and EVB device trees
Date: Wed, 28 Jan 2026 19:41:50 +0100 [thread overview]
Message-ID: <b3df3e1d-0aa7-4161-a7ae-0a2dfbd34cd5@kernel.org> (raw)
In-Reply-To: <20260127071530.25426-3-eleanor15x@gmail.com>
On 27/01/2026 08:14, Yu-Chun Lin wrote:
> +
> + reserved_memory: reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
Earlier (I removed it from the context) nodes are not ordered according
to DTS coding style.
> +
> + linux,cma {
> + compatible = "shared-dma-pool";
> + alignment = <0x0 0x400000>;
> + alloc-ranges = <0x0 0x0 0x0 0x20000000>;
> + size = <0x0 0x2000000>;
> + reusable;
> + linux,cma-default;
> + };
> + };
> +
> + cpu_opps: opp-table-cpu {
It is odd to see this on the board level. This really is SoC or (in your
case) SoC variant layer.
Same for other DTSI.
These two issues however are not critical and I did not see other
worrying things, so I would merge it.
Arnd:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-01-28 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 7:13 [PATCH RESEND v3 0/2] arm64: dts: Add support for Kent SoC family Yu-Chun Lin
2026-01-27 7:14 ` [PATCH RESEND v3 1/2] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin
2026-01-28 18:35 ` Krzysztof Kozlowski
2026-01-27 7:14 ` [PATCH RESEND v3 2/2] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin
2026-01-28 18:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3df3e1d-0aa7-4161-a7ae-0a2dfbd34cd5@kernel.org \
--to=krzk@kernel.org \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=cy.huang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=eleanor.lin@realtek.com \
--cc=eleanor15x@gmail.com \
--cc=james.tai@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=robh@kernel.org \
--cc=soc@lists.linux.dev \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox