From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE608C433EF for ; Mon, 20 Jun 2022 13:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2rGnyue+ZhCtAEwQK9rl6mtlfw4lp5Sal/jOafXvriI=; b=i5FyaTHyezfEMw AlM/BJU0DbMoB5lvs7mAjTjYUhjKVUEvO6wjbU5FHgHGKYXBEyjdJ0YFJsuaBwV6+W/zn5wJsjLNd VnIwmIkPezNUpK0GBNR1Wfv4q0IWgXQuG2kEwChPLLuU4ihNerYHRC+akg14OPJbMIjTz/FSGuYgD C2bg2t22jt3FLrzpT4bYSLI0Nv0siJU3SKqnr4vf5Lk7hZOMnjO/7B5kr95h4mExJ8zsFCsJnSyll bZCDrEO5b0ZLgUZKQdFJXmiVSnAM7a3MUSLriLTvABEJ0ffuhJvSK4sNGyNQ53RVwB51vnMW893Zm wV/hlJboFvNXmzHNCwtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3HN7-000ntm-4M; Mon, 20 Jun 2022 13:23:18 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3GxO-000bMN-8q for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2022 12:56:44 +0000 Received: by mail-ej1-x634.google.com with SMTP id v1so20889672ejg.13 for ; Mon, 20 Jun 2022 05:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=h3Tl1NcyyBUWJ2hHdmOi/Ijf7c9vRxpUfpu/sNPMip0=; b=L/a+blQMKJ0CtjtTkyZsQV8mZ9nBiyrM0wdEwFTgm1g9+bNjfOUsuqa4hfYy25H4Su CrEGNcLWNROSbOjP950Cv/bHAwylQVKT2hbbdgmq0CRPZdWDIKTESY4DiTaBTaqSR8Ba MHcDwv0495ZgqFzrjTcCnqdeE4PSOKLjXoXkSo4Q808FhPz9TGdHsG4x0qGP8nXUD/Zl +DzUh7shBy7R5aMQGAVx043OJFbNIa7to12Skiof61OdV+8xhHZLFh6PjDxhvTrv220f XJyoQvVXVaLdPTvBZnIHccivBtK1KArdEMV+A1mOwWzM2YjLyk97Eyc1ruGcDtoRe8Fb hd5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=h3Tl1NcyyBUWJ2hHdmOi/Ijf7c9vRxpUfpu/sNPMip0=; b=A5csdi1JkPceiyzIMLheaJNKZ+8lyAtQgOGn8Fopj3EWdPvOESxT4vB3xhsMexULFo m6WNS2xjMQef909OR0O6mYWJ+LYwAckOZH9hG2UQNdiwnQX7vpEmeLe00Q8coYIil5Lw AIqlPTYYEIR5OfC5TySnmOW018j1zz+R9lbHplJA854jqufiUnTUK7Br6pY2iDdlnE9V ULlKeaMEzYeNYyE6K1geRo4c7Q6vgQ9nkMNdYcP40VZc03vfcjMTRVQgNZvANA92VImY MM34v6aIki6yE2vti/q1hol0ZKFggTNT2KJjQ2amjnxykXpJveXh51HEhaHAVA6RozDL qygA== X-Gm-Message-State: AJIora/dgPY8zxMQrHHZ1EP4pzduOIlGGmhX0P0TqqKwtHrAiD4xZu5T fru2JGjXxlTLei4Ufh5w71pF2w== X-Google-Smtp-Source: AGRyM1u/8SxdA92Z860M9UR7l1Kg2/zV6W837GoE6rMQOgOO+jYLeQhNPSn5HkrZgk422GiqUnGnEQ== X-Received: by 2002:a17:906:7053:b0:711:b90e:47b7 with SMTP id r19-20020a170906705300b00711b90e47b7mr20354864ejj.652.1655729800692; Mon, 20 Jun 2022 05:56:40 -0700 (PDT) Received: from [192.168.0.210] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id b23-20020aa7df97000000b004357ab9cfb1sm3830386edy.26.2022.06.20.05.56.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 05:56:40 -0700 (PDT) Message-ID: Date: Mon, 20 Jun 2022 14:56:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 06/15] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, blarson@amd.com, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, fancer.lancer@gmail.com, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, ulf.hansson@linaro.org, will@kernel.org, devicetree@vger.kernel.org References: <20220613195658.5607-1-brad@pensando.io> <20220613195658.5607-7-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220613195658.5607-7-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_055642_458294_50DF1286 X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/06/2022 21:56, Brad Larson wrote: > From: Brad Larson > > Add support for the AMD Pensando Elba SoC System Resource chip > using the SPI interface. The Elba SR is a Multi-function Device > supporting device register access using CS0, smbus interface for > FRU and board peripherals using CS1, dual Lattice I2C masters for > transceiver management using CS2, and CS3 for flash access. > > Signed-off-by: Brad Larson > --- > .../bindings/mfd/amd,pensando-elbasr.yaml | 93 +++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml b/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml > new file mode 100644 > index 000000000000..13356800b1cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/amd,pensando-elbasr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMD Pensando Elba SoC Resource Controller bindings > + > +description: | > + AMD Pensando Elba SoC Resource Controller bindings attached to a SPI bus. > + > +maintainers: > + - Brad Larson > + > +properties: > + compatible: > + items: > + - enum: > + - amd,pensando-elbasr > + - const: simple-mfd > + > + spi-max-frequency: > + description: Maximum SPI frequency of the device in Hz. > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + > +patternProperties: > + '^reset-controller@[a-f0-9]+$': > + $ref: ../reset/amd,pensando-elbasr-reset.yaml > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + spi0 { Just "spi" > + #address-cells = <1>; > + #size-cells = <0>; > + num-cs = <4>; > + > + spi@0 { "spi" is for SPI controllers. Use generic name matching the device. Usually this is "system-controller", however Rob pointed out your inaccurate bindings and example. > + compatible = "amd,pensando-elbasr", "simple-mfd"; > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + spi-max-frequency = <12000000>; > + > + rstc: reset-controller@0 { > + compatible = "amd,pensando-elbasr-reset"; > + reg = <0>; > + #reset-cells = <1>; > + }; > + }; > + > + spi@1 { > + compatible = "amd,pensando-elbasr", "simple-mfd"; > + reg = <1>; > + spi-max-frequency = <12000000>; > + }; > + > + spi@2 { > + compatible = "amd,pensando-elbasr", "simple-mfd"; > + reg = <2>; > + spi-max-frequency = <12000000>; > + interrupt-parent = <&porta>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + }; > + > + spi@3 { > + compatible = "amd,pensando-elbasr", "simple-mfd"; > + reg = <3>; > + spi-max-frequency = <12000000>; > + }; > + }; > + > +... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel