linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Define wfi(), wfe(), sev() macros for pre-v7 processors
Date: Tue, 8 Feb 2011 14:10:49 +0530	[thread overview]
Message-ID: <b462b6fdb4265f13d0cd87d13df3c530@mail.gmail.com> (raw)
In-Reply-To: <1296829243-21313-1-git-send-email-dave.martin@linaro.org>

Dave,
> -----Original Message-----
> From: Dave Martin [mailto:dave.martin at linaro.org]
> Sent: Friday, February 04, 2011 7:51 PM
> To: linux-arm-kernel at lists.infradead.org
> Cc: Dave Martin; Tony Lindgren; Santosh Shilimkar; Jean Pihet;
> linux-omap at vger.kernel.org; Nicolas Pitre; Russell King
> Subject: [PATCH] ARM: Define wfi(), wfe(), sev() macros for pre-v7
> processors
>
> Pre-v7 processors don't have wfe/sev, so these are defined for
> consistency as empty barrier asms.
>
> For v6, wfi is architected as a defined MCR instruction, so
> use that definition.
>
> Doing a no-op instead of wfi() is probably bad, so for older
> processors than v6, wfi() is not defined.  If needed, some CPU-
> specific wfi() will have to be defined elsewhere.
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
> ---
>  arch/arm/include/asm/system.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/system.h
> b/arch/arm/include/asm/system.h
> index 97f6d60..0e1cae3 100644
> --- a/arch/arm/include/asm/system.h
> +++ b/arch/arm/include/asm/system.h
> @@ -129,7 +129,14 @@ extern unsigned int user_debug;
>  #define sev()	__asm__ __volatile__ ("sev" : : : "memory")
>  #define wfe()	__asm__ __volatile__ ("wfe" : : : "memory")
>  #define wfi()	__asm__ __volatile__ ("wfi" : : : "memory")
> +#else /* __LINUX_ARM_ARCH__ < 7 */
> +#define sev()	__asm__ __volatile__ ("" : : : "memory")
> +#define wfe()	__asm__ __volatile__ ("" : : : "memory")
This is not true for "CPU_32v6K" extensions, right. I think they do
support 'sev' and 'wfe' instructions.


> +#if __LINUX_ARM_ARCH__ == 6
> +#define wfi()	__asm__ __volatile__ ("mcr p15, 0, %0, c7, c5, 4"
> \
> +					: : "r" (0) : "memory")
>  #endif
> +#endif /* __LINUX_ARM_ARCH__ < 7 */
>
>  #if __LINUX_ARM_ARCH__ >= 7
>  #define isb() __asm__ __volatile__ ("isb" : : : "memory")
> --
> 1.7.1

  reply	other threads:[~2011-02-08  8:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04 14:20 [PATCH] ARM: Define wfi(), wfe(), sev() macros for pre-v7 processors Dave Martin
2011-02-08  8:40 ` Santosh Shilimkar [this message]
2011-02-08  8:45 ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b462b6fdb4265f13d0cd87d13df3c530@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).