From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616C2C10F05 for ; Tue, 26 Mar 2019 04:12:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 347ED2070B for ; Tue, 26 Mar 2019 04:12:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hCjAzYpJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 347ED2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m2JidhR3RCLSIVz3ITPbzztOsmxLcH38nNeYrq9L+AU=; b=hCjAzYpJDaGwbk6wZIsxnhx8+ jNZDPFouYayVjk4VJsM47IqRrvihZs8BYGrV2UsnSIUsuiBxbVS6IDe7DeO350/R++mdXGJFsksFP SkSoZay9tSyc3g16ry9Rk+Z22pGYDUHtqHoPDam7DleAT2qIDPRG7ywZrJ3zxqYqg0qzN+kO7CoUt OwZ8Rq9R38J5PhUbA+20WCuC5jzDU/6yQT6xyb6zGQvhG056OXOuW/xLw9XBYqWAs0Ho9vswRkAr8 1m+ZcIgkXR8QBQGbENRgUucPUuNk4W7JVSc7ldBo5OgGW3YK0bOcUDmOyPHdWH7mJKr9ZyqXOulSj 9tqxVdYlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8dRc-00040A-98; Tue, 26 Mar 2019 04:12:12 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8dRZ-0003zl-DO for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 04:12:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3586A80D; Mon, 25 Mar 2019 21:12:07 -0700 (PDT) Received: from [10.162.0.144] (a075553-lin.blr.arm.com [10.162.0.144]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6DF593F59C; Mon, 25 Mar 2019 21:12:03 -0700 (PDT) Subject: Re: [PATCH v7 8/10] KVM: arm64: Add capability to advertise ptrauth for guest To: Kristina Martsenko , linux-arm-kernel@lists.infradead.org References: <1552984243-7689-1-git-send-email-amit.kachhap@arm.com> <1552984243-7689-9-git-send-email-amit.kachhap@arm.com> <1ea6ab95-a52e-3f14-a514-b0b747b85f3a@arm.com> From: Amit Daniel Kachhap Message-ID: Date: Tue, 26 Mar 2019 09:42:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1ea6ab95-a52e-3f14-a514-b0b747b85f3a@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_211209_458831_67914738 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Jones , Julien Thierry , Marc Zyngier , Catalin Marinas , Will Deacon , Christoffer Dall , kvmarm@lists.cs.columbia.edu, James Morse , Ramana Radhakrishnan , Dave Martin , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 3/26/19 1:35 AM, Kristina Martsenko wrote: > On 19/03/2019 08:30, Amit Daniel Kachhap wrote: >> This patch advertises the capability of pointer authentication >> when system supports pointer authentication and VHE mode present. >> >> Signed-off-by: Amit Daniel Kachhap >> Cc: Mark Rutland >> Cc: Marc Zyngier >> Cc: Christoffer Dall >> Cc: kvmarm@lists.cs.columbia.edu >> --- >> arch/arm64/kvm/reset.c | 4 ++++ >> include/uapi/linux/kvm.h | 1 + >> 2 files changed, 5 insertions(+) >> >> diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c >> index 00f0639..a3b269e 100644 >> --- a/arch/arm64/kvm/reset.c >> +++ b/arch/arm64/kvm/reset.c >> @@ -92,6 +92,10 @@ int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext) >> case KVM_CAP_ARM_VM_IPA_SIZE: >> r = kvm_ipa_limit; >> break; >> + case KVM_CAP_ARM_PTRAUTH: >> + r = has_vhe() && system_supports_address_auth() && >> + system_supports_generic_auth(); >> + break; >> default: >> r = 0; >> } >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> index 6d4ea4b..a553477 100644 >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h >> @@ -988,6 +988,7 @@ struct kvm_ppc_resize_hpt { >> #define KVM_CAP_ARM_VM_IPA_SIZE 165 >> #define KVM_CAP_MANUAL_DIRTY_LOG_PROTECT 166 >> #define KVM_CAP_HYPERV_CPUID 167 >> +#define KVM_CAP_ARM_PTRAUTH 168 > > Since we now have two separate vcpu flags, then I think we also need two > capabilities here (one for address auth and one for generic auth). This > will allow us to support the features separately in the future if we > need to. I have no objection to your suggestion. Infact all other KVM_ARM_VCPU_* features have there own capability defined. I will check other architectures if they define separate capability for major/minor features. Thanks, Amit D > > Thanks, > Kristina > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel