From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8C1DC4345F for ; Thu, 25 Apr 2024 05:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=soRCyjyv7ZRuroOXGcvX9IXVDCcfT6J3Tz/3eeEyqgM=; b=I60XczWHy6jOEB Cu9NXM7Im03R1V52fDE8btxBC/VfRuDov4j+1f4nzNSOdkqMSiCNmtirNHPPJFxFnThs3f7LOW9yL FS+2W3fiV8R7pMDRg+Lsbx1+9MLCD8gBs6DfBra4v/Hc0y+6gtQDtLxNq4EKWYrZIIhxfkMvipNEp SrxvL3+aTHhBeh6b2di9nK51XvDOzgPnZzb1QkAUBp4SvaZYgRDmSpJqyRhuvN9DO/6jQ8qv/clYM rNJRx0lyIO5h7gQl5Kqd4LnvuK/UHu6UZRrXdvPEmV+H75oaIngr+04yEtvawvY66t20FkoBJpbTP 0VcHiSTCU7Kh9vPPWarw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzrhp-000000071AH-223J; Thu, 25 Apr 2024 05:31:37 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzrhl-0000000719k-1Scu for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 05:31:35 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-41b34d344a0so4634845e9.3 for ; Wed, 24 Apr 2024 22:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714023091; x=1714627891; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=cMmQUcIVgSzWuW2ZWEiFPzqJ+do6tt+UV73InjD+R7U=; b=Oou5X5AXpeQpYVQR/lg+BB4riE26OS0DFgwJdcsf96mRhxpAzLpK6H25tebbv6bHOK O9TsZiXKdPk0LUK36J94uxw/EdtgNFMOhibS56cmgF4mKTOUJCyvd1o+7SSFSOQqu8W1 EuxY9lDuYpWYyC8XPeM1mPcM1QMU1xmAynt5GLHcEsqtDOSWsqqsLNhupqhujqdlHyFO TR2FT15ZsQ1ntvsSuqYfCAb09v/EZTMXsai3KsbdI0mbjuR9BlMo0upMrQGw4U7syURT QuQSPEW0P5Vgx69oOJpTY89UNBH+we5UMoFclOtU/LQrhowIJQKZ2SrMAHXNUFgePsa2 rFpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714023091; x=1714627891; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cMmQUcIVgSzWuW2ZWEiFPzqJ+do6tt+UV73InjD+R7U=; b=QqgvOdum4srI9t3zqn8k8L5ChRyEgY/+Qo7zFGtoJjw4HEpt8fz1xi2EnwrxavPJnj yQphyYLW5omhr7AKXjGkRsGQRovQX9ZXhg4hgiW4l4XwxeYOx2MdOhtl0AR6AV57Vj5X SPDTvwMx1/nNJweZ0ZQcT3VSPl7BcNsHW25ysJ4fGt347lIZKAugpRkkwHUV0u7fz8Ej bLlljLQj2xq5EOajMBq7GfUIBKOKhANlgVX5DFlx5EyPlR7+DuDdFr38kRJvvW/+7A8j y+BaFOsr8e4gIuegyrBa7eRT6kjWTU2lhcpgMQZG91CPHgQxSjNP+EgxadXW8p92b63D vc1Q== X-Forwarded-Encrypted: i=1; AJvYcCUvkBEYZlLrMkv6PV2fiF3Xy3U2Cm8zK3zVIO7l3uepNm77SMG73N6duF5LDwiBUfpD0yEliIjqkWhxvsN7+w/EUyy5FayzKXmxbs9fCiEQs6og3bM= X-Gm-Message-State: AOJu0YzPLJ01K1wwt+x1+XRPDKKMEegFIwkIrleLcEOsYrcWj3zLnWTA Wb13X/ZQM6/oztn5MQ4uPLvjTE6TNGzZK6GzmUPobeHx1wos9dxpFWQO5LIKcEc= X-Google-Smtp-Source: AGHT+IGnkVtA5Wtwo7q3DYXIHysN+Cu0EJxSPiMeca2h/hO/A4Gzv4GhNLke0XTi2A49j9T/1rc+tw== X-Received: by 2002:a05:600c:4f8f:b0:418:58ac:7477 with SMTP id n15-20020a05600c4f8f00b0041858ac7477mr3171421wmq.30.1714023090830; Wed, 24 Apr 2024 22:31:30 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id fj3-20020a05600c0c8300b00416b2cbad06sm29941718wmb.41.2024.04.24.22.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 22:31:30 -0700 (PDT) Date: Thu, 25 Apr 2024 08:31:26 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Aren Moynihan , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Aren Moynihan , Andy Shevchenko , Ondrej Jirman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend Message-ID: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240423223309.1468198-4-aren@peacevolution.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_223133_463451_64286180 X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Aren, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Aren-Moynihan/dt-bin= dings-iio-light-stk33xx-add-vdd-and-leda-regulators/20240424-064250 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg patch link: https://lore.kernel.org/r/20240423223309.1468198-4-aren%40pe= acevolution.org patch subject: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and= power it off during suspend config: i386-randconfig-141-20240424 (https://download.01.org/0day-ci/archi= ve/20240425/202404251021.4OPER3OS-lkp@intel.com/config) compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new versio= n of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202404251021.4OPER3OS-lkp@intel.com/ smatch warnings: drivers/iio/light/stk3310.c:615 stk3310_probe() error: uninitialized symbol= 'ret'. vim +/ret +615 drivers/iio/light/stk3310.c 9046d80dce04c6 Uwe Kleine-K=F6nig 2022-11-18 592 static int stk3310_probe= (struct i2c_client *client) be9e6229d67696 Tiberiu Breana 2015-04-27 593 { be9e6229d67696 Tiberiu Breana 2015-04-27 594 int ret; be9e6229d67696 Tiberiu Breana 2015-04-27 595 struct iio_dev *indio_dev; be9e6229d67696 Tiberiu Breana 2015-04-27 596 struct stk3310_data *data; be9e6229d67696 Tiberiu Breana 2015-04-27 597 = be9e6229d67696 Tiberiu Breana 2015-04-27 598 indio_dev =3D devm_iio_de= vice_alloc(&client->dev, sizeof(*data)); be9e6229d67696 Tiberiu Breana 2015-04-27 599 if (!indio_dev) { be9e6229d67696 Tiberiu Breana 2015-04-27 600 dev_err(&client->dev, "i= io allocation failed!\n"); be9e6229d67696 Tiberiu Breana 2015-04-27 601 return -ENOMEM; be9e6229d67696 Tiberiu Breana 2015-04-27 602 } be9e6229d67696 Tiberiu Breana 2015-04-27 603 = be9e6229d67696 Tiberiu Breana 2015-04-27 604 data =3D iio_priv(indio_d= ev); be9e6229d67696 Tiberiu Breana 2015-04-27 605 data->client =3D client; be9e6229d67696 Tiberiu Breana 2015-04-27 606 i2c_set_clientdata(client= , indio_dev); d6ecb01583d4e0 Arnaud Ferraris 2022-04-20 607 = d6ecb01583d4e0 Arnaud Ferraris 2022-04-20 608 device_property_read_u32(= &client->dev, "proximity-near-level", d6ecb01583d4e0 Arnaud Ferraris 2022-04-20 609 &data->ps_near_level); d6ecb01583d4e0 Arnaud Ferraris 2022-04-20 610 = be9e6229d67696 Tiberiu Breana 2015-04-27 611 mutex_init(&data->lock); be9e6229d67696 Tiberiu Breana 2015-04-27 612 = dd231c1d219f6b Ondrej Jirman 2024-04-23 613 data->vdd_reg =3D devm_re= gulator_get(&client->dev, "vdd"); dd231c1d219f6b Ondrej Jirman 2024-04-23 614 if (IS_ERR(data->vdd_reg)) dd231c1d219f6b Ondrej Jirman 2024-04-23 @615 return dev_err_probe(&cl= ient->dev, ret, "get regulator vdd failed\n"); s/ret/PTR_ERR(data->vdd_reg)/ dd231c1d219f6b Ondrej Jirman 2024-04-23 616 = be9e6229d67696 Tiberiu Breana 2015-04-27 617 ret =3D stk3310_regmap_in= it(data); be9e6229d67696 Tiberiu Breana 2015-04-27 618 if (ret < 0) be9e6229d67696 Tiberiu Breana 2015-04-27 619 return ret; be9e6229d67696 Tiberiu Breana 2015-04-27 620 = be9e6229d67696 Tiberiu Breana 2015-04-27 621 indio_dev->info =3D &stk3= 310_info; be9e6229d67696 Tiberiu Breana 2015-04-27 622 indio_dev->name =3D STK33= 10_DRIVER_NAME; be9e6229d67696 Tiberiu Breana 2015-04-27 623 indio_dev->modes =3D INDI= O_DIRECT_MODE; be9e6229d67696 Tiberiu Breana 2015-04-27 624 indio_dev->channels =3D s= tk3310_channels; be9e6229d67696 Tiberiu Breana 2015-04-27 625 indio_dev->num_channels = =3D ARRAY_SIZE(stk3310_channels); be9e6229d67696 Tiberiu Breana 2015-04-27 626 = dd231c1d219f6b Ondrej Jirman 2024-04-23 627 ret =3D regulator_enable(= data->vdd_reg); dd231c1d219f6b Ondrej Jirman 2024-04-23 628 if (ret) dd231c1d219f6b Ondrej Jirman 2024-04-23 629 return dev_err_probe(&cl= ient->dev, ret, dd231c1d219f6b Ondrej Jirman 2024-04-23 630 "regulator vdd en= able failed\n"); dd231c1d219f6b Ondrej Jirman 2024-04-23 631 = dd231c1d219f6b Ondrej Jirman 2024-04-23 632 /* we need a short delay = to allow the chip time to power on */ dd231c1d219f6b Ondrej Jirman 2024-04-23 633 fsleep(1000); dd231c1d219f6b Ondrej Jirman 2024-04-23 634 = be9e6229d67696 Tiberiu Breana 2015-04-27 635 ret =3D stk3310_init(indi= o_dev); be9e6229d67696 Tiberiu Breana 2015-04-27 636 if (ret < 0) dd231c1d219f6b Ondrej Jirman 2024-04-23 637 goto err_vdd_disable; be9e6229d67696 Tiberiu Breana 2015-04-27 638 = 6839c1b0700a79 Octavian Purdila 2015-09-23 639 if (client->irq > 0) { 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 640 ret =3D devm_request_thr= eaded_irq(&client->dev, client->irq, 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 641 stk3310_irq_handler, 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 642 stk3310_irq_event_ha= ndler, 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 643 IRQF_TRIGGER_FALLING= | 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 644 IRQF_ONESHOT, 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 645 STK3310_EVENT, indio= _dev); 7c7a9eeaa335df Hartmut Knaack 2015-07-09 646 if (ret < 0) { 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 647 dev_err(&client->dev, "= request irq %d failed\n", 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 648 client->irq); 7c7a9eeaa335df Hartmut Knaack 2015-07-09 649 goto err_standby; 7c7a9eeaa335df Hartmut Knaack 2015-07-09 650 } 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 651 } 3dd477acbdd1f1 Tiberiu Breana 2015-04-27 652 = 037e966f2d6389 Hartmut Knaack 2015-07-09 653 ret =3D iio_device_regist= er(indio_dev); 037e966f2d6389 Hartmut Knaack 2015-07-09 654 if (ret < 0) { 037e966f2d6389 Hartmut Knaack 2015-07-09 655 dev_err(&client->dev, "d= evice_register failed\n"); 7c7a9eeaa335df Hartmut Knaack 2015-07-09 656 goto err_standby; 037e966f2d6389 Hartmut Knaack 2015-07-09 657 } 037e966f2d6389 Hartmut Knaack 2015-07-09 658 = 7c7a9eeaa335df Hartmut Knaack 2015-07-09 659 return 0; 7c7a9eeaa335df Hartmut Knaack 2015-07-09 660 = 7c7a9eeaa335df Hartmut Knaack 2015-07-09 661 err_standby: 7c7a9eeaa335df Hartmut Knaack 2015-07-09 662 stk3310_set_state(data, S= TK3310_STATE_STANDBY); dd231c1d219f6b Ondrej Jirman 2024-04-23 663 err_vdd_disable: dd231c1d219f6b Ondrej Jirman 2024-04-23 664 regulator_disable(data->v= dd_reg); be9e6229d67696 Tiberiu Breana 2015-04-27 665 return ret; be9e6229d67696 Tiberiu Breana 2015-04-27 666 } -- = 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel