From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F05D6ECE579 for ; Mon, 9 Sep 2024 09:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/quyWb8vumcbT1XTiobNYayKAU49ZoNqv4TkV+Bl12Y=; b=lfZesldP6xGacxCHvkprBsMFpY iP39m55sQLtv7X02eH6XuK8bZ8V0QOKUHkKihBNr2s/sR9EwBizvANte3NYY8tpI18y4kzjPJXCs2 eySdHD/HVyezfySRKVHf222PShyglNCAVxbNgTPSSYRb29zuhz2mVsA8PRlfUvspPFn23S24FU55d ejsUQ4RXBGuIIqPWR1YEAXvwi45p/x15L38UVVk8Y0O2NSYgFA9QdgIUz9zZBLpplepndGvwsWRkw 6HBGgV5r0nVTsE8eCt0wOQiAHXtjHmgOJhry5zSxZU4YVgkyU0CxSvnWonFacCGXiSIMAN9Tb6q3n JtZ8odNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snaN8-00000001EUM-40AO; Mon, 09 Sep 2024 09:07:46 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snaKA-00000001E4w-00h9 for linux-arm-kernel@lists.infradead.org; Mon, 09 Sep 2024 09:04:43 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-374c4c6cb29so3699004f8f.3 for ; Mon, 09 Sep 2024 02:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725872680; x=1726477480; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=/quyWb8vumcbT1XTiobNYayKAU49ZoNqv4TkV+Bl12Y=; b=IJVolDTby7cpHWG3LjOstjMhyZtG7GGk20ZPXRIOlwYtJDOu7m38pQQMBWxABeeFpl gQNtuGK/JGsS9ukmRLnJTo14d2TeCm3OY7+6CmcHo20FvLxvXd2t8oJp4My3F+p9+7hD JpE1SldDtN3k8i9tWHN3KWnYC0PmbyupHH3DmCC49F87nnE/o8N3+EPoY20d/tmFNYXM mztHOjmqBkJ1WFtq0+oDBwBOhB7hpyKMqoBJF9GDSffbrGeL0VGJCPAw7eTJYNlAEWFL 3F0Al0x3d0Ym48t+qbmTNdQzjwVmQfDiN1YUf5xMduLzVTF+OKnHcR473L4/Mdll4ddP UkrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725872680; x=1726477480; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/quyWb8vumcbT1XTiobNYayKAU49ZoNqv4TkV+Bl12Y=; b=UN7YRydy/8jMcGHBvsiwqhx+h++d98fMeHV8aA1l2dhmI5YilPIMVhV8tTkQ1yp/vI NnB8NID2y6OM3j52TFOPBXcbEctz9pMxTs50MUGX2FyQaui3isTJzkDYslhmRMk0D5Uu JBFlayKhDeu7LCU5VNFUzfzjWUJ4Ow0NnrxrDeOU4mL3h9r3Hk4b6CMufjmZVjbs+K3N YLVw6/3k4f8Qevk0Frjyzra8eJHxPkv8DHS32/xTHArNMR/UDgJpl30UWHvmuTNWaCz/ M9gL3E9P6jevRxXTtVDo47g0rCLHVRGOHIXhR+SRYaPDe9duAKwDjPkF54OJtKM1eq6W u72Q== X-Forwarded-Encrypted: i=1; AJvYcCV6ks6Fsvcwpfyo9s35Zk/dGvYI22q/ET7BWEn1TXoG7wRQXwPImOmaM8PoS6Ckbbw2NJIqqwPDLBkPC+8GWdmU@lists.infradead.org X-Gm-Message-State: AOJu0Yy6iGrsT3hQRcIg8eF5qlEuUgr4jWg629Ul/pFktSSPrgT6ErGk Ep2hIRPVknEpDSizAweW4DXapor6VeM3JFHPGKOCWlFRw+k5KOKoLZKF7JkdNPI= X-Google-Smtp-Source: AGHT+IHPyFzNJJ9CK/CbxvRhF0zXZqmiSax9i+YVPGOKwyfg6lpCSe5AQQrFB9PmBhsPgB8jUkq+yA== X-Received: by 2002:a5d:5081:0:b0:374:c9f0:7533 with SMTP id ffacd0b85a97d-3789243fbb9mr5688124f8f.41.1725872679665; Mon, 09 Sep 2024 02:04:39 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:63a3:6883:a358:b850? ([2a01:e0a:982:cbb0:63a3:6883:a358:b850]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37895675c40sm5467200f8f.51.2024.09.09.02.04.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2024 02:04:39 -0700 (PDT) Message-ID: Date: Mon, 9 Sep 2024 11:04:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 1/5] drm/meson: drop unused staitc dw_hdmi_dwc_write_bits To: Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Stefan Agner , Alison Wang , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Jagan Teki , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20240908-regmap-config-const-v1-0-28f349004811@linaro.org> <20240908-regmap-config-const-v1-1-28f349004811@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240908-regmap-config-const-v1-1-28f349004811@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240909_020442_078046_1D6B283B X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/09/2024 16:21, Krzysztof Kozlowski wrote: > static inline dw_hdmi_dwc_write_bits() function is not used at all: > > drivers/gpu/drm/meson/meson_dw_hdmi.c:276:20: error: unused function 'dw_hdmi_dwc_write_bits' [-Werror,-Wunused-function] > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 5565f7777529..b75db829b1da 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -272,20 +272,6 @@ static inline void dw_hdmi_g12a_dwc_write(struct meson_dw_hdmi *dw_hdmi, > writeb(data, dw_hdmi->hdmitx + addr); > } > > -/* Helper to change specific bits in controller registers */ > -static inline void dw_hdmi_dwc_write_bits(struct meson_dw_hdmi *dw_hdmi, > - unsigned int addr, > - unsigned int mask, > - unsigned int val) > -{ > - unsigned int data = dw_hdmi->data->dwc_read(dw_hdmi, addr); > - > - data &= ~mask; > - data |= val; > - > - dw_hdmi->data->dwc_write(dw_hdmi, addr, data); > -} > - > /* Bridge */ > > /* Setup PHY bandwidth modes */ > Reviewed-by: Neil Armstrong