From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AC7C433E0 for ; Fri, 19 Feb 2021 16:39:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7BA564DF0 for ; Fri, 19 Feb 2021 16:39:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7BA564DF0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yCk0Mw1Mtm18DItAZ22rR7PyT5QbY7Y1gl1kmQ83S/I=; b=cX5j84bqDaqdvqcorVo3l1+RK rL7XXeqlKI7O/uDFRYTCUdCaPmiCiY6LpzB2RgIDT8CotySUrkT7qpdo5wZU5S2tH+xArwE83Hsfv l/dgwjvarFloAS8KuJFKH2cADziI6lcCQxF+yr+DR1vsi8/iE+AOSw7zS/H58TWXkenQAGuNkYS6K 4D0e60O+984bKYxJk4g0tPxu+zbzR6uftuRQxU5mJGOP6+Dq6NQg97Xj9o1Dr0qsqBGY3WHCQz35e WcHT9fK8td3OUSzW7RUJYxcomkmLgbrkdUC1QuE/55PX3gczVv8WRS6sYEJQmKoMq/XNT7ykqNbkP ZBw0XG53Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lD8mu-0005uG-Pc; Fri, 19 Feb 2021 16:37:52 +0000 Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lD8ms-0005th-1K for linux-arm-kernel@lists.infradead.org; Fri, 19 Feb 2021 16:37:51 +0000 Received: by mail-il1-x12d.google.com with SMTP id y15so4959794ilj.11 for ; Fri, 19 Feb 2021 08:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QopIIrFF742BKqlOh4+TqmLjkxOTaJiQM9hc+/gnVxg=; b=xldRnNMtCqOBtzAdSkbWqDWK1ZbBF6xEYQZCfkn3Y7jcOIl3VVDqypJDMNaSi54KE1 w5LVCAGlgEGfzdrZ86fr6IYN3EPax5C50K8P9YGyH/PbZ8Zx/hY+CcxcvvcchvODNXc2 WyorXES1uKg5brfvrOuCQ9Ht4vWMeJGjFEO4hmvtMwWoEPHyuh1tfidic+3IF3ctBVet KDCu+30h/EzmrPC3/j8Sqjhcru3Z1CLS3vGB5FZryibLYYvzatBb7tPPkHfEUXFkobqm Q4nit8t2eBFzFSSdjciLL3gsu9vjwjHTERF2kHJrZViI4kb20kuxpp0LRFLcw/GBHMaD BUZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QopIIrFF742BKqlOh4+TqmLjkxOTaJiQM9hc+/gnVxg=; b=afL2TS6RSLhhktcfAuCEalBjT6VD9qF1HF+b7ZKzOFZAkcgAPubAAa0xImmrTj1cEb qMP+xaA2rk6sAY8SZiCQPFgKH1A3uj3KFGeNEAwdTrzeWw6AOU5kFACeSiuzbh4+oGgA tr2dCoUf8t8fNHyMp21mtv7nRGCJpq4XDCRoSnlm2fdwx5mQQAA3upTm52c82QRiwxxM eeuaC83RCchcu+p3PM1Zza3Gs8MiY8FzMols0tnCKCcKh4acHQWJEfGLN7oH9uRX0koC YUpHL4mu4019Q5xWmuMAsuYl1GgQCSVZT/Z6yrFR3DzgkdDpQRo86LGFFJb2J640o+a8 4Jlw== X-Gm-Message-State: AOAM532EDz2Z68veXnGFCoqdJoVBmQZyG3lrXCYQ5AOz0sfg/6CMIgZ3 W1N+FA/I0RAyUs3QnQwgzo6+eh9LkfuQcvBx X-Google-Smtp-Source: ABdhPJxaKeetAYFXJydsPreGczSfycYq3Pg3RINKEm67oHsdXLXdiZ/SpgwXBek/ZmbU589cfA+RMQ== X-Received: by 2002:a05:6e02:13eb:: with SMTP id w11mr4524720ilj.103.1613752667719; Fri, 19 Feb 2021 08:37:47 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id g3sm6741393ile.10.2021.02.19.08.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Feb 2021 08:37:47 -0800 (PST) Subject: Re: [next]: fs/io_uring.c:6171:10: error: implicit declaration of function 'io_sendmsg_prep_async'; did you mean 'io_req_prep_async'? To: Naresh Kamboju , linux-mips@vger.kernel.org, Linux-Next Mailing List , io-uring@vger.kernel.org, open list , Linux ARM , lkft-triage@lists.linaro.org References: From: Jens Axboe Message-ID: Date: Fri, 19 Feb 2021 09:37:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210219_113750_140338_1C568DB6 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Pavel Begunkov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/19/21 9:08 AM, Naresh Kamboju wrote: > Linux next tag 20210219 arm and mips builds failed due to below error. > > Following build configs failed > arm (s3c6400_defconfig) with gcc-8 > arm (s3c6400_defconfig) with gcc-9 > arm (s3c6400_defconfig) with gcc-10 > > mips (e55_defconfig) with gcc-8 > mips (e55_defconfig) with gcc-9 > mips (e55_defconfig) with gcc-10 > > fs/io_uring.c:6171:10: error: implicit declaration of function > 'io_sendmsg_prep_async'; did you mean 'io_req_prep_async'? > [-Werror=implicit-function-declaration] > return io_sendmsg_prep_async(req); > ^~~~~~~~~~~~~~~~~~~~~ > io_req_prep_async > > Reported-by: Naresh Kamboju This should fix it, cleaning it up a bit at the same time. commit b1c892df32ebf6f30c995e23dcafeae2392ad1bc Author: Jens Axboe Date: Fri Feb 19 09:35:19 2021 -0700 io_uring: make the !CONFIG_NET helpers a bit more robust With the prep and prep async split, we now have potentially 3 helpers that need to be defined for !CONFIG_NET. Add some helpers to do just that. Fixes the following compile error on !CONFIG_NET: fs/io_uring.c:6171:10: error: implicit declaration of function 'io_sendmsg_prep_async'; did you mean 'io_req_prep_async'? [-Werror=implicit-function-declaration] return io_sendmsg_prep_async(req); ^~~~~~~~~~~~~~~~~~~~~ io_req_prep_async Fixes: 93642ef88434 ("io_uring: split sqe-prep and async setup") Reported-by: Naresh Kamboju Signed-off-by: Jens Axboe diff --git a/fs/io_uring.c b/fs/io_uring.c index b7bae301744b..c9a5c498dc3b 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -5127,56 +5127,32 @@ static int io_connect(struct io_kiocb *req, unsigned int issue_flags) return 0; } #else /* !CONFIG_NET */ -static int io_sendmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) -{ - return -EOPNOTSUPP; -} - -static int io_sendmsg(struct io_kiocb *req, unsigned int issue_flags) -{ - return -EOPNOTSUPP; -} - -static int io_send(struct io_kiocb *req, unsigned int issue_flags) -{ - return -EOPNOTSUPP; -} - -static int io_recvmsg_prep(struct io_kiocb *req, - const struct io_uring_sqe *sqe) -{ - return -EOPNOTSUPP; -} - -static int io_recvmsg(struct io_kiocb *req, unsigned int issue_flags) -{ - return -EOPNOTSUPP; -} - -static int io_recv(struct io_kiocb *req, unsigned int issue_flags) -{ - return -EOPNOTSUPP; -} - -static int io_accept_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) -{ - return -EOPNOTSUPP; -} - -static int io_accept(struct io_kiocb *req, unsigned int issue_flags) -{ - return -EOPNOTSUPP; -} - -static int io_connect_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) -{ - return -EOPNOTSUPP; -} - -static int io_connect(struct io_kiocb *req, unsigned int issue_flags) -{ - return -EOPNOTSUPP; -} +#define IO_NETOP_FN(op) \ +static int io_##op(struct io_kiocb *req, unsigned int issue_flags) \ +{ \ + return -EOPNOTSUPP; \ +} + +#define IO_NETOP_PREP(op) \ +IO_NETOP_FN(op) \ +static int io_##op##_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) \ +{ \ + return -EOPNOTSUPP; \ +} \ + +#define IO_NETOP_PREP_ASYNC(op) \ +IO_NETOP_PREP(op) \ +static int io_##op##_prep_async(struct io_kiocb *req) \ +{ \ + return -EOPNOTSUPP; \ +} + +IO_NETOP_PREP_ASYNC(sendmsg); +IO_NETOP_PREP_ASYNC(recvmsg); +IO_NETOP_PREP_ASYNC(connect); +IO_NETOP_PREP(accept); +IO_NETOP_FN(send); +IO_NETOP_FN(recv); #endif /* CONFIG_NET */ struct io_poll_table { -- Jens Axboe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel