From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB95ACD342C for ; Wed, 6 May 2026 14:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T3vToQ5Y+vWhpVQnvtWFjRehlTKodwndWbzaDErO2cA=; b=qv+qnPNnQflkLiT7VH9n/F8Y43 gwkhHrR7RoyDTQ9FXmptS258EfD5DKi8hEgCiBTDMKFmKpNa/nGky4a0suY7Pm7QxUTfKd+0WeXvu 7aTPTprfLxv/5BlLgwCp6+363qXPV0ga7URQtyf9fvi7xrV5M4RD7PQ2J06HbCkirWdY9P5FGyANt HSQzNg007XcH0/RmCue5Nb2UTIIRWps0eESeqjnD2Q2TahbhjBOSQrAkyoOjxAqqPbL01zVwG5Zjk qkNLnCpZVNdvgoT4XbP+FZBx/Utq8uDELb7Tg5H+kAsAZv6QLQCjN4IRW/TgJ4RAdY6jmCXgFxv50 IpAuE2Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKdXQ-000000019YX-0UWC; Wed, 06 May 2026 14:47:48 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKdXP-000000019X1-1pUN for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2026 14:47:47 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso69102715e9.3 for ; Wed, 06 May 2026 07:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778078865; x=1778683665; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=T3vToQ5Y+vWhpVQnvtWFjRehlTKodwndWbzaDErO2cA=; b=dRnJnnnqCyDKV7X4DIHogdflH1kW+DFhaqcX4SSbyxJMYrP7EDHFdHbUI3gjDFwHDv XY/BQmY1U34tq4pIG5jKPrngg2H6s9rlcsZjfJsFsFPGG+35gyVDeT4ISzR4ZyRu3y45 lAnfczmyb7TH9tibMJo3USwdqFztw26f3Q0pOs0K7t/H3skemdLjScd+bqqYp+tXspN2 Nkum2401whXerjC0pIbx14vGOjeUpbI0y8aYOpijRHO3QD7KyIMCBYzDPqWf/lJFeY0c a6VnOADH/RMZzHyDs+KFVuP9VJlfsiIeinvus4w0/w3Lv1ZaLr9JJ22uotAd6LprCM97 tdEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778078865; x=1778683665; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T3vToQ5Y+vWhpVQnvtWFjRehlTKodwndWbzaDErO2cA=; b=hW8cF5qyfImNJxcNKzyx3uJ3Crott0BPr1S4x07osrkSkiW0H7WZbKut9o4IcFYBnY mvNGfcP1qJ7gNgS8gjlLOm4XadOJFaPuMG56OZAUDXrjaLQBGnY8P7R1VE1wVKqpwHL0 FKIIUPZZ9K/9j+40jtAq2HjjrYFwOKYEnG6awqQHCThdcMToHLeLIUjr2tOGnhlOoaN4 quQjPWXNuLkPmAyeokZGrcYJnZ952tmCLq2Jb/JLNkei67jM89IJu9dnkibAJFZjFXSB wrMKCKbjdzLG9FUjCkelPzmA4gURpoIDOMIqn6amrES4jnTXJWgDuKuelHohye8IRWb1 buog== X-Forwarded-Encrypted: i=1; AFNElJ+Pi09qsg+g+KVEIt13egNKof+py9mP/HRIGwbYwceR7X1k55w1uwnCY58QUk0WMr3r91Z/fmwiN3Nay6zh3cuu@lists.infradead.org X-Gm-Message-State: AOJu0Yw6eMmQSQB6fzBDk3lVo0sOGIatm124BVmxwl4J/iVV5UEHkUv8 lLxTdGTVB5pQnOhOVsYI4yGFGo5kiug2UMtoNdsQ8fDMp19kzS6ThXMnF1xtw9pDdlE= X-Gm-Gg: AeBDievR8wpyx9h1cDzGPRyvdhfQ9kNBWXLG4DMWnP/XAn+AlNj+QRJaBFkiYfsDogs Ou7pjOaA+ve6FXfftUrjc5J+WqB3JcXsd4SJEUUzje/mfHnltz0xUZKnh1xT23YeRDq7MBPlopx sCqXwPUCsepQtvvZpqJMB8c/uuXqiq8E5wHhpBVszBALH1NaX14uTZ+lWGmhPrJreo2jNqfQNQP Dn8cyA8EXBYku3awqNFaFlO5LPGqYwPQxRGCXGbNJ9/rvoPYZqAzOiiFEYXZysgK0FLYviiCL0m HW8iJLxvvj+dGIY5/Q7xGEofFrX/7NFUcZhLBkaytxZclfDxMidDh29CmHcv+2bZhUN150IgvFl YkzD//7xsjvJ0O3YK5AETHhpSqNRdiDlSAtfVHPN65rXFHOCSgU8u37ocAMHWESbLkUmjyCSQml MOIlPUn43+N2Pombqjvz2dRxiMOirOPPmczBz3zCFtHw/IlCrCTXOrX3VMwEcyRP4+vqtbCQMPY VTgVxSumxLmhSkHfA== X-Received: by 2002:a05:600d:849c:20b0:488:a2ac:a34c with SMTP id 5b1f17b1804b1-48e51f220e7mr48119355e9.12.1778078865201; Wed, 06 May 2026 07:47:45 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:5798:67fd:c866:b378? ([2a01:e0a:106d:1080:5798:67fd:c866:b378]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530b213asm18805425e9.2.2026.05.06.07.47.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 07:47:44 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 16:47:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v4 02/16] phy: rockchip: usbdp: Do not loose USB3 PHY status To: Sebastian Reichel , Vinod Koul , Heiko Stuebner , Frank Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Yan , Dmitry Baryshkov , Yubing Zhang , Alexey Charkov , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, devicetree@vger.kernel.org References: <20260428-rockchip-usbdp-cleanup-v4-0-7775671ece22@collabora.com> <20260428-rockchip-usbdp-cleanup-v4-2-7775671ece22@collabora.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260428-rockchip-usbdp-cleanup-v4-2-7775671ece22@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260506_074747_494684_A6C1ED24 X-CRM114-Status: GOOD ( 19.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/28/26 18:13, Sebastian Reichel wrote: > By default (i.e. without manually enabling runtime PM) DWC3 requests the > USB3 PHY once and keeps it enabled all the time. When DisplayPort is > being requested later on, a mode change is needed. This re-initializes > the PHY. During re-initialization the status variable has incorrectly > been cleared, which means the tracking information for USB3 ist lost. --------------------------------------------------------------/\ is > > This is not an immediate problem, since the DP side keeps the PHY > enabled. But once DP is toggled off, the whole PHY will be disabled. > This is a problem, because the USB side still needs it powered. > > Fix things by not clearing the status flags. > > Signed-off-by: Sebastian Reichel > --- > drivers/phy/rockchip/phy-rockchip-usbdp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c > index fba35510d88c..744cc7c642f4 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -1009,7 +1009,6 @@ static int rk_udphy_power_on(struct rk_udphy *udphy, u8 mode) > rk_udphy_u3_port_disable(udphy, false); > } else if (udphy->mode_change) { > udphy->mode_change = false; > - udphy->status = UDPHY_MODE_NONE; > if (udphy->mode == UDPHY_MODE_DP) > rk_udphy_u3_port_disable(udphy, true); > > Looks good, but any fixes tag ? Neil