From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D21C433F5 for ; Mon, 7 Feb 2022 09:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UcLff8bOh5pbNmSCe42wh5WC9tIrK3KQXUK8AI9Z+lM=; b=yOTaLb+zB8oiIx CbSJzk4F+vPLfHoYZ7UvxrRfmJ++gPnOtjJN5VYzckPjbaGeOn0zkDu+efmwtxF9AUhONV/mIqIWV WDfBJbT30VGVVdxcC4/7G1Hq7R2z2WgYUU8njAuunsO4GJl7CX8FkNN4k/6tY9WVCduSpQ29Rs0yF SfHfoZeqt7opd+iPyA09Y80qh7XUkiQeix7ehDIpIpkwt3mc3RZu6q1fbUTTYdV+pNeOs8kYFnqRP G5M368n8sYTk2kcs2Ouq7qU4BGaoB/S7WdEyhxFs2ACtBPDvFsqD42sPgxw7bmil8o13uV3VE7zyS ORdSbrh0u7sQwR8gecTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH0do-009dLB-PC; Mon, 07 Feb 2022 09:49:01 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH0dk-009dK8-Re for linux-arm-kernel@lists.infradead.org; Mon, 07 Feb 2022 09:48:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64050611E2; Mon, 7 Feb 2022 09:48:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26145C004E1; Mon, 7 Feb 2022 09:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644227335; bh=mD9mtrxe++NaQ4w8np5HRlq449OvwX0lapT6hefnHms=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DYl3gk8aTzu2bMYi4yOVAO0O5/wSE8m+Ruwq5cshoZ3i2OYncEBpWP6jQrChMPf+u ia/DIS0LOswizYAQiipJGWv7cQsjEKcUmqBdnCUbUxcRWH5CONceCp6b+LBajVLIbv owfoKvOPB+wUOj/sXmW+H8ZxYdVBFV/jjSH4gNjaeswTo4hwpOKKsghoBUVuZaYaNG f91nhaoNc/vHI3dVkQVIEsxFE3zpxGQ9Q/f0y9YI16w+/y9eZpB54HW+fCUvWPWA3z j16DfYZAbwmvsYpF1gVddW5ZrRspt5mjieAZB+w7cBbqgxG4SBuLNNoe+pkn897UN7 BduOq6e4fdsyw== Message-ID: Date: Mon, 7 Feb 2022 03:48:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER Content-Language: en-US To: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Nathan Chancellor , kernel test robot , stable@vger.kernel.org References: <20220207084404.212017-1-krzysztof.kozlowski@canonical.com> From: Dinh Nguyen In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220207_014856_983123_48A13084 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/7/22 03:47, Krzysztof Kozlowski wrote: > On 07/02/2022 10:45, Dinh Nguyen wrote: >> >> >> On 2/7/22 02:44, Krzysztof Kozlowski wrote: >>> The SocFPGA machine since commit b3ca9888f35f ("reset: socfpga: add an >>> early reset driver for SoCFPGA") uses reset controller, so it should >>> select RESET_CONTROLLER explicitly. Selecting ARCH_HAS_RESET_CONTROLLER >>> is not enough because it affects only default choice still allowing a >>> non-buildable configuration: >>> >>> /usr/bin/arm-linux-gnueabi-ld: arch/arm/mach-socfpga/socfpga.o: in function `socfpga_init_irq': >>> arch/arm/mach-socfpga/socfpga.c:56: undefined reference to `socfpga_reset_init' >>> >>> Reported-by: kernel test robot >>> Cc: >>> Fixes: b3ca9888f35f ("reset: socfpga: add an early reset driver for SoCFPGA") >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> arch/arm/mach-socfpga/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig >>> index 43ddec677c0b..594edf9bbea4 100644 >>> --- a/arch/arm/mach-socfpga/Kconfig >>> +++ b/arch/arm/mach-socfpga/Kconfig >>> @@ -2,6 +2,7 @@ >>> menuconfig ARCH_INTEL_SOCFPGA >>> bool "Altera SOCFPGA family" >>> depends on ARCH_MULTI_V7 >>> + select ARCH_HAS_RESET_CONTROLLER >>> select ARCH_SUPPORTS_BIG_ENDIAN >>> select ARM_AMBA >>> select ARM_GIC >>> @@ -18,6 +19,7 @@ menuconfig ARCH_INTEL_SOCFPGA >>> select PL310_ERRATA_727915 >>> select PL310_ERRATA_753970 if PL310 >>> select PL310_ERRATA_769419 >>> + select RESET_CONTROLLER >>> >>> if ARCH_INTEL_SOCFPGA >>> config SOCFPGA_SUSPEND >> >> Acked-By: Dinh Nguyen > > Hi Dinh, > > I was expecting you will pick it up. If you only ack, who is going to > take it? Shall I send it directly to soc@? > Ok...I'll pick it up. Dinh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel