From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B302FC433DF for ; Fri, 9 Oct 2020 17:05:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59C472225F for ; Fri, 9 Oct 2020 17:05:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="00UNFt1D"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DCep2uQD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59C472225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8PdefOdCETYgPzSvlcX8Y4UZOtg3IbnCPcmY1g7poTg=; b=00UNFt1Dy7FDdvYduOpEElGWd /2WSuL3uyGr6XGdS4nDAxpu/bV/2JtD1LcP43RwEzzPRqP38bRcNGo20FqIIUiiyB+G/qV3uFazyf 4vtm4HSLZv3jNQEx5mHADe4IROZ/AGWb/0gxJWENg8wLkVfVeuJmiBLZKsBsQdEwNHb3RRkXyQtgg 38l5vqjUuqhZwuqL4RqjcukAEI+9dLs6zL7CbuOyySofGzhFZnUFfJh9tNC+VPpMYWmY/ABk2kCpV HHbnloQOz1xlQdB+aUzr2wbNMao79djlkPDDTf3OFgX6S/7QDE+A01LPn8eDFyac7p6oZiUXm7ezQ Y9eMP9aPQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQvnv-0005Do-78; Fri, 09 Oct 2020 17:03:39 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQvnr-0005C8-6Z for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 17:03:36 +0000 Received: by mail-pl1-x643.google.com with SMTP id d23so4744685pll.7 for ; Fri, 09 Oct 2020 10:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/5wUWQqgMKt7EGmPaNqqLH40EmDYIrJnvSXrx5dUlfw=; b=DCep2uQD5hojSI+iubeC4ePB1JKrfcPeMCDgdyK1NcM+Lu1tOEpMv/owXhhHzOyk/b eEn0mvP5cuStSnehisWFtPm25Wt28Otk25unezJKareUfkyDhkkChIAxtPMsgh/v5eoT IWOAhxdClc21cwJejzXAUnhxUAvcRv8FVLT8vscGqIeXuRQMdepUg2/CIP0KTs2rRj/x ykKvQT05no5w53AuHLR8M/KiKROLbFkyQaG9xjxD7Ae2WIInZi1vcptAjXHJFmqbjlUE 6lPpf5OAKLEdilHeWZ8cT5QuOOCRgl/trSimnYJOc5Y+T2nIct4IiASUn88FEWtqNK7U UnTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/5wUWQqgMKt7EGmPaNqqLH40EmDYIrJnvSXrx5dUlfw=; b=it1sQWiApSflq4lmzDC6Zotc5piRpzJ/41uJKvfhDT1kDjXi/lFectLJ5SonnXvOqT bIv0+b4Ie8PsTBrzM+k5T0hFE9jjObbCZt7q/b7yio/UoFvQqMJsHEhwvTw6ng2g6xdU vJuXo4dp6CB44waujakAuHf//mYYT5MBxuezanbkAUvHvV8rGFtQevinhJMzcbjv7oTF Ofswh+7GZT1SRCHJRg57594DybMeLJpYDRWA2JIyq4LGO0CoSKkS0VbEe4JFV9Diw0rT V0i5UsGtMytNDOi0expgkhpWb5swyyCwm6yP1iVupWD5NqsnyiZchE3w1xTn2O5syvxh n2Rw== X-Gm-Message-State: AOAM533/6JN7Rfc7ZG3QMyk4ibdhvYUy5a8pNNeFwt4Kij26zgQqOrNB y6KBqVT0QrpdmpJoSFrQmTTN4u1P2bzLJw== X-Google-Smtp-Source: ABdhPJx3JUTkvfsPcw7gs1d2kYtotEv4gnjk+LmY9OMqeL/Ogeywcwyswcg09r+xu5odjV+nopaxWA== X-Received: by 2002:a17:902:aa44:b029:d3:8b4f:5083 with SMTP id c4-20020a170902aa44b02900d38b4f5083mr12653891plr.78.1602263010127; Fri, 09 Oct 2020 10:03:30 -0700 (PDT) Received: from [10.230.29.112] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id b4sm3932644pjz.51.2020.10.09.10.03.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2020 10:03:29 -0700 (PDT) Subject: Re: [PATCH v3 2/2] mailbox: Add Broadcom STB mailbox driver To: Sudeep Holla , Jim Quinlan References: <20200919192235.43872-1-james.quinlan@broadcom.com> <20200919192235.43872-3-james.quinlan@broadcom.com> <20201009163848.5tbl5bmvuoj2de2v@bogus> From: Florian Fainelli Message-ID: Date: Fri, 9 Oct 2020 10:03:27 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201009163848.5tbl5bmvuoj2de2v@bogus> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_130335_280566_555443D1 X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Jassi Brar , bcm-kernel-feedback-list@broadcom.com, open list , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/9/2020 9:38 AM, Sudeep Holla wrote: > On Sat, Sep 19, 2020 at 03:22:30PM -0400, Jim Quinlan wrote: >> only implements the agent-to-platform channel; > > In that case any reason why you can't reuse the existing smc transport > for SCMI. It was added recently in case you haven't checked the latest > kernel version(v5.8 or above). Check out for drivers/firmware/arm_scmi/smc.c > IIUC rather vaguely Florian was cc-ed on those patches. Our firmware completes all commands by posting an interrupt and we already have platforms in the field with this mailbox driver. I was hoping we could make use of the SMC transport, but the current firmware implementation completes commands by raising an interrupt. The reason why we did that was that we could support synchronous and asynchronous calls the same way. > >> we may implement the platform-to-agent channel in the future. > > This is not yet support with that transport, it is hard to generalise > as different vendors have their own solutions there. > >> An unusual aspect of this driver is how the completion of an SCMI message >> is indicated. An SCMI message is initiated with an ARM SMC call, but the >> return of this call does not indicate the execution or completion of the >> message. Rather, the message's completion is signaled by an interrupt. >> > > So are these not fast SMC/HVC calls then ? If so we may need some changes > to that driver. I just rejected multiple message support as we had assumed > fast smc/hvc. > -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel