From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF6F9C27C4F for ; Mon, 24 Jun 2024 00:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DKEYpgz0d3KtkghyncW6fFCgulDpzB03f6swFpdnWE8=; b=dBR9Rq1VhePyFVVlCjoY9RBBXG ct99rZyg9qXU/EklLqcXGRcm6X2yg5ga0awNLra4HB0d/pOxuyAOpEZVZKPOLerCQeYPQ1V9SR5rF 3Zkm9DLbKYhlWHiCU6P+vV0c/L3F25URw4GS9od/fawKj8hqExlnqVZQwCOoXoX5Hg3fenozRuXAi Nddkg7J+M4qWHZZD0GW0RRrxI1/XH1m9Dg5Gxqb1HwBExBFTuJE6kxf3WT07wH++BpmrFemS6ptdh JI+N0ekZQcwyEU5h+7dDAGOs00DGe+RkjMScaZQDMRJpA26Or1hN42ExupNNsydMkt157gQ4LWiID oK21QRAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLXZX-0000000F6aM-42xW; Mon, 24 Jun 2024 00:28:39 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLXZS-0000000F6ZQ-3T8S for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 00:28:36 +0000 Received: from [192.168.68.112] (ppp118-210-79-194.adl-adc-lon-bras32.tpg.internode.on.net [118.210.79.194]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 5D51E2009F; Mon, 24 Jun 2024 08:28:18 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1719188905; bh=DKEYpgz0d3KtkghyncW6fFCgulDpzB03f6swFpdnWE8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ikWtRn7yN7Ise0vcKddcWtskvinN6xOYIvvgomBM0u3faQxCrY2BhN/6QG9cQYymI Alg6XDXdF2cal8IZz2T3NcoiHNf1jq3vV1eVaC1NPkmOm9MiFlD3FUqHrVKnIW+4rR tt/OZguADkA/5xfiWttYJ0l7RdJUTW0Zn4iyEFUoVwfEz3Zgi6f4xmaWoXv+lvkosu rz69u2eveZL7rzRWySQh9cW3dHe2Srdfv4eOslqM2tuMZ8dCX1i/Zh87NvBxgPLchk B1V0Gs9X5DvSkmbXBkaNMBlUTlOQtxETkNCbGsqMrTpUXEUFUJ6pgGyTZ0/TsNLdNc WAT3bpeO9l2Jw== Message-ID: Subject: Re: [PATCH 01/10] iio: adc: aspeed_adc: use devm_regulator_get_enable_read_voltage() From: Andrew Jeffery To: David Lechner , Jonathan Cameron Cc: Joel Stanley , Liam Girdwood , Mark Brown , Andreas Klinger , Michael Hennerich , Nuno =?ISO-8859-1?Q?S=E1?= , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 24 Jun 2024 09:58:17 +0930 In-Reply-To: <20240621-iio-regulator-refactor-round-2-v1-1-49e50cd0b99a@baylibre.com> References: <20240621-iio-regulator-refactor-round-2-v1-0-49e50cd0b99a@baylibre.com> <20240621-iio-regulator-refactor-round-2-v1-1-49e50cd0b99a@baylibre.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240623_172835_096077_4E281898 X-CRM114-Status: UNSURE ( 8.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2024-06-21 at 17:11 -0500, David Lechner wrote: > This makes use of the devm_regulator_get_enable_read_voltage() helper > function to simplify the code. >=20 > The error return is moved closer to the function call to make it easier > to follow the logic. And a few blank lines are added for readability. >=20 > Signed-off-by: David Lechner Nice cleanup! Reviewed-by: Andrew Jeffery