From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 383A0CD11C2 for ; Mon, 8 Apr 2024 03:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n7qIc6CcB0oWgrBKGxBS/HH6xn+GzDuWgpXjW7DXfQI=; b=n2RzmF4RqCVEEz P8z4WsBI5wMcktKQJoOb7X3XgkMvuqFjet2pV2aBPqPF0Z+GvdW7mroWpsyQEkDN4hbN+sEWGWCS9 7kyw2MK939HPROa8cMaYhItY/NcGSBhU4B96RCHQg05/U++c9NiLRuwknQLI6956FSqVgOvEO6Ofq CuXaZDHr6xbw/RQnwe5KRSynDTdVsNqVVxDlmUSWsbIYilxqiQyj2TuUETsWSwtK7LTt0bkGvGaJR ihDblRF8qcJLtQ0YPwMxzC/ALcI+zUxX80jq3FRlciNH144buvMfVf290l3XvpvfU3R8sW8dTvaDd nVhIoYdQbEnP8j2Nx3qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtfku-0000000ECCG-1P1y; Mon, 08 Apr 2024 03:33:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtfkr-0000000ECBq-0nck for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 03:33:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 248C960DD8; Mon, 8 Apr 2024 03:33:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0715C433F1; Mon, 8 Apr 2024 03:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712547187; bh=jWMZ2HZ3Bb+CCiJ4NDxZ3ZAUHWn0EA4pell8ZZY8hm8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=bTg9WpMvBlPylOJbesSgZiYTOFKFVpnM0tyf9aIQxcKY6ZBsLdDFBYBYhl2Ed8us9 wyr9CtqSJ/9ww26TldpUO/sx0XFjXrJlvkru0c4CaMyfkCCadOmOcEoLDT9u9VvnmW LrvRXBepTVlX+slyF6LUyCDjn6/nRQGaaONAZxdmPROvR4WIcQB2TmE6JrsoVFJHyF RiL96QOFEPI9GW1F94TZTNFOwPSh1975UPDcOBwATY4JFvzJECqw1xddNnB6Wa+SdS IkCmwAvWhAZyF3/RVwMlH5puSEW1sNe3Vf7piRAyMwybPOGRFj1lCaEF8Y8N+eEya+ 19fVuTAkZJGNQ== Message-ID: MIME-Version: 1.0 In-Reply-To: <20240225160616.15001-2-andre.przywara@arm.com> References: <20240225160616.15001-1-andre.przywara@arm.com> <20240225160616.15001-2-andre.przywara@arm.com> Subject: Re: [RFC PATCH 1/1] clk: sunxi-ng: h6-r: add GPU power domain From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev To: Andre Przywara , Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Samuel Holland , Ulf Hansson Date: Sun, 07 Apr 2024 20:33:05 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_203309_308601_7CDF67D9 X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Andre Przywara (2024-02-25 08:06:16) > diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > index 02b28cfc5525e..363fb7a71e9f5 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > @@ -217,6 +219,86 @@ static const struct sunxi_ccu_desc sun50i_h616_r_ccu_desc = { [...] > +static int sun50i_h616_register_ppu(struct platform_device *pdev, > + void __iomem *base) > +{ > + struct device *dev = &pdev->dev; > + struct genpd_onecell_data *ppu; > + struct sun50i_h616_ppu_pd *pd; > + int ret; > + > + pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > + if (!pd) > + return -ENOMEM; > + > + ppu = devm_kzalloc(dev, sizeof(*ppu), GFP_KERNEL); > + if (!ppu) > + return -ENOMEM; > + > + ppu->domains = devm_kzalloc(dev, sizeof(*ppu->domains), GFP_KERNEL); > + if (!ppu->domains) > + return -ENOMEM; > + > + ppu->num_domains = 1; > + pd->genpd.name = "GPU"; > + pd->genpd.power_off = sun50i_h616_ppu_pd_power_off; > + pd->genpd.power_on = sun50i_h616_ppu_pd_power_on; > + pd->base = base; > + > + ret = pm_genpd_init(&pd->genpd, NULL, !sun50i_h616_ppu_power_status(pd)); > + if (ret) { > + dev_warn(dev, "Failed to add GPU power domain: %d\n", ret); > + return ret; > + } > + > + ppu->domains[0] = &pd->genpd; > + ret = of_genpd_add_provider_onecell(dev->of_node, ppu); Is this provider removed somewhere when probe fails or the driver is removed? It looks like the rest of the driver uses devm during probe. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel