From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E483DEB64DA for ; Wed, 5 Jul 2023 15:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FkLc8B1ozDDX9IYRcT6SYi7a8EQ38BUCbC2dSs124Gw=; b=j3HuZd47Ujt5MS eGiOW6A+5RaSILKo4TWMfxx2goIaBvhIRld4hBZijxz/WENSs0tNOAqNhaNmgZtQJN/JwOhbmNpOd 8YuoeuIlmX45FT1YbN2jFk94LCZN0vTcinoymUvFS+hhZyYby0kPDpWM3BSu331Op7EXsRdZ5OkZ/ +VhsjZRCAhTd1idtnD+b8QdbzDFp+HSoTSRb+V/BSnz8Ye3ApF1fMC7Gv7tHtKdByOXDoxMfwCllC u6dKmQCNqyHGdYUaCsWIE6lis74lIqx9RmP/eJNzEnZ8/wrJZN7KKBBoyhWdWA5Na7eA6w2B8tqJA KVS3v/xNRkBJn8l7zqaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qH4oj-00GOgp-0h; Wed, 05 Jul 2023 15:53:21 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qH4of-00GOg5-0k for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 15:53:18 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-991c786369cso818101066b.1 for ; Wed, 05 Jul 2023 08:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688572395; x=1691164395; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vh477yDSd+xSa/Mg5e8k0mjyTlNnNDL3Odj1uMreL9w=; b=FyE+JH8rQS/3AwHo2bDBieRlA0uAn7fhn54l+1mD2m1KmtyrGneCNZpeF/gaEvTOFQ qulUr+gqI6H1vBbOOjzVf/kWCOpMLY6Mely4jQ04rvNp9OovZVaQwpjDRM2A4tyOof90 0hqy15xEiM5iZ08gk60+G1mCnVFB+vRVfJAIFt/XDf3NfXVmbA++mkm9KjDtozo8lyQj dwM6SeQ1NiWgoJw9sekEgZDNhNdn/tsAvYE7Q03rflmt2vZ8C+wwESAGZxyINNoUyppW EkyZn8LIhMkkgoCpcbzrBWiwYh2pBJ3mqLFau3fQoPjGH8tm7WX3cAnz2QY3NtaW3xF/ f8jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688572395; x=1691164395; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vh477yDSd+xSa/Mg5e8k0mjyTlNnNDL3Odj1uMreL9w=; b=dBmQwXR4bmJ9kF2umjHv96q45+XSef1dJaee/oUIVzw1sDJmhWDEQ7MfGg19iONA8+ DEPsI1U2Osk+8QJt3BXNkeOSUcLeec+x4DcQVwzsrdznb+KNda3k4tQUqQKbWvLL1wvA UcywSTNqwUcOXZ9CLuQxB3yfSoaUo/I3viVRMW1e+lKaghjjVD1gkslH6FNfMyw5GOWh ftpFdCEYn6WQjgPHyzdUwKiYFid448K9hcsMoGslbYvUt+RaLSAMdDpgvZx4TMi81lkI ueNz4v4ePEvxG+/45xz09HGlxQDe7WFJn42nj7HsnoFbUJ9AdW/mxlJs8cla8+XEoS4v pYxQ== X-Gm-Message-State: ABy/qLaIOaAyIXMJ0W55t0uJRR1zYZ/IoTKN995Fu1v9dFvfCkq+nxs6 BZGNFlDBDn9xIVwCpo1xWUiuZA== X-Google-Smtp-Source: APBJJlE4PgcJ7V29VNYZD2/t4XcW0wr66Eo22nZ/3iI3L9HTkt5yMStE/CU7ZF2DnujfWvJy+dxuUA== X-Received: by 2002:a17:906:1914:b0:98e:2b01:ab97 with SMTP id a20-20020a170906191400b0098e2b01ab97mr11790132eje.68.1688572395674; Wed, 05 Jul 2023 08:53:15 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id t14-20020a170906948e00b009886aaeb722sm14726472ejx.137.2023.07.05.08.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 08:53:15 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 17:53:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 3/3] arm64: dts: rockchip: Add Radxa ROCK 4SE Content-Language: en-US To: Christopher Obbard , linux-rockchip@lists.infradead.org Cc: kernel@collabora.com, Andy Yan , Chris Morgan , Conor Dooley , Heiko Stuebner , Jagan Teki , Krzysztof Kozlowski , Maya Matuszczyk , Rob Herring , Sebastian Reichel , Tianling Shen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230705141011.111568-1-chris.obbard@collabora.com> <20230705141011.111568-4-chris.obbard@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20230705141011.111568-4-chris.obbard@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_085317_270112_BC33FE6D X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/07/2023 16:10, Christopher Obbard wrote: > Add board-specific devicetree file for the RK3399T-based Radxa ROCK 4SE > board. This board offers similar peripherals in a similar form-factor to > the existing ROCK Pi 4B but uses the cost-optimised RK3399T processor > (which has different OPP table than the RK3399) and other minimal hardware > changes. > > Signed-off-by: Christopher Obbard > --- > > + > +&sdio0 { > + status = "okay"; > + > + brcmf: wifi@1 { > + compatible = "brcm,bcm4329-fmac"; > + reg = <1>; > + interrupt-parent = <&gpio0>; > + interrupts = ; I just send a patch to fix this in some files, so let's try keep it good. Use proper interrupt type, not none. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel