From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14FF5C636D3 for ; Fri, 3 Feb 2023 02:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jx7C+DtNyI5+1GHaseiN2SUYWtalpmhJp7nQEmp1nU4=; b=A79R+ueFW9T173 8a1o8i8Meff69rg/DHr6sOChLLC5AozzPRWwsPTRsVlMtJ31PMZ401TFKym2EJmdECbbZqn+Trhum MaFfTq5ZZfMOO4hdBI8fQz66iYsNrvTBnusyIGSuSwgs66FT23RHKBv2JLMw787puSVIo+VDEAmiY s2RoFXIfLEWWkTsM6TgzyP2ob86V7XXMeuR3KxKu1yy5E3tc42rVzT8oAfBE3aUeeaE9d0fGAhn+n WvlItaDG8EsC7DUSnbqoHPwbWDbKaBHvjDDWbK2zUgfXOkyygNMA97ZS8y3lTE1uDVkwVdhqfOmh7 z//22CRHepFn9P6tD0fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNm8I-0004NC-S3; Fri, 03 Feb 2023 02:48:59 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNm8F-0004M0-Ns for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 02:48:57 +0000 Received: by mail-ej1-x631.google.com with SMTP id ud5so11728571ejc.4 for ; Thu, 02 Feb 2023 18:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ssp0tYsGiD2wY3B3DGIo6QkUzze0YWa6hi7rXepDkb4=; b=spkM/U5VoThD/brvY9ju/nMSYtv5QRq/KCCflZYFuQNLBWe3jtI+hjcvxUwoQCByE1 VR5eZmIYxtNYeGPKFulbHvnGN/0JFucqiP4uyABqW0n9PZ+tIQzft24GfjPyiL2koXeD U3e9asI4QaAxfFUFXZeN+FgAoK+bvOPBr1Y4JawYJMXKz7/Ip8vFaJob05v7w1a9m1JK KI9yaWTYSnByYpxu2QVQAeEFQxiDWcrCONp+t+HOlVbAtNA36e5fxxTKcWB2Oo0YEBWa V1V3aBMM31BcieD3rdbCToqUWX201WMWj2RlAcoqEaJ72XWJ5pKcltCjtgySFqKOIjbv n+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ssp0tYsGiD2wY3B3DGIo6QkUzze0YWa6hi7rXepDkb4=; b=feioXU4c7bY//d80Uo5nCAJzyvnxxPhp0qDTfde8sHl9jDfRjR5zmFl385BuZqI7U0 Zf86gVCo39BOQayoQjKymz028hPlGS/WxCrb9xmf0ed8yAeut3QZSBeFSQNIs7VBDpiU uGD9oAXW+0izjVtW59Yl823pBtrnq8699jTPXO1Pntj2vmr19Ibh8YD5DvXzjKFCgL25 8VNHb/uVSKS6OuRlC0Z4LPyBlLUk/ysy63DMuKMO2/46ubJifes61S+/klKNZKB4f9ZG RN4PilbOvGnOBt37OqjQiGm0cr8kGzdn2ql6gTGgIx4XRz/hoATNGT6s3xCOyJdY8ZcM Quuw== X-Gm-Message-State: AO0yUKX/4bq0FD9U/ntKdfphcc9AOYb1zbX2gRvBr9N8cWuB9UgiNJAY cv8rAiZ92vpqD3Vf1hIaVuPwzg== X-Google-Smtp-Source: AK7set+whWb0bDbuWGa8nmgHnP15jP1PhF9qSUmyaBXg2Yk7Dw+pIOxVTOaw5W3axnbzV5RnBpnLQw== X-Received: by 2002:a17:906:c411:b0:889:14ec:21ae with SMTP id u17-20020a170906c41100b0088914ec21aemr8874834ejz.32.1675392530811; Thu, 02 Feb 2023 18:48:50 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id s13-20020a170906c30d00b0088842b00241sm657296ejz.114.2023.02.02.18.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 18:48:50 -0800 (PST) Message-ID: Date: Fri, 3 Feb 2023 03:48:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 03/23] interconnect: fix provider registration API Content-Language: en-US To: Johan Hovold , Georgi Djakov Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Sylwester Nawrocki , =?UTF-8?B?QXJ0dXIgxZp3aWdvxYQ=?= , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230201101559.15529-1-johan+linaro@kernel.org> <20230201101559.15529-4-johan+linaro@kernel.org> From: Konrad Dybcio In-Reply-To: <20230201101559.15529-4-johan+linaro@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_184855_823933_4B0A3EF5 X-CRM114-Status: GOOD ( 26.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1.02.2023 11:15, Johan Hovold wrote: > The current interconnect provider interface is inherently racy as > providers are expected to be added before being fully initialised. > > Specifically, nodes are currently not added and the provider data is not > initialised until after registering the provider which can cause racing > DT lookups to fail. > > Add a new provider API which will be used to fix up the interconnect > drivers. > > The old API is reimplemented using the new interface and will be removed > once all drivers have been fixed. > > Fixes: 11f1ceca7031 ("interconnect: Add generic on-chip interconnect API") > Fixes: 87e3031b6fbd ("interconnect: Allow endpoints translation via DT") > Cc: stable@vger.kernel.org # 5.1 > Signed-off-by: Johan Hovold > --- Reviewed-by: Konrad Dybcio Konrad > drivers/interconnect/core.c | 52 +++++++++++++++++++-------- > include/linux/interconnect-provider.h | 12 +++++++ > 2 files changed, 50 insertions(+), 14 deletions(-) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index 43c5c8503ee8..93d27ff8eef6 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -1030,44 +1030,68 @@ int icc_nodes_remove(struct icc_provider *provider) > EXPORT_SYMBOL_GPL(icc_nodes_remove); > > /** > - * icc_provider_add() - add a new interconnect provider > - * @provider: the interconnect provider that will be added into topology > + * icc_provider_init() - initialize a new interconnect provider > + * @provider: the interconnect provider to initialize > + * > + * Must be called before adding nodes to the provider. > + */ > +void icc_provider_init(struct icc_provider *provider) > +{ > + WARN_ON(!provider->set); > + > + INIT_LIST_HEAD(&provider->nodes); > +} > +EXPORT_SYMBOL_GPL(icc_provider_init); > + > +/** > + * icc_provider_register() - register a new interconnect provider > + * @provider: the interconnect provider to register > * > * Return: 0 on success, or an error code otherwise > */ > -int icc_provider_add(struct icc_provider *provider) > +int icc_provider_register(struct icc_provider *provider) > { > - if (WARN_ON(!provider->set)) > - return -EINVAL; > if (WARN_ON(!provider->xlate && !provider->xlate_extended)) > return -EINVAL; > > mutex_lock(&icc_lock); > - > - INIT_LIST_HEAD(&provider->nodes); > list_add_tail(&provider->provider_list, &icc_providers); > - > mutex_unlock(&icc_lock); > > - dev_dbg(provider->dev, "interconnect provider added to topology\n"); > + dev_dbg(provider->dev, "interconnect provider registered\n"); > > return 0; > } > -EXPORT_SYMBOL_GPL(icc_provider_add); > +EXPORT_SYMBOL_GPL(icc_provider_register); > > /** > - * icc_provider_del() - delete previously added interconnect provider > - * @provider: the interconnect provider that will be removed from topology > + * icc_provider_deregister() - deregister an interconnect provider > + * @provider: the interconnect provider to deregister > */ > -void icc_provider_del(struct icc_provider *provider) > +void icc_provider_deregister(struct icc_provider *provider) > { > mutex_lock(&icc_lock); > WARN_ON(provider->users); > - WARN_ON(!list_empty(&provider->nodes)); > > list_del(&provider->provider_list); > mutex_unlock(&icc_lock); > } > +EXPORT_SYMBOL_GPL(icc_provider_deregister); > + > +int icc_provider_add(struct icc_provider *provider) > +{ > + icc_provider_init(provider); > + > + return icc_provider_register(provider); > +} > +EXPORT_SYMBOL_GPL(icc_provider_add); > + > +void icc_provider_del(struct icc_provider *provider) > +{ > + WARN_ON(!list_empty(&provider->nodes)); > + > + icc_provider_deregister(provider); > +} > EXPORT_SYMBOL_GPL(icc_provider_del); > > static const struct of_device_id __maybe_unused ignore_list[] = { > diff --git a/include/linux/interconnect-provider.h b/include/linux/interconnect-provider.h > index cd5c5a27557f..d12cd18aab3f 100644 > --- a/include/linux/interconnect-provider.h > +++ b/include/linux/interconnect-provider.h > @@ -122,6 +122,9 @@ int icc_link_destroy(struct icc_node *src, struct icc_node *dst); > void icc_node_add(struct icc_node *node, struct icc_provider *provider); > void icc_node_del(struct icc_node *node); > int icc_nodes_remove(struct icc_provider *provider); > +void icc_provider_init(struct icc_provider *provider); > +int icc_provider_register(struct icc_provider *provider); > +void icc_provider_deregister(struct icc_provider *provider); > int icc_provider_add(struct icc_provider *provider); > void icc_provider_del(struct icc_provider *provider); > struct icc_node_data *of_icc_get_from_provider(struct of_phandle_args *spec); > @@ -167,6 +170,15 @@ static inline int icc_nodes_remove(struct icc_provider *provider) > return -ENOTSUPP; > } > > +static inline void icc_provider_init(struct icc_provider *provider) { } > + > +static inline int icc_provider_register(struct icc_provider *provider) > +{ > + return -ENOTSUPP; > +} > + > +static inline void icc_provider_deregister(struct icc_provider *provider) { } > + > static inline int icc_provider_add(struct icc_provider *provider) > { > return -ENOTSUPP; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel