From: Ninad Palsule <ninad@linux.ibm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
johannes.holland@infineon.com, linux@roeck-us.net,
broonie@kernel.org, andre.werner@systec-electronic.com,
Andrew Geissler <geissonator@yahoo.com>,
patrick.rudolph@9elements.com, vincent@vtremblay.dev,
peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com,
bhelgaas@google.com, naresh.solanki@9elements.com,
alexander.stein@ew.tq-group.com, festevam@denx.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org,
geert+renesas@glider.be, luca.ceresoli@bootlin.com
Subject: Re: [PATCH v4 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board
Date: Thu, 25 Jan 2024 15:23:56 -0600 [thread overview]
Message-ID: <b5b0e7bd-25e5-49a4-8ac2-349020c2344b@linux.ibm.com> (raw)
In-Reply-To: <20240116190321.GA102334@bhelgaas>
Hello Bjorn,
On 1/16/24 13:03, Bjorn Helgaas wrote:
> On Tue, Jan 16, 2024 at 12:37:34PM -0600, Ninad Palsule wrote:
>> From: Andrew Geissler <geissonator@yahoo.com>
>>
>> Add a device tree for IBM system1 BMC board. It uses AST2600 SOC.
>> - Added base board
> s/Added/Add/ to match first sentence.
Fixed
>
>> - Added i2c devices and muxes.
>> - Added different voltage regulators.
>> - Added GPIO pin assignements, GPIO expansion devices
>> - Added LED brinker devices
> "brinker"? "blinker" maybe (no idea what it actually is).
Fixed. Its blinker.
>> - Added Fan controllers
> s/Fan/fan/
Fixed.
>
>> - Added EEPROM/VPD
>> - Added Power supplies
> s/Power/power/
Fixed.
>
>> - Added Humidity, pressure and temperature sensors.
> s/Humidity/humidity/
Fixed.
>
>> - Added Trusted platform module(TPM) chip.
> s/Trusted platform module/Trusted Platform Module /
Fixed
>
>> Tested:
>> This board is tested using the simics simulator.
>>
>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
>> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
> Your sign-off should be last since you are sending the series.
Fixed.
Thanks for the review.
Regards,
Ninad Palsule
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-01-25 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 18:37 [PATCH v4 0/3] Add device tree for IBM system1 BMC Ninad Palsule
2024-01-16 18:37 ` [PATCH v4 1/3] dt-bindings: arm: aspeed: add IBM system1-bmc Ninad Palsule
2024-01-16 18:37 ` [PATCH v4 2/3] dt-bindings: Add DPS310 as trivial device Ninad Palsule
2024-01-19 20:43 ` Rob Herring
2024-01-20 0:06 ` Ninad Palsule
2024-01-16 18:37 ` [PATCH v4 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board Ninad Palsule
2024-01-16 19:03 ` Bjorn Helgaas
2024-01-25 21:23 ` Ninad Palsule [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5b0e7bd-25e5-49a4-8ac2-349020c2344b@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andre.werner@systec-electronic.com \
--cc=andrew@codeconstruct.com.au \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=geert+renesas@glider.be \
--cc=geissonator@yahoo.com \
--cc=gpiccoli@igalia.com \
--cc=helgaas@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=johannes.holland@infineon.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lakshmiy@us.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca.ceresoli@bootlin.com \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=peterhuewe@gmx.de \
--cc=peteryin.openbmc@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=vincent@vtremblay.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox