From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3ED6C3064D for ; Thu, 27 Jun 2024 11:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9PgQ8AFCMlykV1fUXf8ngCVL6BfYMroXriHg35bdmfo=; b=QG6NvCet/xy8PMHb0vRN/LAw1G XnTzn1cKfv02zUaAWekxLTqDqF4xvbgol2KV7byCC5g/z7ZTZK8TBswUl7xoExKgSeTmUwZ4L+XKc fXE4qLB6B3+GXcEPTkp/vksTphiLLlDxRqk5fEyekFKhA5HPs9qhj0OeVP20kCzDDAugWQ21zIVAO WXFfZfm4x4WVkea/pVREmIMhmubsne+oe+YdJxZsNBryghviDs8XLdXoQOcpRQPYVc9i6Avomqohm PRpLpPh0DDSelKq2UZkBjYb6ElB1HEYG2+Eba8U4q5W+eeXfNt6URY45XSm3OKEdUBysXLm6v2gCJ 1n5DG/6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmya-0000000A5iJ-2jgy; Thu, 27 Jun 2024 11:07:40 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmxm-0000000A5O7-0MDw for linux-arm-kernel@bombadil.infradead.org; Thu, 27 Jun 2024 11:06:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=9PgQ8AFCMlykV1fUXf8ngCVL6BfYMroXriHg35bdmfo=; b=W1eNNhqutRRooxkgxlNF8kRK0r rPrCQRhZcBMxiF/idOF8AZLX42pCJ5FfklNw+TtWVrcYM9BGR/tz3gZJ7u7P8x0XJ4+fiAgsK3XSo TNpR+BP/ZYdFUW6oXNcewushNOGCwpOQIJdFeP0EzL8cADU0iyu7XlAZXhv9B2kZLUWKwtJSbsH+w P7JQVaOkhMtIi0UzLJffCIk4dR1MUtETSy8/2DZ4nvqbCQ2vw4M+6VSN4V20Mphr8cTwRkimR/B2r paHuTbPtdHeyfKLspS4UkObCXHA/JOGLK6PMBLHE3/he0W4hiQH5c3DGF56VJNrHnd0X5SlyQz6zl g5yoCDZw==; Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMlob-00000008pAD-2XHB for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 09:53:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1719481982; bh=lQ6DZuV1MIf49SNkyEYjAOSZq1CCitf77+c9UVPABIA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ki0GmH9DwSk4BJbAk4tWjyZkVUEoHnZ5ie1gsExxyL3MuNtbTuP2E4zlK+er+RkHA 3eNy1vN0NwqrPy/0Q0M+KJc9YyrF988yaJFQhHrFlsrAZyEWQAdDeYe7InmchyBuDS 0dFtUM7HNchGWhZRAlmiANzpMgjFnc1875fQ8+weLTo+k+s1RgK3rgH6qNTBF1MudQ tC5lodeoqRwxagtB4HDp476UmbzZsZ3tZCzoQeSs5UYV2ur3Ex6CFCwDLVHBaeNJRO wYsKcNc2iKjIN1vf4fGlirgQWHW681H/Jj8Z46AqFs8o7YCn/Jxc1pYbEwat9X6j5k xST95ASScAtLA== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 165EE37810CD; Thu, 27 Jun 2024 09:53:01 +0000 (UTC) Message-ID: Date: Thu, 27 Jun 2024 11:53:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: clock: airoha: Add reset support to EN7581 clock binding To: Conor Dooley Cc: Lorenzo Bianconi , linux-clk@vger.kernel.org, p.zabel@pengutronix.de, mturquette@baylibre.com, sboyd@kernel.org, lorenzo.bianconi83@gmail.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com References: <20240627-vending-lisp-4e1cf45e552c@wendy> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240627-vending-lisp-4e1cf45e552c@wendy> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_105324_925452_38B4DDB8 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 27/06/24 11:47, Conor Dooley ha scritto: > On Thu, Jun 27, 2024 at 11:33:47AM +0200, AngeloGioacchino Del Regno wrote: >> Il 13/06/24 14:47, Lorenzo Bianconi ha scritto: >>> Introduce reset capability to EN7581 device-tree clock binding >>> documentation. >>> >>> Signed-off-by: Lorenzo Bianconi >>> --- >>> .../bindings/clock/airoha,en7523-scu.yaml | 25 ++++++- >>> .../dt-bindings/reset/airoha,en7581-reset.h | 66 +++++++++++++++++++ >>> 2 files changed, 90 insertions(+), 1 deletion(-) >>> create mode 100644 include/dt-bindings/reset/airoha,en7581-reset.h >>> >>> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>> index 3f4266637733..84353fd09428 100644 >>> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>> @@ -35,7 +35,7 @@ properties: >>> reg: >>> minItems: 2 >>> - maxItems: 3 >>> + maxItems: 4 >>> "#clock-cells": >>> description: >>> @@ -43,6 +43,10 @@ properties: >>> clocks. >>> const: 1 >>> + '#reset-cells': >>> + description: ID of the controller reset line >>> + const: 1 >>> + >>> required: >>> - compatible >>> - reg >>> @@ -60,6 +64,8 @@ allOf: >>> - description: scu base address >>> - description: misc scu base address >>> + '#reset-cells': false >>> + >>> - if: >>> properties: >>> compatible: >>> @@ -70,6 +76,7 @@ allOf: >>> items: >>> - description: scu base address >>> - description: misc scu base address >>> + - description: reset base address >> >> Are you sure that the indentation is correct? :-) >> >> After fixing the indentation, >> >> Reviewed-by: AngeloGioacchino Del Regno >> >>> - description: pb scu base address > > The indentation actually looks okay when I apply this locally, but how is > it backwards compatible to add this register in the middle of the list?? It's not, and this is actually something done on purpose - there is no DT using this binding yet (here, nor uboot), and Lorenzo acknowledged the mistake before it was too late... At least this time, it wasn't a misattention :-P Btw, as far as I know, the reset base address is in between misc scu and pb scu, that's why it was put there in the middle. Cheers! Angelo