From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested
Date: Thu, 22 Mar 2018 19:23:07 -0500 [thread overview]
Message-ID: <b5dac2f7-eabb-6e09-2146-775b09d4eca8@codeaurora.org> (raw)
In-Reply-To: <97380342-c3aa-5d34-7b22-f6ebbab4bafe@codeaurora.org>
On 03/22/2018 07:16 PM, Timur Tabi wrote:
>
> This needs to be ret <= max_gpios, otherwise it will fail if every GPIO
> is available.
>
> And it should print an error message and return an error code if ret >
> max_gpios.
Also, you don't allocate chip->valid_mask anywhere.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-03-23 0:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:58 [PATCH v3 0/3] Support qcom pinctrl protected pins Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 1/3] dt-bindings: gpio: Add a gpio-reserved-ranges property Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 2/3] gpiolib: Support 'gpio-reserved-ranges' property Stephen Boyd
2018-03-21 17:59 ` Andy Shevchenko
2018-03-21 18:02 ` Andy Shevchenko
2018-03-21 19:59 ` Stephen Boyd
2018-03-21 20:31 ` Andy Shevchenko
2018-03-27 13:24 ` Linus Walleij
2018-03-21 16:58 ` [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested Stephen Boyd
2018-03-21 18:07 ` Andy Shevchenko
2018-03-21 20:04 ` Stephen Boyd
2018-03-21 20:30 ` Andy Shevchenko
2018-03-21 20:17 ` Stephen Boyd
2018-03-23 0:16 ` Timur Tabi
2018-03-23 0:23 ` Timur Tabi [this message]
2018-03-23 0:59 ` Timur Tabi
2018-03-23 11:34 ` Andy Shevchenko
2018-03-23 14:03 ` Timur Tabi
2018-03-23 11:36 ` Andy Shevchenko
2018-03-23 16:21 ` Stephen Boyd
2018-03-23 16:25 ` Timur Tabi
2018-03-23 16:31 ` Andy Shevchenko
2018-03-23 16:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5dac2f7-eabb-6e09-2146-775b09d4eca8@codeaurora.org \
--to=timur@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).