Re: [PATCH 15/14] power: reset: at91-reset: Convert to platform remove callback returning void

[claudiu beznea <claudiu.beznea@tuxon.dev>]

On 05.11.2023 11:47, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>

> ---
>  drivers/power/reset/at91-reset.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
> index af85f2f929ba..16512654295f 100644
> --- a/drivers/power/reset/at91-reset.c
> +++ b/drivers/power/reset/at91-reset.c
> @@ -417,19 +417,17 @@ static int at91_reset_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int at91_reset_remove(struct platform_device *pdev)
> +static void at91_reset_remove(struct platform_device *pdev)
>  {
>  	struct at91_reset *reset = platform_get_drvdata(pdev);
>  
>  	unregister_restart_handler(&reset->nb);
>  	clk_disable_unprepare(reset->sclk);
> -
> -	return 0;
>  }
>  
>  static struct platform_driver at91_reset_driver = {
>  	.probe = at91_reset_probe,
> -	.remove = at91_reset_remove,
> +	.remove_new = at91_reset_remove,
>  	.driver = {
>  		.name = "at91-reset",
>  		.of_match_table = at91_reset_of_match,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel