From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B3DC10F13 for ; Mon, 8 Apr 2019 10:43:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCD1D20883 for ; Mon, 8 Apr 2019 10:43:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Skwnc0da" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCD1D20883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vtt/8SVSgzgnlv3FVXFyqQq8rCkX8PbY4sKA6zLNC4U=; b=Skwnc0daCNYiIKyEB78wFGVsl HQC9ORetBMOCwCNgZum2npJnA4nqB81sUJueLTZm3CZB7oiNd+kC4wChV+3c6XpSRguxaZWTEcP9U RAfZEv4E7MliHkrimYMn+O+Sylokpfa6vqeVR9pvgazZ1myFqSvxjlNTTl3cNembXTtb1lP/WOaoO iEbT03Kj6qBdx23Xq2CNMpagBTrP4wjxIseJnvdmEVl1QmT2OBwdDxfUsryT8bk4QT1DjGdEs/nZH wGR8Ym8nEKSlv3hYd/vRz0JTt5DA+vYZixGZ91cVBrqOhD070ldnaNcKVDmQc3MphYn8gs2OEZf5b 5jT23jLxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRjt-0005qU-AY; Mon, 08 Apr 2019 10:42:57 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRjd-0005bb-LW for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 10:42:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25E1315AD; Mon, 8 Apr 2019 03:42:41 -0700 (PDT) Received: from [10.37.12.66] (unknown [10.37.12.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 050D43F718; Mon, 8 Apr 2019 03:42:38 -0700 (PDT) Subject: Re: [PATCH v4 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator To: leo.yan@linaro.org, mathieu.poirier@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, shiwanglai@hisilicon.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190406112145.15184-1-leo.yan@linaro.org> <20190406112145.15184-2-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: Date: Mon, 8 Apr 2019 11:44:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190406112145.15184-2-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_034241_731289_B31F3264 X-CRM114-Status: GOOD ( 21.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/06/2019 12:21 PM, Leo Yan wrote: > CoreSight uses below bindings for replicator: > > Static replicator, aka. non-configurable replicator: > "arm,coresight-replicator"; > > Dynamic replicator, aka. configurable replicator: > "arm,coresight-dynamic-replicator", "arm,primecell"; > > The compatible string "arm,coresight-replicator" is not an explicit > naming to express the replicator is 'static'. To unify the naming > convention, this patch introduces a new compatible string > "arm,coresight-static-replicator" for the static replicator; the > compatible string "arm,coresight-replicator" is still kept thus we > can support the old DT binding, but tag it as obsolete and suggest > to use the new compatible string. > > As result CoreSight replicator have below bindings: > > Static replicator: > "arm,coresight-replicator"; (obsolete) > "arm,coresight-static-replicator"; > > Dynamic replicator: > "arm,coresight-dynamic-replicator", "arm,primecell"; > > Signed-off-by: Leo Yan > --- > Documentation/devicetree/bindings/arm/coresight.txt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > index f8aff65ab921..f8f794869af2 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -69,7 +69,11 @@ its hardware characteristcs. > > * compatible: Currently supported value is (note the absence of the > AMBA markee): > - - "arm,coresight-replicator" > + - Coresight Non-configurable Replicator, the compatible string > + "arm,coresight-replicator" is obsolete, keep it to support To make it more obvious : s/obsolete/OBSOLETE/ > + the old DT bindings: > + "arm,coresight-replicator"; > + "arm,coresight-static-replicator"; nit: I would re-order the compatible strings to show the precedence of choice. e.g, - CoreSight non-configurable Replicator "arm,coresight-static-replicator"; "arm,coresight-replicator"; (OBSOLETE. For backward compatibility. Will be removed ) Also, please could we put a warning in the driver when we encounter it and request to update it ? Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel