From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EC45606A31C for ; Tue, 17 Nov 2026 06:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=GZ9Dsttq; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=KIPuptyg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=UYVbosXg DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=un94qjLPd69gCihb+f/tlZVshjSmODDedEDHnUli6kg=; b=GZ9DsttqtS7ySx eloqUVDadUcDG7Fz94ZOtoR0SVNWFhga97fUMKcUWUZavmqHDokD39QZ+rT2jjKQ6nL1NSUoRwPdI 4QRY0OSpX1UHB43G48hbWX0O5R47QYkgGRLmoVGWqVY89JM7CvfaJUd4lyBzy9iQQGHSK6Nf0qPyV VUjiPKLvWB5m2cjTUGNRDEXA3GNBuvZpHuF6aGQHU4cnJLnYrWG3ub0nDyjicy9PwkmxgmjS24GPi CeJSju4iF+SzbqPvib0tzJyF9mc7LKiUrezKLwpoZLwfj0jnMRBX3E2TcC2YIr80aUC5CKtFkLrUB NNK7Q1CctgYPjDMkQgDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTCa7-00000004f7S-3bzN; Tue, 17 Nov 2026 06:22:15 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTCa5-00000004f6e-1qmP for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2026 06:22:14 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AH2aXgq4146979 for ; Tue, 17 Nov 2026 06:22:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= un94qjLPd69gCihb+f/tlZVshjSmODDedEDHnUli6kg=; b=KIPuptygNSc6cyrg 8MXRzQMzJL4sjlpQq2CUwBP7oAf+zTniUj8QE/ogJFmisceueJb0/Fbt6QyfkXi2 xRkhJD2r6WRK/SEAi4GlPZz8B6+sqMftDRNt1lqYnNQNttXhTozQ0GxCu2MKxPbN bHCqAsEahXpK0Wg4UqOTR0owUAomIUICDEFidiepJarRkx2S+R0yFpVtULsi+Oya hBYjYZK2Irx0fSP93Afvju29ESwiy5qUjunls2wqoReiGHM9IKavWGUhN5gLKYyM 1eFPPPtTd+TKZJiIEeXGBGwhtAc0w86xwPweDnI0ULQW7G9s3OmUFC5yoZgyPU4S pRAXeA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j00nfm2bu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Nov 2026 06:22:11 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ea71803effso38858745ad.3 for ; Mon, 16 Nov 2026 22:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794896530; x=1795501330; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=un94qjLPd69gCihb+f/tlZVshjSmODDedEDHnUli6kg=; b=UYVbosXgiwENQa6J7pPSrnymkrX+/j+hg8pu4uEZa2GcOZLYkcqiAehyui+DNqIMko 62CZToP18CKxh/1k4FqUHnQHj8khZ9TArKSaOL6BO+NBUhesHAR7evOn+/D8HUlj3xk4 HkiyVYclU3LVepCZj2czqJshMj1ADHAaXoJRjc7YaoVfRILn1Tl49395KToOR+0pvRFB j/eUacUMmfhFO50y91z6heD50bKJSqx+73pG+TGzfIprgRAo9tZU89uAViOrlrEFDDUg SYRHOblp2dk4GmV+BtkM0O7Suhn9keKEp2IuC5fCVdKU2ClusgmQLSSsAHErdxGqtbsQ oZAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794896530; x=1795501330; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=un94qjLPd69gCihb+f/tlZVshjSmODDedEDHnUli6kg=; b=1KWBmvPR507UIQkBNCR7mtWsM27ddzzKaJAzqV8KcipBmOSTkeF4rOPNVKspzrT0dC vr+YJd5JducfB81OB7Os2zy1ViTYTpePWigat6zzU0avP5+u54BuNmfyHqdoMRw0k5WF cZ3V+42abYvNqjjsa0WaAfQYDG6fi327EVWbLADf2fH4F6oATM3pZOp0ZY07BNuq2fdK qx9neiqcMK/KtKwyZPIoHtse5ZWsqHW27I8fImzEiKeipNLk5vXWNL+xH538Y5QbVd/R xUolE8y5aKILDQkASRPqqDnpUA8wY1vadu1mcbfDDeH3GGwba8yGw7kIO/TG2UdIkNu1 J7jA== X-Forwarded-Encrypted: i=1; AL+hErF46usJtYpW2P4gbveA33zYGkQUxbmtPaieUP+70FNJSV1EVwNsc0YmuU5qHCBXpk+Q1yFh+BHKuoTFeekm4/3V@lists.infradead.org X-Gm-Message-State: APuU4Z8xQ+Iz5O5osbwjlsR5rTx0lXTvGEd9g0AozvAP9KQHDkhc5Xl5 6X6xCZppdDQ3y6tdfsoBDgKtJ62TSnOdQ1Ial4iVpUp1/pAblvAugIkwpQrDVnpjVZ8sMJFdLD8 ShxBiZ7sskFWCu+p+ph11HVXnu024KAejwta/oRSyzBIcND56kEOeXWjBMvnCvcmshINwS0SxS+ sihA== X-Gm-Gg: AZFdTZdNOAIMu4Z/eXNcaIqLWSOfzP1qtaovbioMzIibm2MY5YdNlCIQWG0fxwgiCBM d4kPmy1mRqc+s2a2jRp4NTdTXw/Df8SYL3XMqtmIM5Bt1fna9GWJiWuBHL6rZFK9OTw+qzZIT2h k/gPCYG8QHY868QBlo7vt+7u/si98e0cqZ1VadavBwkJKloFjzXhCIR/EvrT3P3/MhnzAr6G8Ut I2BdK0CeIwnYk3hG7zKGujwfEd17silBmtpcyO3BU23pw3vd7/m+yLgxMqIalzA1DXh12/yeN3q B9zMKqZfUvIW2Ts+6D9VWgKG/YYwDzD5Ge5i+7Wo4l7RhvchOMeBwhWyvbYTacprgWApdsTpLqO g0u3rJ6ldjOuDpMmi+k7XImhhq0UHYggjedgdWKyVjK6NUBwDesKGWd+XjqGFNavNSyGRVvTG68 +eOA+kbvfQov6KqpA6cZjR5RPz/Xk+K2Vscw8Br5aEAtk= X-Received: by 2002:a17:903:26c3:b0:2e9:4e83:1969 with SMTP id d9443c01a7336-2ee0dcd1143mr112813425ad.34.1794896529972; Mon, 16 Nov 2026 22:22:09 -0800 (PST) X-Received: by 2002:a17:903:26c3:b0:2e9:4e83:1969 with SMTP id d9443c01a7336-2ee0dcd1143mr112813055ad.34.1794896529374; Mon, 16 Nov 2026 22:22:09 -0800 (PST) Received: from [10.133.33.59] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2efd76db8acsm9019055ad.11.2026.11.16.22.22.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2026 22:22:08 -0800 (PST) Message-ID: Date: Tue, 17 Nov 2026 11:16:39 +0800 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v18 4/8] qcom-tgu: Add signal priority support To: Suzuki K Poulose , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, songchai@qti.qualcomm.com, Jie Gan References: <20261116074118.822731-1-songwei.chai@oss.qualcomm.com> <20261116074118.822731-5-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: "Songwei.Chai" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=BrEIUoX5 c=1 sm=1 tr=0 ts=6afbf293 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=hjJ2taPkbwp8OrdV2tUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE3MDAyNSBTYWx0ZWRfX3L+ENi1DUGY3 Kjzqr7ZWHC1/mrr56798aBT5W7At3hicqUTY1ftduWvimE4uqFmyL0U8C9nS4CE3c+sG60iqh/Q JkwNgn2ohbTV4bLNJ9uHzWr6nm7VnjY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE3MDAyNSBTYWx0ZWRfX9ANdkeDEMFjm EyJMoUkFX4ipVoZ8Tf8Du0qv6Ts7T19HtBqTZklYnlfE3DglRQIAgOXDOhH/r0or+Tn/mfCA1a5 PsOL58b4d8QBXB3kd9Omhdiq1WFZilLZvVWPRNa8KjNQvUYn+fG0ryzARO8x/gU6wYP+VGc4H6R LgGQNV/Y5KMSia+PI9X3ZnHBj+zVwLddxwfYkhX/ytcyv8+OvY+IQ/5AZ594kwieMY4ZwCF42LR cJ/apGaovBXvtUDlxXPWfUBytNHkBqKpDbfC8pleE1ynPMlLoAFE2jJATz6pYJq7XVeT0Fpaegf SReulxBSzeFeSWVXsicu5KPL6zIYFI/Y1A2faIl6PKRNmgtmpZHo69KvhFiun06q651gkMs6+Q6 dsI0pAkz2I2FoaFs9RFPxYGa5LrsiwOTltkwX7BR9FbummJJm3efihRoHAqB1cKxNuLkmctI4f6 ZbtdoHwLw6webzWNYGQ== X-Proofpoint-ORIG-GUID: qCjX6B_9UlwgwF2XhrVgLO_SFKNi3yoY X-Proofpoint-GUID: qCjX6B_9UlwgwF2XhrVgLO_SFKNi3yoY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-17_01,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611170025 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261116_222213_628875_937400EA X-CRM114-Status: GOOD ( 22.86 ) X-Spam-Score: -1.2 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/16/2026 7:16 PM, Suzuki K Poulose wrote: > On 16/11/2026 07:41, Songwei Chai wrote: >> Like circuit of a Logic analyzer, in TGU, the requirement could be >> configured in each step and the trigger will be created once the >> requirements are met. Add priority functionality here to sort the >> signals into different priorities. The signal which is wanted could >> be configured in each step's priority node, the larger number means >> the higher priority and the signal with higher priority will be sensed >> more preferentially. >> >> Reviewed-by: Jie Gan >> Signed-off-by: Songwei Chai >> --- >>   .../ABI/testing/sysfs-bus-amba-devices-tgu    |   7 + >>   drivers/hwtracing/qcom/tgu.c                  | 211 ++++++++++++++++++ >>   drivers/hwtracing/qcom/tgu.h                  |  68 ++++++ >>   3 files changed, 286 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu >> b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu >> index 798a0e51e27a..3be0b912c937 100644 >> --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu >> +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu >> @@ -7,3 +7,10 @@ Description: >>           Accepts only one of the 2 values -  0 or 1. >>           0 : disable TGU. >>           1 : enable TGU. >> + >> +What: >> /sys/bus/amba/devices//step[0:7]_priority[0:3]/reg[0:23] >> +Date:        November 2026 >> +KernelVersion:    7.5 >> +Contact:    Jinlong Mao , Songwei Chai >> >> +Description: >> +        (RW) Set/Get the sensed signal with specific step and >> priority for TGU. >> diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c >> index 5bae46db4f8c..917d506cddf9 100644 >> --- a/drivers/hwtracing/qcom/tgu.c >> +++ b/drivers/hwtracing/qcom/tgu.c >> @@ -16,14 +16,145 @@ >>     #include "tgu.h" >>   +struct tgu_attribute { >> +    struct device_attribute attr; >> +    u8 step_index; >> +    u8 priority; >> +    u8 reg_num; >> +}; >> + >> +/* >> + * drvdata->priority is a flat [priority][step][reg] array. >> + */ >> +static int calculate_array_location(struct tgu_drvdata *drvdata, >> +                    int step_index, int priority, >> +                    int reg_index) >> +{ >> +    return priority * (drvdata->num_step) * (drvdata->num_reg) + >> +        step_index * (drvdata->num_reg) + reg_index; >> +} >> + >> +static ssize_t tgu_dataset_show(struct device *dev, >> +                struct device_attribute *attr, char *buf) >> +{ >> +    struct tgu_drvdata *drvdata = dev_get_drvdata(dev); >> +    struct tgu_attribute *tgu_attr = >> +            container_of(attr, struct tgu_attribute, attr); >> +    int index; >> + >> +    index = calculate_array_location(drvdata, tgu_attr->step_index, >> +                     tgu_attr->priority, >> +                     tgu_attr->reg_num); >> + >> +    /* >> +     * Serialise against tgu_dataset_store() and tgu_enable(), which >> read >> +     * and write the same priority array, so the value is not observed >> +     * while being updated concurrently. >> +     */ >> +    guard(mutex)(&drvdata->lock); >> + >> +    return sysfs_emit(buf, "0x%x\n", drvdata->priority[index]); >> +} >> + >> +static ssize_t tgu_dataset_store(struct device *dev, >> +                 struct device_attribute *attr, >> +                 const char *buf, size_t size) >> +{ >> +    struct tgu_drvdata *tgu_drvdata = dev_get_drvdata(dev); >> +    struct tgu_attribute *tgu_attr = >> +        container_of(attr, struct tgu_attribute, attr); >> +    unsigned long val; >> +    int index; >> +    int ret; >> + >> +    ret = kstrtoul(buf, 0, &val); >> +    if (ret) >> +        return ret; >> + >> +    guard(mutex)(&tgu_drvdata->lock); >> +    index = calculate_array_location(tgu_drvdata, tgu_attr->step_index, >> +                     tgu_attr->priority, >> +                     tgu_attr->reg_num); >> + >> +    tgu_drvdata->priority[index] = val; >> + >> +    return size; >> +} >> + >> +static umode_t tgu_node_visible(struct kobject *kobject, >> +                struct attribute *attr, >> +                int n) >> +{ >> +    struct device *dev = kobj_to_dev(kobject); >> +    struct tgu_drvdata *drvdata = dev_get_drvdata(dev); >> +    struct device_attribute *dev_attr = >> +        container_of(attr, struct device_attribute, attr); >> +    struct tgu_attribute *tgu_attr = >> +        container_of(dev_attr, struct tgu_attribute, attr); >> + >> +    if (tgu_attr->step_index >= drvdata->num_step) >> +        return SYSFS_GROUP_INVISIBLE; >> + >> +    if (tgu_attr->reg_num >= drvdata->num_reg) >> +        return 0; >> + >> +    return attr->mode; >> +} >> + >>   static void tgu_write_all_hw_regs(struct tgu_drvdata *drvdata) >>   { >> +    int i, j, k, index; >> + >>       CS_UNLOCK(drvdata->base); >> +    for (i = 0; i < drvdata->num_step; i++) { >> +        for (j = 0; j < MAX_PRIORITY; j++) { >> +            for (k = 0; k < drvdata->num_reg; k++) { >> +                index = calculate_array_location( >> +                            drvdata, i, j, k); >> + >> +                writel(drvdata->priority[index], >> +                    drvdata->base + >> +                    PRIORITY_REG_STEP(i, j, k)); >> +            } >> +        } >> +    } >>       /* Enable TGU to program the triggers */ >>       writel(1, drvdata->base + TGU_CONTROL); >>       CS_LOCK(drvdata->base); >>   } >>   +static void tgu_set_dev_caps(struct tgu_drvdata *drvdata) >> +{ >> +    int num_sense_input, num_reg, num_step; >> +    u32 devid; >> + >> +    devid = readl(drvdata->base + CORESIGHT_DEVID); >> + >> +    num_sense_input = TGU_DEVID_SENSE_INPUT(devid); >> +    num_reg = (num_sense_input * TGU_BITS_PER_SIGNAL) / >> LENGTH_REGISTER; >> + >> +    if ((num_sense_input * TGU_BITS_PER_SIGNAL) % LENGTH_REGISTER) >> +        num_reg++; >> + >> +    if (num_reg > TGU_MAX_PRIORITY_REGS) { >> +        dev_warn(drvdata->dev, >> +            "DEVID reports %d priority regs, clamping to %d\n", >> +            num_reg, TGU_MAX_PRIORITY_REGS); >> +        num_reg = TGU_MAX_PRIORITY_REGS; >> +    } >> +    drvdata->num_reg = num_reg; >> + >> +    num_step = TGU_DEVID_STEPS(devid); >> + >> +    if (num_step > TGU_MAX_STEPS) { >> +        dev_warn(drvdata->dev, >> +            "DEVID reports %d steps, clamping to %d\n", >> +            num_step, TGU_MAX_STEPS); >> +        num_step = TGU_MAX_STEPS; >> +    } >> +    drvdata->num_step = num_step; >> +} >> + >>   static void tgu_enable(struct tgu_drvdata *drvdata) >>   { >>       tgu_write_all_hw_regs(drvdata); >> @@ -103,8 +234,86 @@ static const struct attribute_group >> tgu_common_grp = { >>       .attrs = tgu_common_attrs, >>   }; >>   +#define tgu_dataset_rw(name, step_index, priority, >> reg_num)              \ >> +    (&((struct tgu_attribute[]){ {                                   \ >> +        __ATTR(name, 0644, tgu_dataset_show, tgu_dataset_store), \ >> + step_index,                                              \ >> + priority,                                                \ >> + reg_num,                                                 \ >> +    } })[0].attr.attr) >> + >> +#define STEP_PRIORITY(step_index, reg_num, priority)              \ >> +    tgu_dataset_rw(reg##reg_num, step_index, priority, reg_num) >> + >> +#define STEP_PRIORITY_LIST(step_index, priority) \ >> +    {STEP_PRIORITY(step_index, 0, priority), \ >> +     STEP_PRIORITY(step_index, 1, priority),  \ >> +     STEP_PRIORITY(step_index, 2, priority),     \ >> +     STEP_PRIORITY(step_index, 3, priority),  \ >> +     STEP_PRIORITY(step_index, 4, priority),  \ >> +     STEP_PRIORITY(step_index, 5, priority),  \ >> +     STEP_PRIORITY(step_index, 6, priority),  \ >> +     STEP_PRIORITY(step_index, 7, priority),  \ >> +     STEP_PRIORITY(step_index, 8, priority),  \ >> +     STEP_PRIORITY(step_index, 9, priority),  \ >> +     STEP_PRIORITY(step_index, 10, priority), \ >> +     STEP_PRIORITY(step_index, 11, priority), \ >> +     STEP_PRIORITY(step_index, 12, priority), \ >> +     STEP_PRIORITY(step_index, 13, priority), \ >> +     STEP_PRIORITY(step_index, 14, priority), \ >> +     STEP_PRIORITY(step_index, 15, priority), \ >> +     STEP_PRIORITY(step_index, 16, priority), \ >> +     STEP_PRIORITY(step_index, 17, priority), \ >> +     STEP_PRIORITY(step_index, 18, priority), \ >> +     STEP_PRIORITY(step_index, 19, priority), \ >> +     STEP_PRIORITY(step_index, 20, priority), \ >> +     STEP_PRIORITY(step_index, 21, priority), \ >> +     STEP_PRIORITY(step_index, 22, priority), \ >> +     STEP_PRIORITY(step_index, 23, priority), \ >> +     NULL                   \ >> +    } >> + >> +#define PRIORITY_ATTRIBUTE_GROUP_INIT(step, priority)\ >> +    (&(const struct attribute_group){\ >> +        .attrs = (struct attribute*[])STEP_PRIORITY_LIST(step, >> priority),\ >> +        .is_visible = tgu_node_visible,\ >> +        .name = "step" #step "_priority" #priority \ >> +    }) >> + >>   static const struct attribute_group *tgu_attr_groups[] = { >>       &tgu_common_grp, >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(0, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(0, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(0, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(0, 3), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(1, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(1, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(1, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(1, 3), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(2, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(2, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(2, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(2, 3), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(3, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(3, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(3, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(3, 3), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(4, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(4, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(4, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(4, 3), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(5, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(5, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(5, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(5, 3), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(6, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(6, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(6, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(6, 3), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(7, 0), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(7, 1), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(7, 2), >> +    PRIORITY_ATTRIBUTE_GROUP_INIT(7, 3), >>       NULL, >>   }; >>   @@ -129,6 +338,8 @@ static int tgu_probe(struct amba_device *adev, >> const struct amba_id *id) >>       if (ret) >>           return ret; >>   +    tgu_set_dev_caps(drvdata); >> + >>       drvdata->enabled = false; >>         ret = sysfs_create_groups(&dev->kobj, tgu_attr_groups); >> diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h >> index c6426b4e3617..d769379b8421 100644 >> --- a/drivers/hwtracing/qcom/tgu.h >> +++ b/drivers/hwtracing/qcom/tgu.h >> @@ -6,9 +6,70 @@ >>   #ifndef _QCOM_TGU_H >>   #define _QCOM_TGU_H >>   +#include >> +#include >> + >>   /* Register addresses */ >>   #define TGU_CONTROL        0x0000 >>   +#define TGU_DEVID_SENSE_INPUT(devid_val) \ >> +    ((int)FIELD_GET(GENMASK(17, 10), devid_val)) >> +#define TGU_DEVID_STEPS(devid_val) \ >> +    ((int)FIELD_GET(GENMASK(6, 3), devid_val)) >> + >> +#define TGU_BITS_PER_SIGNAL    4 >> +#define LENGTH_REGISTER        32 >> + >> +/* >> + * TGU configuration space Per-step register layout. >> + * (one step occupies STEP_SIZE bytes) Offsets below are relative to >> + *                                                         the start >> of that step's block. >> + * x-------------------------x x-----------------x >> + * |   coresight management  | |     reserved    | >> + * |        registers        | |-----------------| +0x1F4 >> + * |                         |                       ---> |   >> priority[3]   | >> + * |-------------------------|                       | >> |-----------------| +0x194 >> + * |         step[7]         |                       |     | >> priority[2]   | >> + * |-------------------------| step[0] + 7*STEP_SIZE | >> |-----------------| +0x134 >> + * |           ...           |                       |     | >> priority[1]   | >> + * |-------------------------| step[0] + 1*STEP_SIZE | >> |-----------------| +0xD4 >> + * |         step[0]         |-----------------------|     | >> priority[0]   | >> + * |-------------------------| step[0] (base+0x40) >> |-----------------| +0x74 >> + * |    Control and status   |                             | >> condition select| >> + * |          space          | |-----------------| +0x60 >> + * x-------------------------x base                        | >> condition decode| >> + * |-----------------| +0x50 >> + *                                                         | >> Timer/Counter  | >> + * x-----------------x +0x40 >> + */ >> +#define STEP_SIZE        0x1D8 > > Something is really weird. STEP_SIZE is 0x1D8, but the diagram above > shows the "reserved" is at 0x1F4 ? is it because you have added 0x40 > (of the Control and Status space) to the offsets for the step0 ? > > Please could we simply define the fields for a step with offset 0 as > the base for each step ? > > i.e., Timer/Counter -> 0x0 >       Priority[0]-> 0x34 > > confirmed. > Also, please could you keep the naming consistent. > STEP_SIZE vs PRIORITY_STRIDE ? I prefer SIZE > > > #define STEP0_BASE        0x40 > #define STEP_SIZE        0x1D8 > > #define PRIORITY0_BASE        0x34 > #define PRIORITY_SIZE        0x60 > > > and > > #define STEP_OFFSET(s)        (STEP0_BASE + STEP_SIZE * (s)) > #define PRIORITY_OFFSET(p)    (PRIORITY0_BASE + PRIORITY_SIZE *(p)) > > with that we could replace > > > +/* Calculate compare step addresses */ > > +#define PRIORITY_REG_STEP(step, priority, reg)\ > > +    (PRIORITY0_OFFSET + PRIORITY_STRIDE * priority +\ > > +     REG_SIZE * reg + STEP_SIZE * step) > > with : > > #define PRIORITY_REG_OFFSET(step, prio, reg)        \ >     (STEP_OFFSET(step) + PRIORITY_OFFSET(prio) + (reg) * REG_SIZE) > confirmed. > > > >> +#define PRIORITY0_OFFSET    0x0074 >> +#define PRIORITY_STRIDE        0x0060 >> +#define REG_SIZE        0x4 >> + >> +/* >> + * Upper bounds on the DEVID-derived per-region counts, used to clamp >> + * whatever the hardware reports so writes never fall outside the >> + * ioremap()'d window or spill into an adjacent region. >> + * >> + *   TGU_MAX_STEPS         matches the static step0..step7 sysfs >> tables. >> + *   TGU_MAX_PRIORITY_REGS matches the static reg0..reg23 sysfs tables. >> + * >> + * Each priority level's block spans a full PRIORITY_STRIDE (0x60 >> bytes), >> + * i.e. PRIORITY_STRIDE / REG_SIZE = 24 registers, all of them >> implemented. >> + */ >> + >> +#define TGU_MAX_STEPS                  8 >> +#define TGU_MAX_PRIORITY_REGS          24 >> + >> +/* Maximum priority that TGU supports */ >> +#define MAX_PRIORITY                   4 > > nit: TGU_MAX_PRIORITY for consistency confirmed. >> + > >> + >>   /** >>    * struct tgu_drvdata - Data structure for a TGU (Trigger >> Generation Unit) >>    * @base: Memory-mapped base address of the TGU device >> @@ -16,6 +77,10 @@ >>    * @lock: Mutex serialising enable/disable and the associated PM >> runtime >>    *        reference counting against concurrent sysfs access >>    * @enabled: Flag indicating whether the TGU device is enabled >> + * @priority: Per-step, per-priority-level, per-register values >> staged by >> + *            sysfs writes and flushed to hardware by tgu_enable() >> + * @num_reg: Number of priority registers implemented per priority >> level >> + * @num_step: Number of steps implemented >>    * >>    * This structure defines the data associated with a TGU device, >>    * including its base address, device pointer, the lock serialising >> @@ -26,6 +91,9 @@ struct tgu_drvdata { >>       struct device *dev; >>       struct mutex lock; >>       bool enabled; >> +    unsigned int priority[TGU_MAX_STEPS * MAX_PRIORITY * >> TGU_MAX_PRIORITY_REGS]; > > Please add a symbol for this > > #define TGU_MAX_PRIORITY_REG_SIZE >     (TGU_MAX_STEPS * TGU_MAX_PRIORITY * TGU_MAX_PRIORITY_REGS) confirmed. > > Suzuki