* [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
@ 2025-07-07 15:44 Matthew Gerlach
2025-07-08 2:34 ` Yanteng Si
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Matthew Gerlach @ 2025-07-07 15:44 UTC (permalink / raw)
To: dinguyen, andrew+netdev, davem, edumazet, kuba, pabeni, robh,
krzk+dt, conor+dt, mcoquelin.stm32, alexandre.torgue,
maxime.chevallier, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel
Cc: Matthew Gerlach
Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
implementation of the Synopsys DWMAC.
Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
---
Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index c5d8dfe5b801..ec34daff2aa0 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -59,6 +59,7 @@ properties:
- const: ptp_ref
iommus:
+ minItems: 1
maxItems: 2
phy-mode:
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
2025-07-07 15:44 [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus Matthew Gerlach
@ 2025-07-08 2:34 ` Yanteng Si
2025-07-08 20:02 ` Rob Herring (Arm)
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Yanteng Si @ 2025-07-08 2:34 UTC (permalink / raw)
To: Matthew Gerlach, dinguyen, andrew+netdev, davem, edumazet, kuba,
pabeni, robh, krzk+dt, conor+dt, mcoquelin.stm32,
alexandre.torgue, maxime.chevallier, netdev, devicetree,
linux-kernel, linux-stm32, linux-arm-kernel
在 7/7/25 11:44 PM, Matthew Gerlach 写道:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
>
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn>
Thanks,
Yanteng
> ---
> Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index c5d8dfe5b801..ec34daff2aa0 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -59,6 +59,7 @@ properties:
> - const: ptp_ref
>
> iommus:
> + minItems: 1
> maxItems: 2
>
> phy-mode:
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
2025-07-07 15:44 [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus Matthew Gerlach
2025-07-08 2:34 ` Yanteng Si
@ 2025-07-08 20:02 ` Rob Herring (Arm)
2025-07-09 2:10 ` patchwork-bot+netdevbpf
2025-07-09 6:54 ` Krzysztof Kozlowski
3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring (Arm) @ 2025-07-08 20:02 UTC (permalink / raw)
To: Matthew Gerlach
Cc: linux-stm32, davem, krzk+dt, dinguyen, devicetree,
mcoquelin.stm32, linux-arm-kernel, andrew+netdev, pabeni,
alexandre.torgue, edumazet, linux-kernel, conor+dt,
maxime.chevallier, netdev, kuba
On Mon, 07 Jul 2025 08:44:09 -0700, Matthew Gerlach wrote:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
>
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
> Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
2025-07-07 15:44 [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus Matthew Gerlach
2025-07-08 2:34 ` Yanteng Si
2025-07-08 20:02 ` Rob Herring (Arm)
@ 2025-07-09 2:10 ` patchwork-bot+netdevbpf
2025-07-09 6:54 ` Krzysztof Kozlowski
3 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-09 2:10 UTC (permalink / raw)
To: Matthew Gerlach
Cc: dinguyen, andrew+netdev, davem, edumazet, kuba, pabeni, robh,
krzk+dt, conor+dt, mcoquelin.stm32, alexandre.torgue,
maxime.chevallier, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 7 Jul 2025 08:44:09 -0700 you wrote:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
>
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
> Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
https://git.kernel.org/netdev/net-next/c/8a00a173d1a4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
2025-07-07 15:44 [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus Matthew Gerlach
` (2 preceding siblings ...)
2025-07-09 2:10 ` patchwork-bot+netdevbpf
@ 2025-07-09 6:54 ` Krzysztof Kozlowski
2025-07-09 22:23 ` Matthew Gerlach
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-09 6:54 UTC (permalink / raw)
To: Matthew Gerlach, dinguyen, andrew+netdev, davem, edumazet, kuba,
pabeni, robh, krzk+dt, conor+dt, mcoquelin.stm32,
alexandre.torgue, maxime.chevallier, netdev, devicetree,
linux-kernel, linux-stm32, linux-arm-kernel
On 07/07/2025 17:44, Matthew Gerlach wrote:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
Why? Explain why you are doing thing, not what you are doing. What is
obvious which makes entire two-line commit msg redundant and useless.
Original binding had no iommus and referenced commit does not explain
why they appeared during conversion in the first place.
>
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
> Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index c5d8dfe5b801..ec34daff2aa0 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -59,6 +59,7 @@ properties:
> - const: ptp_ref
>
> iommus:
> + minItems: 1
> maxItems: 2
Why this has to be flexible on given SoC? This is weird. Same hardware
differs somehow?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
2025-07-09 6:54 ` Krzysztof Kozlowski
@ 2025-07-09 22:23 ` Matthew Gerlach
2025-07-12 12:35 ` Dinh Nguyen
0 siblings, 1 reply; 7+ messages in thread
From: Matthew Gerlach @ 2025-07-09 22:23 UTC (permalink / raw)
To: Krzysztof Kozlowski, dinguyen, andrew+netdev, davem, edumazet,
kuba, pabeni, robh, krzk+dt, conor+dt, mcoquelin.stm32,
alexandre.torgue, maxime.chevallier, netdev, devicetree,
linux-kernel, linux-stm32, linux-arm-kernel
On 7/8/25 11:54 PM, Krzysztof Kozlowski wrote:
> On 07/07/2025 17:44, Matthew Gerlach wrote:
> > Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> > implementation of the Synopsys DWMAC.
>
> Why? Explain why you are doing thing, not what you are doing. What is
> obvious which makes entire two-line commit msg redundant and useless.
This conversion to yaml was a merge of two separate conversions from
Ding Nguyen and myself plus some resolved issues highlighted by Rob
Herring, but I missed the minItems:
https://lore.kernel.org/lkml/20250626234816.GB1398428-robh@kernel.org/
>
> Original binding had no iommus and referenced commit does not explain
> why they appeared during conversion in the first place.
The text version of the binding was created before the device trees for
the Agilex family, which do support iommus, were accepted into the kernel.
>
> >
> > Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> > ---
> > Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > index c5d8dfe5b801..ec34daff2aa0 100644
> > --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > @@ -59,6 +59,7 @@ properties:
> > - const: ptp_ref
> >
> > iommus:
> > + minItems: 1
> > maxItems: 2
>
> Why this has to be flexible on given SoC? This is weird. Same hardware
> differs somehow?
Dinh can you comment on this binding from
https://lore.kernel.org/all/20250624191549.474686-1-dinguyen@kernel.org/?
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
2025-07-09 22:23 ` Matthew Gerlach
@ 2025-07-12 12:35 ` Dinh Nguyen
0 siblings, 0 replies; 7+ messages in thread
From: Dinh Nguyen @ 2025-07-12 12:35 UTC (permalink / raw)
To: Matthew Gerlach, Krzysztof Kozlowski, andrew+netdev, davem,
edumazet, kuba, pabeni, robh, krzk+dt, conor+dt, mcoquelin.stm32,
alexandre.torgue, maxime.chevallier, netdev, devicetree,
linux-kernel, linux-stm32, linux-arm-kernel
On 7/9/25 17:23, Matthew Gerlach wrote:
>
>
> On 7/8/25 11:54 PM, Krzysztof Kozlowski wrote:
>> On 07/07/2025 17:44, Matthew Gerlach wrote:
>> > Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
>> > implementation of the Synopsys DWMAC.
>>
>> Why? Explain why you are doing thing, not what you are doing. What is
>> obvious which makes entire two-line commit msg redundant and useless.
> This conversion to yaml was a merge of two separate conversions from
> Ding Nguyen and myself plus some resolved issues highlighted by Rob
> Herring, but I missed the minItems:
>
> https://lore.kernel.org/lkml/20250626234816.GB1398428-robh@kernel.org/
>
>>
>> Original binding had no iommus and referenced commit does not explain
>> why they appeared during conversion in the first place.
> The text version of the binding was created before the device trees for
> the Agilex family, which do support iommus, were accepted into the kernel.
>>
>> > > Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac
>> bindings to yaml")
>> > Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
>> > ---
>> > Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
>> > 1 file changed, 1 insertion(+)
>> > > diff --git
>> a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
>> b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
>> > index c5d8dfe5b801..ec34daff2aa0 100644
>> > --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
>> > +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
>> > @@ -59,6 +59,7 @@ properties:
>> > - const: ptp_ref
>> > > iommus:
>> > + minItems: 1
>> > maxItems: 2
>>
>> Why this has to be flexible on given SoC? This is weird. Same hardware
>> differs somehow?
> Dinh can you comment on this binding from
> https://lore.kernel.org/all/20250624191549.474686-1-dinguyen@kernel.org/?
>
This might have been a copy/paste error.
DInh
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-07-12 12:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-07 15:44 [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus Matthew Gerlach
2025-07-08 2:34 ` Yanteng Si
2025-07-08 20:02 ` Rob Herring (Arm)
2025-07-09 2:10 ` patchwork-bot+netdevbpf
2025-07-09 6:54 ` Krzysztof Kozlowski
2025-07-09 22:23 ` Matthew Gerlach
2025-07-12 12:35 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).