From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonas Karlman <jonas@kwiboo.se>, Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: arm: rockchip: Add Hardkernel ODROID-M1S
Date: Tue, 27 Aug 2024 08:52:15 +0200 [thread overview]
Message-ID: <b69e5a0a-acf9-412c-90b4-ebe00c7e07d4@kernel.org> (raw)
In-Reply-To: <66ccebeb.d40a0220.356790.58caSMTPIN_ADDED_BROKEN@mx.google.com>
On 26/08/2024 22:55, Jonas Karlman wrote:
> The Hardkernel ODROID-M1S is a single-board computer based on Rockchip
> RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card,
> GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0.
>
> Add devicetree binding documentation for the Hardkernel ODROID-M1S board.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index f08e9f2f5dfc..9e29a5ecc94d 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -598,6 +598,11 @@ properties:
> - const: hardkernel,rk3568-odroid-m1
> - const: rockchip,rk3568
>
> + - description: Hardkernel Odroid M1S
> + items:
> + - const: hardkernel,rk3566-odroid-m1s
hardkernel,odroid-m1s
Why adding SoC name to the board? Can it be Odroid M1S with RK3568?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-27 6:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 20:55 [PATCH 0/4] arm64: dts: rockchip: Add Hardkernel ODROID-M1S Jonas Karlman
2024-08-26 20:55 ` [PATCH 1/4] dt-bindings: arm: rockchip: Correct vendor for Hardkernel ODROID-M1 Jonas Karlman
2024-08-26 21:14 ` Aurelien Jarno
2024-08-26 20:55 ` [PATCH 2/4] arm64: dts: rockchip: Correct vendor prefix " Jonas Karlman
2024-08-26 21:14 ` Aurelien Jarno
2024-08-26 20:55 ` [PATCH 3/4] dt-bindings: arm: rockchip: Add Hardkernel ODROID-M1S Jonas Karlman
2024-08-26 20:55 ` [PATCH 4/4] arm64: dts: " Jonas Karlman
[not found] ` <66ccebe1.c80a0220.22579e.e8daSMTPIN_ADDED_BROKEN@mx.google.com>
2024-08-27 6:50 ` [PATCH 1/4] dt-bindings: arm: rockchip: Correct vendor for Hardkernel ODROID-M1 Krzysztof Kozlowski
2024-08-27 11:17 ` Jonas Karlman
[not found] ` <66ccebeb.d40a0220.356790.58caSMTPIN_ADDED_BROKEN@mx.google.com>
2024-08-27 6:52 ` Krzysztof Kozlowski [this message]
2024-08-27 11:29 ` [PATCH 3/4] dt-bindings: arm: rockchip: Add Hardkernel ODROID-M1S Jonas Karlman
2024-08-27 11:44 ` Heiko Stuebner
2024-08-27 13:01 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b69e5a0a-acf9-412c-90b4-ebe00c7e07d4@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).