From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28895C47082 for ; Mon, 31 May 2021 06:13:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4D19611CA for ; Mon, 31 May 2021 06:13:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4D19611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w7r+cDGCdIxOv/uNK6NesCovbPEbiDRYUw4HmcaHUcQ=; b=C/DTksViLbyKHb/41yG7gKy3Ii aSZ8E+omO8xFWwmRx2qYXofjr+PcqkGFa11BIPQAXpVIbpQmN5rNtieQjwcCWeFgV4dgQZeaPwDpm OR44Z3Y6s7o2X91uiKnAHAZNUj9ZLgGuRWmd8gWtwRzJp5T95oUurtyUBePRn7rpyhvFngjYwKgxj PHufuARHV7N4EUGCay0y/hhMR1TR1GNy5AVKxB3/rL4bbxfCNqxrP0TGEMyxPaylsF6oGbk3oXuC8 APA/CJX+t3WeQnvbYRwPXaBNS6YB/9vKqOM3QNEmfqhP2wRU2yJXLZnIqKkox5VOcCYqZaRHnB2Xy mqReellQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnb9L-00AvFl-SC; Mon, 31 May 2021 06:11:43 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnb9I-00AvDG-8w for linux-arm-kernel@lists.infradead.org; Mon, 31 May 2021 06:11:41 +0000 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FtlGY4D2jz67NS; Mon, 31 May 2021 14:08:37 +0800 (CST) Received: from dggema762-chm.china.huawei.com (10.1.198.204) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 31 May 2021 14:11:23 +0800 Received: from [10.174.179.129] (10.174.179.129) by dggema762-chm.china.huawei.com (10.1.198.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 31 May 2021 14:11:22 +0800 Subject: Re: [PATCH 2/3] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe() To: Vinod Koul CC: , , , , , , , References: <20210517081826.1564698-1-yukuai3@huawei.com> <20210517081826.1564698-3-yukuai3@huawei.com> From: "yukuai (C)" Message-ID: Date: Mon, 31 May 2021 14:11:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.179.129] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggema762-chm.china.huawei.com (10.1.198.204) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210530_231140_513750_5AC97B7D X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/05/31 12:00, Vinod Koul wrote: > On 17-05-21, 16:18, Yu Kuai wrote: >> pm_runtime_get_sync will increment pm usage counter even it failed. >> Forgetting to putting operation will result in reference leak here. >> Fix it by replacing it with pm_runtime_resume_and_get to keep usage >> counter balanced. >> >> Reported-by: Hulk Robot >> Signed-off-by: Yu Kuai >> --- >> drivers/dma/sh/usb-dmac.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c >> index 8f7ceb698226..2a6c8fd8854e 100644 >> --- a/drivers/dma/sh/usb-dmac.c >> +++ b/drivers/dma/sh/usb-dmac.c >> @@ -796,7 +796,7 @@ static int usb_dmac_probe(struct platform_device *pdev) >> >> /* Enable runtime PM and initialize the device. */ >> pm_runtime_enable(&pdev->dev); >> - ret = pm_runtime_get_sync(&pdev->dev); >> + ret = pm_runtime_resume_and_get(&pdev->dev); > > This does not seem to fix anything.. the below goto goes and disables > the runtime_pm for this device and thus there wont be any leak Hi, If pm_runtime_get_sync() fails and increments the pm.usage_count variable, pm_runtime_disable() does not reset the counter, and we still need to decrement the usage count when pm_runtime_get_sync() fails. Do I miss anthing? Thansk! Yu Kuai > >> if (ret < 0) { >> dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret); >> goto error_pm; >> -- >> 2.25.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel