From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE7EEB64D9 for ; Tue, 27 Jun 2023 13:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SfOElyIRrNNn8Y2/LLrSxboM26wojrEt5EvEs0bzYKs=; b=25/cMavnuPptIF yk+4TFkp4DYR3v264qPmpoY8ASRyf1GpR7UNQV1sreZnJVIGRg7oZCPneCiS8I2kG5Jn2Gu1fxNFN OGKLURruDylxPBChgjzEfOHdmKVy6cnZC+y7gDmHVulyXoOxoCJxksdcpGdHwnVbAFY8yOWEapPPn dT0iQGmM8U5UZU/gMNUMQ6njWS4DwzOyfW2Z38GEMsCGZI8hXesEGqCeUIyGAUUVhwjwosATv57hA LmfdeZZGVpiOAn27cN9PwatDye6IoKDkTBaHdtForLveghotL+cyRZSPa5iAAudxaQTcLWY/Rq89G SVm27Eo7nNg85f0uvNbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE8sh-00DICy-0b; Tue, 27 Jun 2023 13:37:19 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qE8sc-00DIBZ-1N for linux-arm-kernel@lists.infradead.org; Tue, 27 Jun 2023 13:37:18 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9891c73e0fbso818555066b.1 for ; Tue, 27 Jun 2023 06:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687873032; x=1690465032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zjn+m5IJNtwxVd6i0hgU1RQ6FBtfGTIs6fzcd38U4Jo=; b=fNEBITWaLLZCAFNoYkPQcaqn8qMhZVIH4tjFvICdPg7UH3NeqXNX09RHP19a29h8zL 4oAQbPXWNPZNaKyMaBoMMpnr3blZrVLVT+DPEMnbhP/nYY630gZvlRFHQf5Dt9WK1Ivv w+F57Jh2DuPGYZUOe6//JFfeQ26Zj+R3yIJY0YEd4Y1GcNSEgJU4n81O8HhrCtmV7Au8 Ng99JeM0diRKB11msr6h9cupKH9Ja0Cu00SxxaKQO+3RcJRSKiJf0hQp4SYummOo4zJD RiOuRzv6hTEdPBAq27Ayw2sN0TWu3A7VVbjCZovndTpye+j30JleNaSolsnjq9bXaDS7 TBgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687873032; x=1690465032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zjn+m5IJNtwxVd6i0hgU1RQ6FBtfGTIs6fzcd38U4Jo=; b=FV+1EZoX0L8XbMM2ae86S13DzokAbkigfHkxgsWxWAfunhV8FVcgwwSc9vwPteGmL2 cYrRG+FQvgItCHBG9Rc/MGxRAU5f9fmBO0p99tA8GeWPMRUUwiHRDF3lLlc6jvMxeXyt MFX9yy+DfwigG+VdqE6cvumI1nm83XA8hEIrspx44SeIW5bMpbekbnuGarlra5/kYQar hBzwIigTCV5dWv1LgoIGnSVTpu999oTvrsMsLJc0OyfeVyWSUqPtgLtx7du2Fc6li/3/ AA40+DgfVkh5qXsa2Mq7jMyN4Cgz3SsI6pe1DB7ozfnVje/4VmSlhoTLAw9TVB4fHZ0o VYsA== X-Gm-Message-State: AC+VfDz02hbwyftWo7D0dszbq9ZBiQga+2jNQcOjcECcrDjKUq31ovKj ywWnwyGGcnvCnhhoflZ3c45DlA== X-Google-Smtp-Source: ACHHUZ5KPZiM0xwFFkDm9ASG5ZrHrep9NXMTXPqfYF8cYZacARH7VH8i601pygIFhMDQpdq/gxZYxg== X-Received: by 2002:a17:907:2da6:b0:988:15f4:fdba with SMTP id gt38-20020a1709072da600b0098815f4fdbamr29369700ejc.14.1687873032258; Tue, 27 Jun 2023 06:37:12 -0700 (PDT) Received: from [10.230.170.72] (46-253-189-43.dynamic.monzoon.net. [46.253.189.43]) by smtp.gmail.com with ESMTPSA id i10-20020a170906250a00b0096a6be0b66dsm4573216ejb.208.2023.06.27.06.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 06:37:11 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 15:37:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: Aw: Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: update assigned-clocks/clock-parents for mt7986 To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei , Sam Shih , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230625191151.7808-1-linux@fw-web.de> <20230625191151.7808-2-linux@fw-web.de> <91411797-18b4-f515-d6c0-ca0f8ff39696@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230627_063714_487695_2F2E02E3 X-CRM114-Status: GOOD ( 24.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/06/2023 14:09, Frank Wunderlich wrote: >> Gesendet: Dienstag, 27. Juni 2023 um 12:44 Uhr >> Von: "Krzysztof Kozlowski" >> Betreff: Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: update assigned-clocks/clock-parents for mt7986 >> >> On 25/06/2023 21:11, Frank Wunderlich wrote: >>> From: Frank Wunderlich >>> >>> MT7986 has 2 clock-parents so update the binding for it. >> >> You didn't test it, I think. If you do, then you will see errors from >> other trees. > > Hi, > > i tested it of course...which errors do you see? The top-level said it can be maximum 1, so raising it in allOf:if:then: should not be enough > 11 > this is basicly how i tested it (in case anything has changed): > > logfile=dtbs_arm64.log > exec 3> >(tee $logfile) > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make DT_CHECKER_FLAGS=-m dt_binding_check 2>&3 > if [[ $? -ne 0 ]];then echo "arm64 binding check failed!";cat $logfile;exit 1;fi > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make defconfig #dtbs_check need kernel-config > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make -j8 DT_CHECKER_FLAGS=-m dtbs_check 2>&3 > if [[ $? -ne 0 ]];then echo "arm64 dtbs_check failed!";cat $logfile;exit 1;fi A bit over-complicated... why not running dtbs_check against the schema you changed? > > and looked into the resulting logfile for keywords like mmc like mtk-sd > > i tried running dtbs_check with passing the yaml-file, but of course all compatibles not matching this file were reported. > > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make -j6 DT_CHECKER_FLAGS=-m dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > but this spits out many errors "failed to match any schema with compatible" because i defined only the changed one... > > maybe there is another way to check only one yaml file against all dtbs without these unrelated errors. > > pipeline in dt-bindings-patchwork is clean too > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230625191151.7808-2-linux@fw-web.de/ Maybe that binding just fails to apply to DTS because of missing or not correct compatibles. > >> Anyway, I don't understand why defining it in the first place. Just drop >> the assigned-clock* from the binding. > > as it was defined (not looked where it was used) i only used the soc-specific branch to update the MaxItems...just to not break anything. After that the message i got before was fixed > > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: mmc@11230000: assigned-clocks: [[4, 35], [4, 34]] is too long > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: mmc@11230000: assigned-clock-parents: [[5, 6], [4, 18]] is too long > > but if the right way is to drop the MaxItems from generic (or the property itself - where is it taken from then?). The only > include i see is Documentation/devicetree/bindings/mmc/mmc-controller.yaml and there the assigned-clock* is not defined. And the The way is to entirely drop assigned-clocks. I don't think there are much benefits of having them in the bindings. Maybe if specific rates are required, then yes - device cannot work with other rates and you can verify it with dtbs_check. But otherwise it is like adding values of 'reg' or 'interrupts'. Plus some board might require third item and then what? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel