From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B277C54E58 for ; Fri, 15 Mar 2024 20:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ctPSTT/nb6SjvlnCr4qCh0SUyvqM69HUXerYjiyvkPM=; b=qZXZbSPo5OIo4x d4oI0b+vGftU+gtgX2llrIErtEKZ4ex6x6JMA+JWLdE5hWW5lWTc032qg+SCYWUwQnrDtTYybbLwq CcTbTH4Eh+A4+jL/JpDz/5RWHRnLvIzPM11bUh5Jkl21pauOMggzfcanN5AVIR1W++FvE7Ikq5op/ XIUhnp4+3qAMszDNlRcB+gq6PyMzRu84xVJRA9kW7VPTTDKmcoPWjo5XyMyP17aHZIJoASHtLVs6O l1awuJT5MR2j77BELz/z5j8dCx7Abn6nVXjzwyNOWWsi964emTGNtVPTwssZ21dMpZ9c3d2M1Tm0o WAO4yinJ917HXvBBx8Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlDwv-00000001P2T-3wzx; Fri, 15 Mar 2024 20:14:41 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlDwq-00000001P1m-1Urd for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2024 20:14:40 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a28a6cef709so352947666b.1 for ; Fri, 15 Mar 2024 13:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710533674; x=1711138474; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=odLjH6pCRhbd6VY/8IpKN5+gXDMhrfAYCr6uel2M/zo=; b=EiUMmNnfL9lKNDEw/2HUDqCRSL6v36GqCUCrKGufm+3j9LbMQYDIfNtW9IgjB0lSMn RO0KjI29sZaRmzUUOEFV6BDqBS6OdHUWAqHiFtmcQS0nHcZGPcqpArN6qU9Hgc3jPxAL aqm+GGcxjnyNzifKDK4WFnzBcg/4UjnaK1iZSfDM+qRYQ0j2kQSNrZB/VE0xCv2w4zmf 6Og2wTy7fQa71263DdC9L8aneq1hoIqWczTbalknO9x35nlT7n4rbpi6tBZJqE+M63Sx NTWJOgx8O7US29umJCRcEgbrm5oruOcIqFI8gn8oN0azoprERql2RthePvAumiQp3Bal WmwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710533674; x=1711138474; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=odLjH6pCRhbd6VY/8IpKN5+gXDMhrfAYCr6uel2M/zo=; b=dmg+qHCeAIN0obBSTTviooxVduymxI7ewgbSIUEFvd8CfjjUmyRQnCMHcLtDKywXAr N57QHOOVVG45ZMyxOJNeq9b+kzxMMAZCplsw17swEicZ2THyV3w9MWNXxNnBh0eaUa0o W+0GoqzATb0I7o3I5ckJl5IRginaqYiZ5GumFUeyE39OdlCKLRPiJfw8IWHFfi1FLfOj fgeAbdBnXcMDZ2lNi6Gflex6lj1xXFBaJ0/azYKKamg0/XdhP5pfP4HyzbcinXKcDqMT JJtrX38NATrPTL6jwQ0r/UnrL9zX0XfTTdsB8x9KA6GgrLIQcRNTuhb/WmFQoVsStBk9 5K2g== X-Forwarded-Encrypted: i=1; AJvYcCXWwVEYR8S8uqUNVeNsR+LKf0fBkqnF0yPk+j866vkk35emXJ8teEdzXQHS0yKnSak/HG/mQKLQEM9uI8pRPV4yTJnBr5zZMz5TLL/WZlBVHJTeris= X-Gm-Message-State: AOJu0YyIBpnR5xIG6JIpdtL7+hre43Ry7v9bVCY/gqrzx/Vil3F0qzu2 1n11fVBWoeR1KjRhInsvRKnEG+N0zQ36MHn/wbboFcwnbOgPlzY1WQtyIyYcYvE= X-Google-Smtp-Source: AGHT+IEsS46iEcSasaXWquxv5k5qikS5zVamCo2J4zeZor8vCboZ/fxtqwqJns14sHIDjc/FiAzt+Q== X-Received: by 2002:a17:907:72d5:b0:a46:a23f:bc2c with SMTP id du21-20020a17090772d500b00a46a23fbc2cmr27440ejc.25.1710533673785; Fri, 15 Mar 2024 13:14:33 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id hj11-20020a170906874b00b00a46a04d7daesm90052ejb.115.2024.03.15.13.14.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 13:14:33 -0700 (PDT) Message-ID: Date: Fri, 15 Mar 2024 21:14:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/8] w1: Add w1_find_master_device Content-Language: en-US To: Ayush Singh , linux-kernel@vger.kernel.org Cc: jkridner@beagleboard.org, robertcnelson@beagleboard.org, Vaishnav M A , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Jiri Slaby , Johan Hovold , Alex Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, greybus-dev@lists.linaro.org References: <20240315184908.500352-1-ayushdevel1325@gmail.com> <20240315184908.500352-3-ayushdevel1325@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240315184908.500352-3-ayushdevel1325@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_131436_443207_C71B92CC X-CRM114-Status: GOOD ( 18.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/03/2024 19:49, Ayush Singh wrote: > Add helper to find w1_master from w1_bus_master, which is present in > drvdata of platform device. Who needs this? > > Signed-off-by: Vaishnav M A > Signed-off-by: Ayush Singh > --- > drivers/w1/w1.c | 6 +++--- > drivers/w1/w1_int.c | 27 +++++++++++++++++++++++++++ > include/linux/w1.h | 1 + > 3 files changed, 31 insertions(+), 3 deletions(-) Why is this in the patchset? What are the dependencies? Please clearly express dependencies between patches or merging needs in cover letter. Otherwise please do not combine unrelated patches from different subsystems together. It's make review and merging only difficult. > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index afb1cc4606c5..ce8a3f93f2ef 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -673,9 +673,9 @@ static int __w1_attach_slave_device(struct w1_slave *sl) > sl->dev.of_node = of_find_matching_node(sl->master->dev.of_node, > sl->family->of_match_table); > > - dev_set_name(&sl->dev, "%02x-%012llx", > - (unsigned int) sl->reg_num.family, > - (unsigned long long) sl->reg_num.id); > + dev_set_name(&sl->dev, "%s-%02x-%012llx", sl->master->name, > + (unsigned int)sl->reg_num.family, > + (unsigned long long)sl->reg_num.id); > snprintf(&sl->name[0], sizeof(sl->name), Why? How is this related to the goal "add a helper"? Where is the helper used? I don't see. Don't combine unrelated topics in one patch. > "%02x-%012llx", > (unsigned int) sl->reg_num.family, > diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c > index 3a71c5eb2f83..2bfef8e67687 100644 > --- a/drivers/w1/w1_int.c > +++ b/drivers/w1/w1_int.c > @@ -242,3 +242,30 @@ void w1_remove_master_device(struct w1_bus_master *bm) > __w1_remove_master_device(found); > } > EXPORT_SYMBOL(w1_remove_master_device); > + > +/** > + * w1_find_master_device() - find a master device > + * @bm: master bus device to search > + */ > +struct w1_master *w1_find_master_device(struct w1_bus_master *bm) Why are you duplicating w1_search_master_id()? Without locking? Sorry, this looks like you did not look at all at existing code. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel